<div dir="ltr"><div><div><div>Hi Marco,<br><br>The current Debian sources for CTK are here:<br><a href="http://anonscm.debian.org/viewvc/debian-med/trunk/packages/ctk/trunk/debian/">http://anonscm.debian.org/viewvc/debian-med/trunk/packages/ctk/trunk/debian/</a><br>
<br></div>I merged a few of your changes into the trunk. Unfortunately I am still running into compilation issues when specifying <br> -DCTK_LIB_DICOM/Core:BOOL=ON<br><br>In file included from /usr/include/dcmtk/ofstd/ofstring.h:65:0,<br>
from /usr/include/dcmtk/oflog/tstring.h:27,<br> from /usr/include/dcmtk/oflog/streams.h:27,<br> from /usr/include/dcmtk/oflog/loglevel.h:29,<br> from /usr/include/dcmtk/oflog/logger.h:28,<br>
from /usr/include/dcmtk/oflog/oflog.h:35,<br> from /usr/include/dcmtk/dcmdata/dctypes.h:34,<br> from /usr/include/dcmtk/dcmdata/dcbytstr.h:35,<br> from /usr/include/dcmtk/dcmdata/dcchrstr.h:48,<br>
from /usr/include/dcmtk/dcmdata/dcvrpn.h:35,<br> from /tmp/ctk/trunk/ctk-0.1.0~git20121219/Libs/DICOM/Core/ctkDICOMModel.cpp:33:<br>/usr/include/dcmtk/ofstd/ofstream.h:67:22: fatal error: iostream.h: No such file or directory<br>
<br></div><div>I am using an older dcmtk (3.6.0-9), will try with a newer version soon.<br></div><div><br></div>I
also believe that the current github version contains your changes
already. Your patch debian/patches/backport-of-dcmscu-from-dcmtk-3.6.1
doesn't apply cleanly and can probably removed.<br><br>Any idea when CTK is using a plain pythonqt version? I would like to turn on another option as well.<br> -DCTK_LIB_Scripting/Python/Core:BOOL=ON<br><br></div>
<div>Cheers<br></div>-Dominique</div><div class="gmail_extra"><br><br><div class="gmail_quote">On Wed, Dec 19, 2012 at 1:13 PM, Nolden, Marco <span dir="ltr"><<a href="mailto:M.Nolden@dkfz-heidelberg.de" target="_blank">M.Nolden@dkfz-heidelberg.de</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div class="HOEnZb"><div class="h5">
<div link="blue" vlink="purple" lang="DE"><div><p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1f497d" lang="EN-US">Hi Dominique,<u></u><u></u></span></p><p class="MsoNormal">
<span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1f497d" lang="EN-US"><u></u> <u></u></span></p><p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1f497d" lang="EN-US">Sounds great, thanks. CTK’s super build currently uses an unpatched 5.10.0, so I guess it works. The config is here: <u></u><u></u></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1f497d" lang="EN-US"><u></u> <u></u></span></p><p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1f497d" lang="EN-US"><a href="https://github.com/commontk/CTK/blob/master/CMakeExternals/VTK.cmake" target="_blank">https://github.com/commontk/CTK/blob/master/CMakeExternals/VTK.cmake</a><u></u><u></u></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1f497d" lang="EN-US"><u></u> <u></u></span></p><p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1f497d" lang="EN-US">For my tests in Bologna I used the VTK 5.8 that’s currently included in Debian sid.<u></u><u></u></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1f497d" lang="EN-US"><u></u> <u></u></span></p><p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1f497d" lang="EN-US">I do not have much experience with debian packaging, so in my github the most useful addition is probably the version number generation code. I read a bit about git-based packaging but too many things were new to me. Do you think it would make sense to work on the package itself on github or is there an official debian location for that?<u></u><u></u></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1f497d" lang="EN-US"><u></u> <u></u></span></p><p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1f497d" lang="EN-US">Best<u></u><u></u></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1f497d" lang="EN-US">Marco<u></u><u></u></span></p><p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1f497d" lang="EN-US"><u></u> <u></u></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1f497d" lang="EN-US"><u></u> <u></u></span></p><p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1f497d" lang="EN-US"><u></u> <u></u></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1f497d" lang="EN-US"><u></u> <u></u></span></p><p class="MsoNormal"><b><span style="font-size:10.0pt;font-family:"Tahoma","sans-serif"" lang="EN-US">Von:</span></b><span style="font-size:10.0pt;font-family:"Tahoma","sans-serif"" lang="EN-US"> Dominique Belhachemi [<a href="mailto:domibel.dd@gmail.com" target="_blank">mailto:domibel.dd@gmail.com</a>] <br>
<b>Gesendet:</b> Mittwoch, </span><span style="font-size:10.0pt;font-family:"Tahoma","sans-serif"">19. Dezember 2012 16:00<br><b>An:</b> Nolden, Marco<br><b>Cc:</b> <a href="mailto:ctk-developers@commontk.org" target="_blank">ctk-developers@commontk.org</a><br>
<b>Betreff:</b> Re: [Ctk-developers] CTK, DCMTK and Debian<u></u><u></u></span></p><p class="MsoNormal"><u></u> <u></u></p><div><div><p class="MsoNormal" style="margin-bottom:12.0pt">Hi Marco,<u></u><u></u></p></div><div>
<p class="MsoNormal" style="margin-bottom:12.0pt">I can help with updating VTK+CTK in Debian Experimental. Does the current CTK work with an unpatched VTK 5.10?<u></u><u></u></p></div><div><p class="MsoNormal">Thanks<u></u><u></u></p>
</div><div><p class="MsoNormal">-Dominique<u></u><u></u></p></div></div><div><p class="MsoNormal" style="margin-bottom:12.0pt"><u></u> <u></u></p><div><p class="MsoNormal">On Wed, Dec 19, 2012 at 3:23 AM, Nolden, Marco <<a href="mailto:M.Nolden@dkfz-heidelberg.de" target="_blank">M.Nolden@dkfz-heidelberg.de</a>> wrote:<u></u><u></u></p>
<p class="MsoNormal">Hi,<br><br>during the Bologna hackfest I succeeded (with the help of Michael!) to build CTK again with a plain DCMTK 3.6.0 and also fixed compatibility with Debian's VTK 5.8. I created a summary page of the status on the wiki: <a href="http://www.commontk.org/index.php/Debian_Packaging" target="_blank">http://www.commontk.org/index.php/Debian_Packaging</a> . Maybe other people who did some work in that area could add some comments or useful links.<br>
<br>Best<br>Marco<br><br><br>-----Ursprüngliche Nachricht-----<br>Von: <a href="mailto:ctk-developers-bounces@commontk.org" target="_blank">ctk-developers-bounces@commontk.org</a> [mailto:<a href="mailto:ctk-developers-bounces@commontk.org" target="_blank">ctk-developers-bounces@commontk.org</a>] Im Auftrag von Nolden, Marco<br>
Gesendet: Dienstag, 11. Dezember 2012 17:03<br>An: Michael Onken; <a href="mailto:ctk-developers@commontk.org" target="_blank">ctk-developers@commontk.org</a><br>Cc: <a href="mailto:dicom@offis.de" target="_blank">dicom@offis.de</a><u></u><u></u></p>
<div><div><p class="MsoNormal">Betreff: Re: [Ctk-developers] CTK, DCMTK and Debian<br><br>Hi Michael,<br><br>I'm currently at the hackfest in Bologna and can further investigate your suggestion. I tried to integrate a recent scu.cc in CTK: there are a lot of compile errors related to changes in the logging or error constants on the DCMTK side:<br>
<br><a href="https://github.com/nolden/ctk-debian/issues/1" target="_blank">https://github.com/nolden/ctk-debian/issues/1</a><br><br>Any chance to back port also the required stuff or should we just use an older scu?<br><br>
Best,<br>Marco<br><br><br>-----Ursprüngliche Nachricht-----<br>Von: <a href="mailto:ctk-developers-bounces@commontk.org" target="_blank">ctk-developers-bounces@commontk.org</a> [mailto:<a href="mailto:ctk-developers-bounces@commontk.org" target="_blank">ctk-developers-bounces@commontk.org</a>] Im Auftrag von Michael Onken<br>
Gesendet: Dienstag, 30. Oktober 2012 12:53<br>An: <a href="mailto:ctk-developers@commontk.org" target="_blank">ctk-developers@commontk.org</a><br>Betreff: Re: [Ctk-developers] CTK, DCMTK and Debian<br><br>Hi Marco,<br><br>
On 25.10.2012 17:16, Marco Nolden wrote:<br><br>> 2. DCMTK in debian is version 3.6.0. This unfortunately lacks the SCU<br>> functionality we're using for Query/Retrieve. Before switching to<br>> 3.6.1 in the superbuild we had a backported version of the new SCU<br>
> class in the CTK repository (ctkDcmSCU). I tried to reactivate this<br>> backport in my modified package but it failed to compile. I think the<br>> best way for this would be to fix this in CTK itself by putting the<br>
> new SCU class there again, make it compile and add some CMake logic<br>> based on the DCMTK version to choose the right class. But I'm not sure<br>> which other non-compatible changes we have that require DCMTK >=<br>
> 3.6.1.<br><br>To my knowledge (which may be outdated) no new source code functionality besides DcmSCU enhancements are used in CTK.<br><br>I would try to copy any recent DcmSCU.h/cc, rename the files (and<br>classes) to CtkSCU.h/cc and use them in the CTK code instead. Then look how far you can get with that.<br>
<br>However, there may have been changes in the BUILD infrastructure that you rely on but I do not have an overview what is used at the moment, or whether it is highly relevant for Debian builds.<br><br>Best,<br>Michael<br>
<br>--<br>Dipl.-Inform. Michael Onken<br>FuE Bereich Gesundheit | R&D Division Health<br><br>OFFIS<br>FuE Bereich Gesundheit | R&D Division Health Escherweg 2 - 26121 Oldenburg - Germany<br>Phone/Fax.: <a href="tel:%2B49%20441%209722-149%2F111" value="+494419722149111" target="_blank">+49 441 9722-149/111</a><br>
E-Mail: <a href="mailto:onken@offis.de" target="_blank">onken@offis.de</a><br>URL: <a href="http://www.offis.de" target="_blank">http://www.offis.de</a><br>_______________________________________________<br>Ctk-developers mailing list<br>
<a href="mailto:Ctk-developers@commontk.org" target="_blank">Ctk-developers@commontk.org</a><br><a href="http://public.kitware.com/cgi-bin/mailman/listinfo/ctk-developers" target="_blank">http://public.kitware.com/cgi-bin/mailman/listinfo/ctk-developers</a><br>
_______________________________________________<br>Ctk-developers mailing list<br><a href="mailto:Ctk-developers@commontk.org" target="_blank">Ctk-developers@commontk.org</a><br><a href="http://public.kitware.com/cgi-bin/mailman/listinfo/ctk-developers" target="_blank">http://public.kitware.com/cgi-bin/mailman/listinfo/ctk-developers</a><u></u><u></u></p>
</div></div></div><p class="MsoNormal"><u></u> <u></u></p></div></div></div></div></div></blockquote></div><br></div>