Big thanks Sascha!<br><br><div class="gmail_quote">On Sat, May 12, 2012 at 7:46 AM, Sascha Zelzer <span dir="ltr"><<a href="mailto:s.zelzer@dkfz-heidelberg.de" target="_blank">s.zelzer@dkfz-heidelberg.de</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div bgcolor="#FFFFFF" text="#000000">
Hi,<br>
<br>
just for your information, CTK now (well, since a couple of days)
uses the DCMTK 3.6.1 snapshot (22/02/2012).<br>
<br>
CTK and all its dependencies can now be build with Clang.
Additionally, the custom DICOM SCU files have been removed from CTK
and the CTK DICOM library now uses the SCU classes from DCMTK.<br>
<br>
Best,<br>
Sascha<div><div class="h5"><br>
<br>
On 04/30/2012 07:05 PM, Julien Finet wrote:
<blockquote type="cite">If you didn't change from Static to Shared, then no
worries, it should be fine with Slicer.
<div>Thanks,<br>
<div>j.<br>
<br>
<div class="gmail_quote">On Mon, Apr 30, 2012 at 12:47 PM,
Sascha Zelzer <span dir="ltr"><<a href="mailto:s.zelzer@dkfz-heidelberg.de" target="_blank">s.zelzer@dkfz-heidelberg.de</a>></span>
wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div text="#000000" bgcolor="#FFFFFF"> Hi J2,<br>
<br>
I'm not sure I fully understand your question. I did not
change the build type, DCMTK is still build as a static
library (I tried building in shared mode but then some
CTK DICOM tests did not run on Linux because the DCMTK
command line tools do not contain rpath entries and
hence the shared libs were not found).<br>
<br>
I didn't touch anything "install" related either,
everything is as it was before concerning the DCMTK
build options (except an added
DCMTK_WITH_DOXYGEN:BOOL=OFF and an explicit line for
BUILD_SHARED_LIBS:BOOL=OFF which is the default).<br>
<br>
Thanks for having a look,<br>
<br>
Sascha
<div>
<div><br>
<br>
On 04/30/2012 05:53 PM, Julien Finet wrote:
<blockquote type="cite">
<div>Hi Sashcha,</div>
<div><br>
</div>
<div>Thanks for taking care of it. I've not tried
the "install" rules of DCMTK. Do you confirm it
works as expected.</div>
<div>For Slicer, before we can use DCMTK as shared
we need to make sure the Slicer packaging works
fine with DCMTK, especially with the Mac fixup
:-/</div>
<div><br>
</div>
<div>J.</div>
<div><br>
<div class="gmail_quote">On Sun, Apr 29, 2012 at
5:28 AM, Sascha Zelzer <span dir="ltr"><<a href="mailto:s.zelzer@dkfz-heidelberg.de" target="_blank">s.zelzer@dkfz-heidelberg.de</a>></span>
wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div text="#000000" bgcolor="#FFFFFF"> Hi
Folks,<br>
<br>
I would look to see proper Clang support
in CTK (and hence MITK) such that the
native build tools on MacOS can be used
(Clang is the default compiler for XCode).<br>
<br>
It looks like the only show-stopper is the
DCMTK version we are using. This problem
has already been identified on the the
Slicer mailing list [1] and I suggest to
move forward with Jc's option b)<br>
<br>
<pre><span><span>Update the sha1 of </span></span><span><a href="http://git.dcmtk.org/dcmtk.git" rel="nofollow" link="external" target="_blank"><span>git.<span>dcmtk</span>.org/<span>dcmtk</span>.git</span></a></span><span> </span><span><span> required to build CTK</span></span></pre>
<br>
Using the DCMTK 3.6.1 snapshot [2] would
fix the DCMTK Clang issues and would also
fix a few other issues we had in CTK (J2's
static initialization problems and the
duplicated DICOM SCU class). You can have
a look at the necessary changes in CTK
here:<br>
<br>
<a href="https://github.com/saschazelzer/CTK/compare/master...dcmtk-3.6.1-snapshot-compatibility" target="_blank">https://github.com/saschazelzer/CTK/compare/master...dcmtk-3.6.1-snapshot-compatibility</a><br>
<br>
Does anybody have any objections to
merging the above branch into CTK master?<br>
<br>
Thanks,<br>
<br>
Sascha<br>
<br>
<br>
[1]: <a href="http://slicer-devel.65872.n3.nabble.com/DCMTK-clang-compiler-errors-td3811531.html" target="_blank">http://slicer-devel.65872.n3.nabble.com/DCMTK-clang-compiler-errors-td3811531.html</a><br>
[2]: <a href="http://support.dcmtk.org/wiki/dcmtk/news/start" target="_blank">http://support.dcmtk.org/wiki/dcmtk/news/start</a><br>
</div>
<br>
_______________________________________________<br>
Ctk-developers mailing list<br>
<a href="mailto:Ctk-developers@commontk.org" target="_blank">Ctk-developers@commontk.org</a><br>
<a href="http://public.kitware.com/cgi-bin/mailman/listinfo/ctk-developers" target="_blank">http://public.kitware.com/cgi-bin/mailman/listinfo/ctk-developers</a><br>
<br>
</blockquote>
</div>
<br>
</div>
</blockquote>
<br>
</div>
</div>
</div>
</blockquote>
</div>
<br>
</div>
</div>
</blockquote>
<br>
</div></div></div>
<br>_______________________________________________<br>
Ctk-developers mailing list<br>
<a href="mailto:Ctk-developers@commontk.org">Ctk-developers@commontk.org</a><br>
<a href="http://public.kitware.com/cgi-bin/mailman/listinfo/ctk-developers" target="_blank">http://public.kitware.com/cgi-bin/mailman/listinfo/ctk-developers</a><br>
<br></blockquote></div><br>