Hi Sascha,<div>Thanks for taking the time to review the branch.</div><div>Concerning your comments, I think there is a misunderstanding. QtTesting is a library that lives in its own library. In order to work within CTK (external dependency), some CTK widgets have custom recorder and players. So if <span style="background-color:rgb(255,255,204);font-family:'Bitstream Vera Sans Mono','Courier New',monospace;font-size:12px;line-height:17px;white-space:pre">CTK_USE_QTTESTING </span>is <span style="background-color:rgb(255,255,204);font-family:'Bitstream Vera Sans Mono','Courier New',monospace;font-size:12px;line-height:17px;white-space:pre">ON </span>the QtTesting project is downloaded and built. Within CTK, the Libs/QtTesting directory contains CTK customization for QtTesting.</div>
<div>We will create a wiki documentation page to further detail technicalities.</div><div>Thanks,</div><div>Julien.</div><div><br><div class="gmail_quote">On Sat, May 12, 2012 at 7:36 AM, Sascha Zelzer <span dir="ltr"><<a href="mailto:s.zelzer@dkfz-heidelberg.de" target="_blank">s.zelzer@dkfz-heidelberg.de</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div bgcolor="#FFFFFF" text="#000000">
Hi,<br>
<br>
+1 one from me (but see my comments below)<br>
<br>
<br>
Thanks for putting so much effort into this, it looks really good!
(I just skimmed through the code changes...)<br>
<br>
There is one small issue though: In the current CTK branch [3] you
seem to have some left-overs from the past were you referenced
QtTesting as an external project. If I understood the changes
correctly, you should probably remove this line:<br>
<br>
<a href="https://github.com/commontk/CTK/compare/master...qttesting#L11L724" target="_blank">https://github.com/commontk/CTK/compare/master...qttesting#L11L724</a><br>
<br>
and also remove that file:<br>
<br>
<a href="https://github.com/commontk/CTK/compare/master...qttesting#diff-10" target="_blank">https://github.com/commontk/CTK/compare/master...qttesting#diff-10</a><br>
<br>
<br>
Thanks for your work,<br>
<br>
Sascha<div><div class="h5"><br>
<br>
<br>
On 05/10/2012 11:23 PM, Julien Finet wrote:
<blockquote type="cite">Hi CTKers,
<div><br>
</div>
<div>We have been working toward integrating the QtTesting
framework [1] into CTK. Kudos to Benjamin for his hard work !</div>
<br>
<div>The Qt testing framework is an effort from the ParaView team
which now resides in its own repository [2a][2b]. </div>
<div>Our integration work is currently in a QtTesting branch [3]
in CTK and is currently in use by Slicer (builds and package
fine on all our dashboard machines)</div>
<div><br>
</div>
<div>It is still work in progress and more work will happen in the
coming weeks [4] </div>
<div>However we would like to merge the branch into CTK master in
order to keep working on other CTK issues for Slicer. </div>
<div>Indeed Slicer currently points to the QtTesting head and we'd
like to go back to pointing on master.</div>
<div><br>
</div>
<div>Does anyone think we shouldn't merge or has any comment?</div>
<div><br>
</div>
<div>Thanks,</div>
<div>Julien.</div>
<div><br>
</div>
<div>
<div>[1] <a href="http://paraview.org/Wiki/Testing_design" target="_blank">http://paraview.org/Wiki/Testing_design</a></div>
<div>[2a]<span style="color:rgb(102,102,102);font-family:Helvetica,arial,freesans,clean,sans-serif;font-size:13px;line-height:20px;background-color:rgb(250,250,250)"> <a href="http://paraview.org/gitweb?p=QtTesting.git" target="_blank">http://paraview.org/gitweb?p=QtTesting.git</a> </span></div>
<div>[2b] <a href="https://github.com/commontk/QtTesting" target="_blank">https://github.com/commontk/QtTesting</a></div>
<div>[3] <a href="https://github.com/commontk/CTK/tree/qttesting" target="_blank">https://github.com/commontk/CTK/tree/qttesting</a></div>
<div>[4] <a href="https://github.com/commontk/CTK/issues?direction=desc&labels=Testing&page=1&sort=created&state=open" target="_blank">https://github.com/commontk/CTK/issues?direction=desc&labels=Testing&page=1&sort=created&state=open</a>
</div>
</div>
</blockquote>
<br>
</div></div></div>
</blockquote></div><br></div>