Hi Marco,<div><br></div><div>Sorry, I don't know since when the problem appeared as we "recently" (few months) added the DICOM support in Slicer and the crash is somewhat tricky to reproduce and not on all machines (I had to install a VM to investigate the issue).</div>
<div><br></div><div>Julien. <br><br><div class="gmail_quote">On Wed, Feb 15, 2012 at 9:13 AM, Marco Nolden <span dir="ltr"><<a href="mailto:m.nolden@dkfz-heidelberg.de">m.nolden@dkfz-heidelberg.de</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Hi Jörg and Julien,<br>
<br>
I'm also affected by the problem now on Fedora 16. Is there any workaround? I can't start our application at all. @Julien: did you notice which change in CTK introduced the problem?<br>
<br>
Best<br>
Marco<div><div class="h5"><br>
<br>
<br>
On 02/03/2012 05:40 PM, Julien Finet wrote:<br>
</div></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div><div class="h5">
Hi Jorg,<br>
<br>
I tried to compile CTK with the latest DCTMK and I still have the "pure<br>
virtual method called" crash with DCMTK trunk compiled within CTK.<br>
Minor changes to CTK must be done to be able to build CTK with DCMTK<br>
trunk: (see <a href="https://github.com/finetjul/CTK/tree/dcmtk-trunk" target="_blank">https://github.com/finetjul/<u></u>CTK/tree/dcmtk-trunk</a>)<br>
(I then configure my ofConditionCrash project doing the following:<br>
ccmake<br>
-DDCMTK_DIR:STRING=~/Work/CTK/<u></u>CTK-Superbuild/CMakeExternals/<u></u>Install ../src).<br>
Can you suggest a work-around for the time being ?<br>
<br>
However, if I manually build DCMTK, then there is no crash in my project<br>
ofConditionCrash. I'm not sure what's different between DCMTK in CTK and<br>
a stand alone DCMTK :-/<br>
<br>
Anyway, when you guys rewrite the OfCondition code, can you please try<br>
to build DCMTK in CTK and test the ofConditionCrash project (you might<br>
want to make it a unit test within DCMTK) ?<br>
<br>
Thanks a lot for your help,<br>
Julien.<br>
p.s. see bellow a DCMTK trunk build error (ubuntu 11.10, 64bits, cmake<br>
2.8.5) with a suggested fix.<br>
<br>
HEAD is now at b99bb83... Don't call MSVC++ with -fvisibility=hidden.<br>
[ 60%] [ 60%] No update step for 'DCMTK'<br>
No patch step for 'DCMTK'<br>
[ 60%] Performing configure step for 'DCMTK'<br>
loading initial cache file<br>
/home/julien/Work/Slicer/<u></u>Slicer4/Slicer4-Debug/CTK-<u></u>build/DCMTK-cmake/tmp/DCMTK-<u></u>cache.cmake<br>
CMake Error at CMake/FindICONV.cmake:20 (FIND_PACKAGE_HANDLE_STANDARD_<u></u>ARGS):<br>
Unknown CMake command "FIND_PACKAGE_HANDLE_STANDARD_<u></u>ARGS".<br>
Call Stack (most recent call first):<br>
CMake/3rdparty.cmake:229 (FIND_PACKAGE)<br>
CMakeLists.txt:260 (INCLUDE)<br>
<br>
-- Configuring incomplete, errors occurred!<br>
make[5]: *** [DCMTK-cmake/src/DCMTK-stamp/<u></u>DCMTK-configure] Error 1<br>
make[4]: *** [CMakeFiles/DCMTK.dir/all] Error 2<br>
make[3]: *** [all] Error 2<br>
make[2]: *** [CTK-prefix/src/CTK-stamp/CTK-<u></u>build] Error 2<br>
make[1]: *** [CMakeFiles/CTK.dir/all] Error 2<br>
make: *** [all] Error 2<br>
<br>
Can be fixed by adding: include(<u></u>FindPackageHandleStandardArgs) in<br>
CMake/FindICONV.cmake<br>
<br>
On Fri, Feb 3, 2012 at 8:41 AM, Julien Finet <<a href="mailto:julien.finet@kitware.com" target="_blank">julien.finet@kitware.com</a><br></div></div><div class="im">
<mailto:<a href="mailto:julien.finet@kitware.com" target="_blank">julien.finet@kitware.<u></u>com</a>>> wrote:<br>
<br>
Great, thanks a lot !<br>
<br>
Maybe we should upgrade the DCMTK version in CTK...<br>
<br>
Thanks,<br>
Julien.<br>
<br>
On Fri, Feb 3, 2012 at 8:21 AM, OFFIS DICOM Team <<a href="mailto:dicom@offis.de" target="_blank">dicom@offis.de</a><br></div><div class="im">
<mailto:<a href="mailto:dicom@offis.de" target="_blank">dicom@offis.de</a>>> wrote:<br>
<br>
Hi Julien,<br>
<br>
<br>
I wrote a simpler project that reproduces the crash, can you<br>
try it on your<br>
machine ?<br>
<br>
<br>
sure, I just did it and can confirm that the program crashes on<br>
this machine with the error message "pure virtual method called".<br>
<br>
<br>
Let me know how it goes. For information, I use the same<br>
DCMTK built by CTK:<br>
$ ccmake<br></div>
-DDCMTK_DIR=~/Work/CTK/CTK-__<u></u>noPython/CMakeExternals/__<u></u>Install<div class="im"><br>
../src<br>
<br>
<br>
Thank you for the hint, I used the same version of DCMTK and<br>
could reproduce the crash. When I used the current development<br>
version from our public git repository, it did not crash. Maybe,<br>
is has to do with our ongoing efforts regarding the support of<br>
shared libraries (see CHANGES file).<br>
<br>
Anyway, since the current concept of the OFCondition classes<br>
creates much trouble with both shared libraries and static<br>
objects, we are currently trying to rewrite the code.<br>
<br>
<br>
Regards,<br>
Jörg Riesmeier<br>
--<br>
OFFIS DICOM Team, Escherweg 2, 26121 Oldenburg, Germany<br></div>
E-Mail: <a href="mailto:dicom@offis.de" target="_blank">dicom@offis.de</a> <mailto:<a href="mailto:dicom@offis.de" target="_blank">dicom@offis.de</a>>, URL:<br>
<a href="http://dicom.offis.de" target="_blank">http://dicom.offis.de</a><br>
<br>
<br>
<br><span class="HOEnZb"><font color="#888888">
</font></span></blockquote><span class="HOEnZb"><font color="#888888">
<br>
<br>
-- <br>
------------------------------<u></u>------------------------------<u></u>----------<br>
Dipl.-Inform. Med. Marco Nolden<br>
Deutsches Krebsforschungszentrum (German Cancer Research Center)<br>
Div. Medical & Biological Informatics Tel: <a href="tel:%28%2B49%29%206221-42%202325" value="+496221422325" target="_blank">(+49) 6221-42 2325</a><br>
Im Neuenheimer Feld 280 Fax: <a href="tel:%28%2B49%29%206221-42%202345" value="+496221422345" target="_blank">(+49) 6221-42 2345</a><br>
D-69120 Heidelberg eMail: <a href="mailto:M.Nolden@dkfz.de" target="_blank">M.Nolden@dkfz.de</a><br>
</font></span></blockquote></div><br></div>