Hi Folks, <br><br>Florian Link, from MeVisLab, has been very responsive and, less than 24hours following my initial email, already provided me with feedback regarding the possible integration of our CTK specific changes. See below.<br>
<br>Its only concern regards the license associated with two of the file I added to PythonQt. I added them using CTK license. <br><br>Being the author of the files, I have no problem switching the license to LGPL so that our contribution can be merged upstream. <br>
<br>1) I would like to make sure we all agree.<br><br>2) Discuss the licensing of contribution associated with our contribution to LGPL libraries.<br><br>Thanks for your feedback, <br>Jc<br><br><div class="gmail_quote">---------- Forwarded message ----------<br>
From: <b class="gmail_sendername">Florian Link</b> <span dir="ltr"><<a href="mailto:florian.link@mevis.de">florian.link@mevis.de</a>></span><br>Date: Tue, Oct 18, 2011 at 3:02 AM<br>Subject: Re: Contribution to PythonQt<br>
To: Jean-Christophe Fillion-Robin <<a href="mailto:jchris.fillionr@kitware.com">jchris.fillionr@kitware.com</a>><br>Cc: <a href="mailto:info@mevislab.de">info@mevislab.de</a>, Dominique Belhachemi <<a href="mailto:domibel@debian.org">domibel@debian.org</a>><br>
<br><br><u></u>
<div bgcolor="#ffffff" text="#000000">
Dear Jean-Christophe,<br>
<br>
I had a look at your changes. I suggest the following:<br>
<br>
- the warnings/small unicode fixes are not a problem and can be
merged easily<br>
- the VTK wrapping should be done by supporting class wrapping
callbacks in PythonQt,<br>
so that the VTK wrapping code can be located outside of PythonQt<br>
(I can add those callbacks). You will then have to register your
VTK wrapping callbacks where you initialize PythonQt.<br>
- the std in redirection makes sense and can be merged<br>
- the generator fixes/warnings are ok and can be merged<br>
- the dPython.h file seems to be a special fix that you did, this
should be switchable, since some people want a debug Python with
using debug PythonQt.<br>
<br>
This leaves us with the licensing issue. I can only accept code that
you submit under the LGPL 2.1, so the Apache 2 license is<br>
not an option (I don't want PythonQt to get multi-license). Since
this only regards dPython.h and PythonQtStdIn*,<br>
I guess you do not have a problem with submitting those under LGPL
2.1?<br>
<br>
regards,<br>
Florian<div class="im"><br>
<br>
Am 17.10.2011 16:49, schrieb Jean-Christophe Fillion-Robin:
</div><blockquote type="cite">
Dear MevisLab / PythonQt developers, <br><div><div></div><div class="h5">
<br>
My name is Jean-Christophe, R&D engineer at <a href="http://www.kitware.com" target="_blank">Kitware
Inc.</a>, and I am actively involved in the development of <a href="http://www.slicer.org" target="_blank">Slicer 4.0</a>,
a medical multi-platform, free open source software for
visualization and image computing. <br>
<br>
While working on Slicer, a lot of code has been contributed to the
open source toolkit named <a href="http://www.commontk.org" target="_blank">CTK</a>. The Common ToolKit (CTK)
provides a unified set of basic programming constructs that are
useful for medical imaging applications development. More
information are available here: <a href="http://www.commontk.org" target="_blank">http://www.commontk.org</a><br>
<br>
PythonQt being the python scripting "backend" of CTK, we added
some code and we would like to contribute back. <br>
<br>
Dominique Belhachemi, a volunteer Debian packager, is helping us
to package both CTK and Slicer. He suggested that we contribute
back our code so that the currently existing PythonQt
libraries/packages include our changes. <br>
<br>
The list of changes is available here: <a href="https://github.com/commontk/PythonQt/compare/svn-mirror...patched" target="_blank">https://github.com/commontk/PythonQt/compare/svn-mirror...patched</a><br>
<br>
It includes:<br>
- CMake'ification of the project<br>
- Support for VTK python<br>
<br>
Would be great if you could let us know if that sounds like a
reasonable idea or if we should improve anything.<br clear="all">
<br>
Thanks<br>
Jc<br>
<br>
Cc: Dominique Belhachemi<br>
<br>
-- <br>
<a href="tel:%2B1%20919%20869%208849" value="+19198698849" target="_blank">+1 919 869 8849</a><br>
<br>
</div></div></blockquote>
<br><div class="im">
<br>
<pre cols="72">--
------------------------------------------------------------------------
Florian Link
Chief Software Architect MeVisLab
Tel.: <a href="tel:%2B49-421-22495%2052" value="+494212249552" target="_blank">+49-421-22495 52</a>
Fax: <a href="tel:%2B49-421-22495%2011" value="+494212249511" target="_blank">+49-421-22495 11</a>
<a href="http://www.mevis.de" target="_blank">www.mevis.de</a>
MeVis Medical Solutions AG
Universitaetsallee 29
28359 Bremen
Germany
Trade Registry: Bremen HRB 23791
VAT ID: DE250659412
Executive Board: Carl J.G. Evertsz, Ph.D. (Chairman & CEO), Robert Hannemann Ph.D., Thomas E. Tynes
Chairman of the Supervisory Board: Heinz-Otto Peitgen, Ph.D.
</pre>
</div></div>
</div><br><br clear="all"><br>-- <br>+1 919 869 8849<br><br>