<html>
<head>
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
Hi Jc,<br>
<br>
Looks good. I guess the CTKCore dependency of the ctkPluginFramework
was just a matter of time, so I am good with it.<br>
<br>
Just a little "style" comment: The "rmdir" function name looks a
little out of place when compared with the others. What about
"removeDir"? Just my two cents.<br>
<br>
Thanks for pushing code reuse,<br>
<br>
Sascha<br>
<br>
On 09/01/2011 06:26 PM, Jean-Christophe Fillion-Robin wrote:
<blockquote
cite="mid:%20%3CCANLz8R58ORRx4R-0tJF+V5mtbuUF6UkhGKTugkrAmTLP430s8A@mail.gmail.com"
type="cite">Hi Folks, <br>
<br>
I was looking for a function to delete recursively a function and
I found out that such code has present in multiple location:<br>
- <a moz-do-not-send="true"
href="https://github.com/jcfr/CTK/commit/8714424163b376c4efb693448278a10e13a8690a#diff-4">ctkPluginFrameworkUtil_p.h</a><br>
- <a moz-do-not-send="true"
href="https://github.com/jcfr/CTK/commit/8714424163b376c4efb693448278a10e13a8690a#diff-0">ctkPluginGenerator.cpp</a><br>
<br>
Topic "ctkutils-rmdir" has been integrated to master. It includes:<br>
- addition of "rmdir" function to ctkUtils<br>
- implementation of the corresponding test in ctkUtilsTest4.cpp<br>
- See <a moz-do-not-send="true"
href="https://github.com/commontk/CTK/commit/fd8cfead27c56ae607e379d764d2eb790d16af3e">https://github.com/commontk/CTK/commit/fd8cfead27c56ae607e379d764d2eb790d16af3e</a><br>
<br>
Topic "reuse-ctkutil-rmdir-in-toolkit" has NOT been integrated to
master, indeed it implies that ctkPluginFramework will depend on
CTKCore. Does that sounds reasonable ? <br>
See <a moz-do-not-send="true"
href="https://github.com/jcfr/CTK/tree/reuse-ctkutil-rmdir-in-toolkit">https://github.com/jcfr/CTK/tree/reuse-ctkutil-rmdir-in-toolkit</a>
<br>
and <a moz-do-not-send="true"
href="https://github.com/jcfr/CTK/commit/8714424163b376c4efb693448278a10e13a8690a">https://github.com/jcfr/CTK/commit/8714424163b376c4efb693448278a10e13a8690a</a><br>
<br>
Thanks<br>
Jc<br>
<br>
<br clear="all">
<br>
-- <br>
+1 919 869 8849<br>
<br>
</blockquote>
<br>
</body>
</html>