<html>
<head>
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
Even better!<br>
<br>
+1 [if you add an 'r' ;-) ]<br>
<br>
Thanks,<br>
Sascha<br>
<br>
On 09/01/2011 06:55 PM, Jean-Christophe Fillion-Robin wrote:
<blockquote
cite="mid:%20%3CCANLz8R5vpJz54QJEXBDOoXmeiyxEBoeg1-dJ6e=RM1ow68Hf8Q@mail.gmail.com"
type="cite">Hi Sasha, <br>
<br>
Since the Qt equivalent was named QDir::rmdir, I adopted the same
name. Changing the name wouldn't be a problem. <br>
<br>
What about "removeDirRecusively" instead ? <br>
<br>
Jc<br>
<br>
<div class="gmail_quote">
On Thu, Sep 1, 2011 at 12:43 PM, Sascha Zelzer <span dir="ltr"><<a
moz-do-not-send="true"
href="mailto:s.zelzer@dkfz-heidelberg.de">s.zelzer@dkfz-heidelberg.de</a>></span>
wrote:<br>
<blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt
0.8ex; border-left: 1px solid rgb(204, 204, 204);
padding-left: 1ex;">
<div bgcolor="#FFFFFF" text="#000000"> Hi Jc,<br>
<br>
Looks good. I guess the CTKCore dependency of the
ctkPluginFramework was just a matter of time, so I am good
with it.<br>
<br>
Just a little "style" comment: The "rmdir" function name
looks a little out of place when compared with the others.
What about "removeDir"? Just my two cents.<br>
<br>
Thanks for pushing code reuse,<br>
<font color="#888888"> <br>
Sascha</font>
<div>
<div class="h5"><br>
<br>
On 09/01/2011 06:26 PM, Jean-Christophe Fillion-Robin
wrote:
<blockquote type="cite">Hi Folks, <br>
<br>
I was looking for a function to delete recursively a
function and I found out that such code has present in
multiple location:<br>
- <a moz-do-not-send="true"
href="https://github.com/jcfr/CTK/commit/8714424163b376c4efb693448278a10e13a8690a#diff-4"
target="_blank">ctkPluginFrameworkUtil_p.h</a><br>
- <a moz-do-not-send="true"
href="https://github.com/jcfr/CTK/commit/8714424163b376c4efb693448278a10e13a8690a#diff-0"
target="_blank">ctkPluginGenerator.cpp</a><br>
<br>
Topic "ctkutils-rmdir" has been integrated to master.
It includes:<br>
- addition of "rmdir" function to ctkUtils<br>
- implementation of the corresponding test in
ctkUtilsTest4.cpp<br>
- See <a moz-do-not-send="true"
href="https://github.com/commontk/CTK/commit/fd8cfead27c56ae607e379d764d2eb790d16af3e"
target="_blank">https://github.com/commontk/CTK/commit/fd8cfead27c56ae607e379d764d2eb790d16af3e</a><br>
<br>
Topic "reuse-ctkutil-rmdir-in-toolkit" has NOT been
integrated to master, indeed it implies that
ctkPluginFramework will depend on CTKCore. Does that
sounds reasonable ? <br>
See <a moz-do-not-send="true"
href="https://github.com/jcfr/CTK/tree/reuse-ctkutil-rmdir-in-toolkit"
target="_blank">https://github.com/jcfr/CTK/tree/reuse-ctkutil-rmdir-in-toolkit</a>
<br>
and <a moz-do-not-send="true"
href="https://github.com/jcfr/CTK/commit/8714424163b376c4efb693448278a10e13a8690a"
target="_blank">https://github.com/jcfr/CTK/commit/8714424163b376c4efb693448278a10e13a8690a</a><br>
<br>
Thanks<br>
Jc<br>
<br>
<br clear="all">
<br>
-- <br>
<a moz-do-not-send="true"
href="tel:%2B1%20919%20869%208849"
value="+19198698849" target="_blank">+1 919 869 8849</a><br>
<br>
</blockquote>
<br>
</div>
</div>
</div>
<br>
_______________________________________________<br>
Ctk-developers mailing list<br>
<a moz-do-not-send="true"
href="mailto:Ctk-developers@commontk.org">Ctk-developers@commontk.org</a><br>
<a moz-do-not-send="true"
href="http://public.kitware.com/cgi-bin/mailman/listinfo/ctk-developers"
target="_blank">http://public.kitware.com/cgi-bin/mailman/listinfo/ctk-developers</a><br>
<br>
</blockquote>
</div>
<br>
<br clear="all">
<br>
-- <br>
+1 919 869 8849<br>
<br>
</blockquote>
<br>
</body>
</html>