<br>+1<br><br><div class="gmail_quote">On Tue, Aug 16, 2011 at 8:03 PM, Julien Finet <span dir="ltr"><<a href="mailto:julien.finet@kitware.com">julien.finet@kitware.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;">

I usually prefer XXXEnabled to XXXDisabled.<div>Even if it is disabled by default.</div><div><br><div><font color="#888888">Julien.</font><div><div></div><div class="h5"><br><br><div class="gmail_quote">On Tue, Aug 16, 2011 at 3:39 PM, Jean-Christophe Fillion-Robin <span dir="ltr"><<a href="mailto:jchris.fillionr@kitware.com" target="_blank">jchris.fillionr@kitware.com</a>></span> wrote:<br>



<blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;">Hi Daniel, <br><br>Just looked at it. <br><br>Please consider the following remarks:<br> - Regarding the git commit msg. See <a href="http://www.commontk.org/index.php/Contributing_to_CTK#Git_Commit_Style" target="_blank">http://www.commontk.org/index.php/Contributing_to_CTK#Git_Commit_Style</a><br>





<br> - Regarding the patch:<br>     - May be you could just add a property named ErrorTextDisabled to ctkWorkflowGroupBox ? <br>    - See line 110 of ctkWorkflowGroupBox.cpp<br><br>Danielle> What do you think ? <br><br>





Thanks<br>Jc<div><div></div><div><br><br><div class="gmail_quote">On Tue, Aug 16, 2011 at 12:35 PM, Daniel Haehn <span dir="ltr"><<a href="mailto:haehn@bwh.harvard.edu" target="_blank">haehn@bwh.harvard.edu</a>></span> wrote:<br>



<blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;">

Hi,<br>
<br>
did anybody have a chance to look at it yet?<br>
<br>
Thanks,<br>
<font color="#888888">Daniel<br>
</font><div><div></div><div><br>
On Thu, Aug 11, 2011 at 1:15 PM, Daniel Haehn <<a href="mailto:haehn@bwh.harvard.edu" target="_blank">haehn@bwh.harvard.edu</a>> wrote:<br>
> Hi Devels,<br>
><br>
> could anybody please review the following topic:<br>
><br>
> <a href="https://github.com/haehn/CTK/commits/add-ShowStatusTextUponGoToStepSuccess-workflow-feature" target="_blank">https://github.com/haehn/CTK/commits/add-ShowStatusTextUponGoToStepSuccess-workflow-feature</a><br>






><br>
> I added a property to be able to disable the Status Text update on the<br>
> origin step when a GoToStep(..)-call of a ctkWorkflow succeeds.<br>
><br>
> Looking forward to your feedback..<br>
><br>
> Daniel<br>
><br>
_______________________________________________<br>
Ctk-developers mailing list<br>
<a href="mailto:Ctk-developers@commontk.org" target="_blank">Ctk-developers@commontk.org</a><br>
<a href="http://public.kitware.com/cgi-bin/mailman/listinfo/ctk-developers" target="_blank">http://public.kitware.com/cgi-bin/mailman/listinfo/ctk-developers</a><br>
</div></div></blockquote></div><br><br clear="all"><br></div></div><font color="#888888">-- <br><a href="tel:%2B1%20919%20869%208849" value="+19198698849" target="_blank">+1 919 869 8849</a><br><br>
</font><br>_______________________________________________<br>
Ctk-developers mailing list<br>
<a href="mailto:Ctk-developers@commontk.org" target="_blank">Ctk-developers@commontk.org</a><br>
<a href="http://public.kitware.com/cgi-bin/mailman/listinfo/ctk-developers" target="_blank">http://public.kitware.com/cgi-bin/mailman/listinfo/ctk-developers</a><br>
<br></blockquote></div><br></div></div></div></div>
</blockquote></div><br><br clear="all"><br>-- <br>+1 919 869 8849<br><br>