<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN">
<html>
<head>
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
</head>
<body bgcolor="#ffffff" text="#000000">
Yes, could be handy.<br>
<br>
In each CMakeExternals/*.cmake script we could check for a CMake
variable <project_name>_REVISION_TAG and if it exists (i.e.
manually added in the CMake GUI or in a dart-client script) we use
this one instead of the default.<br>
<br>
Does that make sense?<br>
<br>
- Sascha<br>
<br>
On 08/03/2011 04:44 PM, Julien Finet wrote:
<blockquote
cite="mid:CAKoWPPFDxCO4fNv2qhYWBmQtCK-qR5sZCQsgYi57ELb=a6N+0g@mail.gmail.com"
type="cite">That sounds fine by me, however, I think we should
have some way to optionally specify a custom tag ?
<div>So that we could have dashboards (on a next branch?) running
with external bleeding edge branches.</div>
<div><br>
</div>
<div>Julien.<br>
<br>
<div class="gmail_quote">On Wed, Aug 3, 2011 at 3:41 AM, Sascha
Zelzer <span dir="ltr"><<a moz-do-not-send="true"
href="mailto:s.zelzer@dkfz-heidelberg.de">s.zelzer@dkfz-heidelberg.de</a>></span>
wrote:<br>
<blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt
0.8ex; border-left: 1px solid rgb(204, 204, 204);
padding-left: 1ex;">
Hi again,<br>
<br>
thanks to JC (who forwarded my post to the CMake mailing
list) I could identify the problem (for details, see <a
moz-do-not-send="true"
href="http://thread.gmane.org/gmane.comp.programming.tools.cmake.user/37472"
target="_blank">http://thread.gmane.org/gmane.comp.programming.tools.cmake.user/37472</a>
).<br>
<br>
Essentially, supplying a GIT_TAG argument together with a
UPDATE_COMMAND (could also be the default update command,
which may be non-empty) in the ExternalProject_Add() macro
call will skip all steps after the update step in Visual
Studio 2010.<br>
<br>
This problem actually reveals some "issues" with our scripts
in the CMakeExternals directory. I would like to suggest the
following:<br>
<br>
1.) Projects which are hosted on github/commontk<br>
<br>
I would prefer to keep GIT_TAG origin/patched or similar,
but until the bug is fixed, we could specify a specific SHA1
value and add UPDATE_COMMAND ""<br>
<br>
This affects: CTKData, Log4Qt, PythonQt, QtSOAP, ZMQ
(although hosted at <a moz-do-not-send="true"
href="http://github.com/patrickcheng/zmq2" target="_blank">github.com/patrickcheng/zmq2</a>)<br>
<br>
2.) True external projects<br>
<br>
Here I would actually prefer GIT_TAG origin/tag where "tag"
points to a release version. The relevant projects are:<br>
<br>
- DCMTK: we already use a fixed tag, just needs
UPDATE_COMMAND ""<br>
- ITK: Use GIT_TAG v3.20.0<br>
- VTK: If I rember correctly, the CTK VTK widgets need a
very recent VTK, so use a fixed SHA1 instead of
origin/master<br>
<br>
<br>
I made these changes locally and successfully compiled CTK
(I enabled everything without Python support) with VS2010
SP1.<br>
<br>
What do you think?<br>
<br>
<br>
Thanks,<br>
<font color="#888888">
Sascha</font>
<div>
<div class="h5"><br>
<br>
<br>
On 07/22/2011 06:07 PM, Sascha Zelzer wrote:<br>
<blockquote class="gmail_quote" style="margin: 0pt 0pt
0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204);
padding-left: 1ex;">
Hi,<br>
<br>
there is something very strange going on. The
generated VS 2010 projects<br>
(I am using the Express editions, 32bit) for the
external dependencies<br>
like DCMTK, Log4Qt, etc. only call the download step
of the<br>
ExternalProject_add call in our superbuild scripts.
The projects are not<br>
configured and build.<br>
<br>
Did anybody experience the same? I tried with and
without the VS 2010<br>
SP1 and with CMake 2.8.4 and 2.8.5.<br>
<br>
Thanks,<br>
Sascha<br>
<br>
On 07/22/2011 01:39 PM, Sascha Zelzer wrote:<br>
<blockquote class="gmail_quote" style="margin: 0pt 0pt
0pt 0.8ex; border-left: 1px solid rgb(204, 204,
204); padding-left: 1ex;">
Hi Folks,<br>
<br>
I would like to get Visual Studio 2010 compatibility
for CTK.<br>
<br>
Currently, it looks like I will have to copy
ExternalProject.cmake to<br>
CTK for the CMAKE_CACHE_ARGS argument. Then a couple
of small<br>
modifications should do.<br>
<br>
Any other ideas or objections?<br>
<br>
Thanks,<br>
<br>
Sascha<br>
_______________________________________________<br>
Ctk-developers mailing list<br>
<a moz-do-not-send="true"
href="mailto:Ctk-developers@commontk.org"
target="_blank">Ctk-developers@commontk.org</a><br>
<a moz-do-not-send="true"
href="http://public.kitware.com/cgi-bin/mailman/listinfo/ctk-developers"
target="_blank">http://public.kitware.com/cgi-bin/mailman/listinfo/ctk-developers</a><br>
</blockquote>
_______________________________________________<br>
Ctk-developers mailing list<br>
<a moz-do-not-send="true"
href="mailto:Ctk-developers@commontk.org"
target="_blank">Ctk-developers@commontk.org</a><br>
<a moz-do-not-send="true"
href="http://public.kitware.com/cgi-bin/mailman/listinfo/ctk-developers"
target="_blank">http://public.kitware.com/cgi-bin/mailman/listinfo/ctk-developers</a><br>
</blockquote>
<br>
_______________________________________________<br>
Ctk-developers mailing list<br>
<a moz-do-not-send="true"
href="mailto:Ctk-developers@commontk.org"
target="_blank">Ctk-developers@commontk.org</a><br>
<a moz-do-not-send="true"
href="http://public.kitware.com/cgi-bin/mailman/listinfo/ctk-developers"
target="_blank">http://public.kitware.com/cgi-bin/mailman/listinfo/ctk-developers</a><br>
</div>
</div>
</blockquote>
</div>
<br>
</div>
</blockquote>
<br>
</body>
</html>