Regarding MT and /MTd, would it make sens to have a CMake option named DCMTK_MULTITHREADED ?<br><br>See also inline comments.<br><br><div class="gmail_quote">On Mon, Aug 1, 2011 at 11:45 AM, OFFIS DICOM Team <span dir="ltr"><<a href="mailto:dicom@offis.de" target="_blank">dicom@offis.de</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;">Hi JC,<br>
<br>
Am 01.08.2011 16:35, schrieb Jean-Christophe Fillion-Robin:<div><br>
<br>
<blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;">
Nevertheless, it seems CTK build is now broken :(<br>
</blockquote>
<br></div>
Yes, and totally my fault ;)</blockquote><div><br>No prob :) Seems we identify and are on the good track to get the problem fixed.<br> </div><blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;">
<div><br>
<br>
<blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;">
Few remarks:<br>
<br>
1) In CMakeExternals/DCMTK.cmake - Instead of specifying<br>
"origin/master", would it be possible to use a specific SHA1 as a<br>
GIT_TAG. Doing so will be more deterministic and ensure all developers /<br>
checkout will behave the same way. Before, origin/patched associated with<br>
our own DCMTK was a "controller" moving target."<br>
</blockquote>
<br></div>
I think this is a good idea. Let's adapt the remaining issues to be fine on<br>
the current DCMTK HEAD commit and take that one. I really do not recommend<br>
taking 3.6.0 since I added C-MOVE code (needed for receiving images) to the<br>
DcmSCU class afterwards.</blockquote><div><br>Make sens - It just a matter of specifying the SHA1 to be the latest head known to compile. <br> </div><blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;">
<div><br>
<br>
<blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;">
2) DCMTK build is broken - How should we address the problem:<br>
</blockquote>
<br></div>
DCMTK itself is broken? There is a warning about mktemp, I guess that is<br>
easy to fix and I will do it hopefully already today. Are there any other<br>
issues, just let me know and I'll fix it in DCMTK.</blockquote><div><br>DCMTK build by CTK is/was broken. The flag fPIC was not added automatically ... <br> </div><blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;">
<div><br>
<br>
<blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;">
* Get write access to official dcmtk ? * Ask dcmtk folks to mirror DCMTK<br>
on github so that we can fork and easily contribute patches ? * Mirror<br>
DCMTK ourself on commontk/dcmtk<br>
</blockquote>
<br></div>
I would not be happy about any of these. Let's get things running on all<br>
platforms now; I will do my part as good as possible and with priority. Then<br>
we can take a fixed commit and update that from time to time in CTK. We can<br>
do that regulary, as you like, or as I can give you a hint if interesting<br>
features (for CTK) come in.</blockquote><div><br>I guess submitting patch to Offis directly seems to be the way to go. We could also publish our topic branch on commontk/DCMTK to that you can review them before final integration upstream.<br>
</div><blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;"><div><br>
<blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;">
<br>
Assigned issue <a href="https://github.com/commontk/CTK/issues/22" target="_blank">https://github.com/commontk/<u></u>CTK/issues/22</a> to Michael<br>
<br>
In the mean time, I will update CMakeExternal/DCMTK.cmake so that fPIC<br>
is passed.<br>
</blockquote>
<br></div>
Shouldn't we not just change DCMTK's CMakeLists.txt? We need these flags<br>
anyway sooner or later, so we should also take it over. I would just take<br>
over the solution from the link (issues/22) into DCMTK's CMakeLists.txt.</blockquote><div><br>Very true - i didn't know how responsive you would be. Do you know when things will be fixed? <br> </div><blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;">
<div><br>
<blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;">
<br>
3) Should we move to a master/next workflow ?<br>
<br>
Having a continuous dashboard setup for both master and next, we will be<br>
able to easily identify issue and ensure that our change compile properly<br>
on all targets platform.<br>
</blockquote>
<br></div>
Given my beginner's status in git and somehow also CTK, I would totally<br>
welcome that! So plus 1 from my side ...</blockquote><div><br>Extra - Any other thoughts from the CTK community ? <br> </div><blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;">
<div><div></div><div><br>
<br>
Best regards,<br>
Michael<br>
<br>
-- <br>
OFFIS DICOM Team, Escherweg 2, 26121 Oldenburg, Germany<br>
E-Mail: <a href="mailto:dicom@offis.de" target="_blank">dicom@offis.de</a>, URL: <a href="http://dicom.offis.de" target="_blank">http://dicom.offis.de</a><br>
</div></div></blockquote></div><br><br clear="all"><br>-- <br><a href="tel:%2B1%20919%20869%208849" value="+19198698849" target="_blank">+1 919 869 8849</a><br><br>