Hi Folks, <br><br>Moving to the official DCMTK is great, it will minimize maintenance and avoid a dependency on a custom version of DCMTK.<br><br>Nevertheless, it seems CTK build is now broken :( <br><br>Few remarks:<br><br>
1) In CMakeExternals/DCMTK.cmake - Instead of specifying "origin/master", would it be possible to use a
specific SHA1 as a GIT_TAG. Doing so will be more deterministic and
ensure all developers / checkout will behave the same way. Before,
origin/patched associated with our own DCMTK was a "controller" moving
target."<br><br> Created issue <a href="https://github.com/commontk/CTK/issues/21">https://github.com/commontk/CTK/issues/21</a> and assigned to Michael<br><br>2) DCMTK build is broken - How should we address the problem:<br>
* Get write access to official dcmtk ? <br> * Ask dcmtk folks to mirror DCMTK on github so that we can fork and easily contribute patches ? <br> * Mirror DCMTK ourself on commontk/dcmtk<br><br>Assigned issue <a href="https://github.com/commontk/CTK/issues/22">https://github.com/commontk/CTK/issues/22</a> to Michael<br>
<br>In the mean time, I will update CMakeExternal/DCMTK.cmake so that fPIC is passed.<br><br>3) Should we move to a master/next workflow ? <br><br> Having a continuous dashboard setup for both master and next, we will be able to easily identify issue and ensure that our change compile properly on all targets platform.<br>
<br>Thanks<br>Jc<br> <br><br><div class="gmail_quote">On Sun, Jul 31, 2011 at 10:13 PM, Julien Finet <span dir="ltr"><<a href="mailto:julien.finet@kitware.com">julien.finet@kitware.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;">
Here are the errors on windows: <div><a href="http://my.cdash.org/viewBuildError.php?onlydeltap&buildid=214815" target="_blank">http://my.cdash.org/viewBuildError.php?onlydeltap&buildid=214815</a><br><br></div><div>
Regards,</div><div>
Julien.</div><div><div></div><div class="h5"><div><br><div class="gmail_quote">On Sun, Jul 31, 2011 at 5:52 PM, Julien Finet <span dir="ltr"><<a href="mailto:julien.finet@kitware.com" target="_blank">julien.finet@kitware.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;">
<div>Hi Michael,</div>
<div> </div>
<div>Nice job !!!</div>
<div> </div>
<div>It seems that nightly builds are now failing.</div>
<div>-fPIC is missing: <a href="http://my.cdash.org/viewBuildError.php?buildid=214617" target="_blank">http://my.cdash.org/viewBuildError.php?buildid=214617</a></div>
<div>- Warning with the compilation of dcmtk: <a href="http://my.cdash.org/viewBuildError.php?type=1&buildid=214303" target="_blank">http://my.cdash.org/viewBuildError.php?type=1&buildid=214303</a></div>
<div> </div>
<div>Can you give a look ?<b></b></div>
<p>Thanks,<br><font color="#888888">Julien.<br><br></font></p><div><div></div><div>
<div class="gmail_quote">On Fri, Jul 29, 2011 at 4:54 AM, OFFIS DICOM Team <span dir="ltr"><<a href="mailto:dicom@offis.de" target="_blank">dicom@offis.de</a>></span> wrote:<br>
<blockquote style="border-left: 1px solid rgb(204, 204, 204); margin: 0px 0px 0px 0.8ex; padding-left: 1ex;" class="gmail_quote">Dear all,<br><br>the last two days I merged my changes regarding the adaptation of CTK to the<br>
latest DCMTK back in to the CTK master branch. I commited this stuff a few<br>
minutes ago.<br><br>I also included some fixes where I stumbled over things that seemed wrong to<br>me. Further, I added minor features at some positions, e.g. color support<br>for the DICOM thumbnail/image rendering. Overall, I only worked on the DICOM<br>
parts, 99% on /Libs/DICOM, mostly the Core part.<br><br>I also changed the repository location in the superbuild to fetch DCMTK from<br>the official OFFIS repository at <a href="http://git.dcmtk.org/dcmtk.git" target="_blank">http://git.dcmtk.org/dcmtk.git</a> . That works<br>
for me here.<br><br>Nevertheless, since these are my first actual commits to CTK, I expect that<br>I have done some mistakes, hopefully not too many serious ones ;) Please<br>tell me and I will correct that as soon as possible.<br>
<br>Best regards,<br>Michael<br><font color="#888888"><br>-- <br>OFFIS DICOM Team, Escherweg 2, 26121 Oldenburg, Germany<br>E-Mail: <a href="mailto:dicom@offis.de" target="_blank">dicom@offis.de</a>, URL: <a href="http://dicom.offis.de/" target="_blank">http://dicom.offis.de</a><br>
______________________________<u></u>_________________<br>Ctk-developers mailing list<br><a href="mailto:Ctk-developers@commontk.org" target="_blank">Ctk-developers@commontk.org</a><br><a href="http://public.kitware.com/cgi-bin/mailman/listinfo/ctk-developers" target="_blank">http://public.kitware.com/cgi-<u></u>bin/mailman/listinfo/ctk-<u></u>developers</a><br>
</font></blockquote></div><br>
</div></div></blockquote></div><br></div>
</div></div><br>_______________________________________________<br>
Ctk-developers mailing list<br>
<a href="mailto:Ctk-developers@commontk.org">Ctk-developers@commontk.org</a><br>
<a href="http://public.kitware.com/cgi-bin/mailman/listinfo/ctk-developers" target="_blank">http://public.kitware.com/cgi-bin/mailman/listinfo/ctk-developers</a><br>
<br></blockquote></div><br><br clear="all"><br>-- <br>+1 919 869 8849<br><br>