FYI - In the mean time, i pushed the following commit that take care of explicitly specifying fPIC. <br><br>See <a href="https://github.com/commontk/CTK/commit/4b95a9bef509e62a2d86621539829165500baa48">https://github.com/commontk/CTK/commit/4b95a9bef509e62a2d86621539829165500baa48</a><br>
<br>Thanks<br>Jc<br><br><div class="gmail_quote">On Mon, Aug 1, 2011 at 2:41 PM, Jean-Christophe Fillion-Robin <span dir="ltr"><<a href="mailto:jchris.fillionr@kitware.com">jchris.fillionr@kitware.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;"><br><br><div class="gmail_quote"><div class="im">On Mon, Aug 1, 2011 at 1:00 PM, OFFIS DICOM Team <span dir="ltr"><<a href="mailto:dicom@offis.de" target="_blank">dicom@offis.de</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;">
Hi,<br>
<br>
Am 01.08.2011 18:25, schrieb Jean-Christophe Fillion-Robin:<div><br>
<blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;">
Regarding MT and /MTd, would it make sens to have a CMake option named<br>
DCMTK_MULTITHREADED ?<br>
</blockquote>
<br></div>
If CMake automatically uses the flags it should and hands it over to all<br>
external projects, this would be not needed. However, I'm not sure whether<br>
this is actually the case.<br></blockquote></div><div><br>CMake could pass down any additional flags by configuring the project with CMAKE_CXX_FLAGS and CMAKE_C_FLAGS.<br><br> </div><div class="im"><blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;">
<br>
We already have a WITH_THREADS flag in DCMTK which adds libpthread if<br>
existing/necessary. Usually, with threads is turned on.</blockquote></div><div><br>Does it mean that turning WITH_THREAD OFF won't append the /MT or /MTd flags ?<br> </div><div class="im"><blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;">
<div><br>
<br>
<blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;">
Yes, and totally my fault ;)<br>
<br>
<br>
No prob :) Seems we identify and are on the good track to get the problem<br>
fixed.<br>
</blockquote>
<br></div>
Yes, I hope so :)<div><br>
<br>
<blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;">
<br>
DCMTK build by CTK is/was broken. The flag fPIC was not added<br>
automatically ...<br>
</blockquote>
<br></div>
Yes, ok; as I understood this is needed when linking against the shared<br>
DCMTK libraries from outside. </blockquote></div><div>This happen when linking a shared 64bits library against a static library. The fPIC flag is required.<br></div><div class="im"><blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;">
<div><br>
<br>
<blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;">
* Get write access to official dcmtk ? * Ask dcmtk folks to mirror DCMTK<br>
on github so that we can fork and easily contribute patches ? * Mirror<br>
DCMTK ourself on commontk/dcmtk<br>
<br>
<br>
I would not be happy about any of these. Let's get things running on all<br>
platforms now; I will do my part as good as possible and with priority.<br>
Then we can take a fixed commit and update that from time to time in CTK.<br>
We can do that regulary, as you like, or as I can give you a hint if<br>
interesting features (for CTK) come in.<br>
<br>
<br>
I guess submitting patch to Offis directly seems to be the way to go. We<br>
could also publish our topic branch on commontk/DCMTK to that you can<br>
review them before final integration upstream.<br>
</blockquote>
<br></div>
Fine for me. My point is just that we should not let drift apart CTK too<br>
much from the latest DCMTK version. Otherwise (like now..;)) it is double<br>
work to align things again :)</blockquote></div><div>Excellent - And thanks for helping us catching up with the current DCMTK.<br><br></div><div class="im"><blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;">
<div><br>
<br>
<blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;">
Assigned issue <a href="https://github.com/commontk/__CTK/issues/22" target="_blank">https://github.com/commontk/__<u></u>CTK/issues/22</a><br>
<<a href="https://github.com/commontk/CTK/issues/22" target="_blank">https://github.com/commontk/<u></u>CTK/issues/22</a>> to Michael<br>
<br>
In the mean time, I will update CMakeExternal/DCMTK.cmake so that fPIC is<br>
passed.<br>
<br>
<br>
Shouldn't we not just change DCMTK's CMakeLists.txt? We need these flags<br>
anyway sooner or later, so we should also take it over. I would just take<br>
over the solution from the link (issues/22) into DCMTK's CMakeLists.txt.<br>
<br>
<br>
Very true - i didn't know how responsive you would be. Do you know when<br>
things will be fixed?<br>
</blockquote>
<br></div>
I could commit it any time/immediately in DCMTK. My colleague noted that we<br>
should take care that we only put -fPIC into effect if it is understood by<br>
the compiler and needed, so I wonder whether "IF(UNIX" is a sufficient<br>
guard. Any hints or recommendations?</blockquote></div><div><br>You could for example do:<br><br><pre><div style="background-color: transparent;"><span>#-----------------------------------------------------------------------------</span></div>
<div style="background-color: transparent;"><span># To fix compilation problem: relocation R_X86_64_32 against `a local symbol' can not be</span></div><div style="background-color: transparent;">
<span># used when making a shared object; recompile with -fPIC</span></div><div style="background-color: transparent;"><span># See <a href="http://www.cmake.org/pipermail/cmake/2007-May/014350.html" target="_blank">http://www.cmake.org/pipermail/cmake/2007-May/014350.html</a></span></div>
<div style="background-color: transparent;"><span>#</span></div><div style="background-color: transparent;"><span>IF</span><span>(</span> <span>CMAKE_SYSTEM_PROCESSOR</span> <span>STREQUAL</span> <span>"x86_64"</span> <span>)</span></div>
<div style="background-color: transparent;"> <span>SET_TARGET_PROPERTIES</span><span>(</span><span>log4qt</span> <span>PROPERTIES</span> <span>COMPILE_FLAGS</span> <span>"-fPIC"</span><span>)</span></div>
<div style="background-color: transparent;"><span>ENDIF</span><span>(</span> <span>CMAKE_SYSTEM_PROCESSOR</span> <span>STREQUAL</span> <span>"x86_64"</span> <span>)<br>
<br></span></div></pre><br><br></div><div class="im"><blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;"><div><div></div><div><br>
<br>
Best regards,<br>
Michael<br>
<br>
-- <br>
OFFIS DICOM Team, Escherweg 2, 26121 Oldenburg, Germany<br>
E-Mail: <a href="mailto:dicom@offis.de" target="_blank">dicom@offis.de</a>, URL: <a href="http://dicom.offis.de" target="_blank">http://dicom.offis.de</a><br>
</div></div></blockquote></div></div><font color="#888888"><br><br clear="all"><br>-- <br><a href="tel:%2B1%20919%20869%208849" value="+19198698849" target="_blank">+1 919 869 8849</a><br><br>
</font></blockquote></div><br><br clear="all"><br>-- <br>+1 919 869 8849<br><br>