Hi Folks, <br><br>I added a license on all *.h and *.cpp files. <br><br>See <a href="https://github.com/jcfr/CTK/compare/master...fix-license-header" target="_blank">https://github.com/jcfr/CTK/compare/master...fix-license-header</a><br>
<br>
//-----------------------------------<br>Note: I added the appropriate license using the following script to determine the first author.<br><br> <font style="font-family: courier new,monospace;" size="2">for i in `cat headers.txt`; \<br>
do a=`git log --follow --format="%an" $i | tail -n 1`;\<br> echo "$a --- $i"; \<br>done</font><br><br>//-----------------------------------<br>Few questions:<br><br>* What is the best practice regarding python script ? How should we integrate the license ? docstring, ... ?<br>
<br>* The files authored by Steve Pieper mention "Kitware, Inc." in the copyright. <br><br>Steve> I believe the license in these files is a byproduct of copy/paste. Do you want to keep it like that of should we change it ? Would you prefer "Isomics, Inc." instead ? <br>
<br>To get the list of files authored by Steve Pieper, the following could be done:<br><br style="font-family: courier new,monospace;"><span style="font-family: courier new,monospace;">for i in `find . -type f -path '.git' -prune -o -print`; \</span><br style="font-family: courier new,monospace;">
<span style="font-family: courier new,monospace;"> do a=`git log --follow --format="%an" $i | tail -n 1`; echo "$a --- $i"; \</span><br style="font-family: courier new,monospace;"><span style="font-family: courier new,monospace;">done | ack Pieper</span><br>
<br>Thanks<br>Jc<br><br><div class="gmail_quote">On Sat, Jul 9, 2011 at 2:39 PM, Dominique Belhachemi <span dir="ltr"><<a href="mailto:domibel@debian.org" target="_blank">domibel@debian.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;">
Hi Jc,<br>
<br>
The license/copyright information for the files below is missing. Do<br>
you want to add those information?<br>
<br>
Thanks<br>
Dominique<br>
<br>
<br>
./Plugins/org.commontk.dah.core/Testing/Cpp/ctkDicomObjectLocatorCacheTest1.cpp<br>
./Plugins/org.commontk.dah.core/Testing/Cpp/ctkDicomAppHostingTypesTest1.cpp<br>
./Plugins/org.commontk.qtmobility.service/ctkQtMobilityServiceActivator_p.h<br>
./Plugins/org.commontk.qtmobility.service/ctkQtMobilityServiceActivator.cpp<br>
./Plugins/org.commontk.eventbus/ctkEventBusImpl_p.h<br>
./Plugins/org.commontk.eventbus/ctkEventBusImpl.cpp<br>
./Plugins/org.commontk.eventbus/ctkEventBusPlugin_p.h<br>
./Plugins/org.commontk.eventbus/ctkEventHandlerWrapper_p.h<br>
./Plugins/org.commontk.eventbus/ctkEventBusPlugin.cpp<br></blockquote><div>=> Done<br> </div><blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;">
./Libs/Visualization/VTK/Core/vtkLightBoxRendererManager.h<br></blockquote><blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;">
./Libs/Visualization/VTK/Core/Testing/Cpp/ctkVTKObjectEventsObserverTest1.cpp<br>
./Libs/Visualization/VTK/Core/Testing/Cpp/vtkLightBoxRendererManagerTest1.cpp<br>
./Libs/Visualization/VTK/Core/Testing/Cpp/ctkVTKObjectTestHelper.cpp<br>
./Libs/Visualization/VTK/Core/Testing/Cpp/ctkVTKConnectionTest1.cpp<br>
./Libs/Visualization/VTK/Core/Testing/Cpp/ctkVTKObjectTestHelper.h<br>
./Libs/Visualization/VTK/Core/Testing/Cpp/ctkVTKObjectTest1.cpp<br>
./Libs/Visualization/VTK/Core/vtkLightBoxRendererManager.cpp<br></blockquote><div>=> Done<br><br> </div><blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;">
./Libs/Scripting/Python/Core/Python/qt/__init__.py<br></blockquote><div>=> No license added ... not sure it if make sens to add one ... <br> </div><blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;">
./Libs/Core/CMake/TestBFD/TestBFD.cpp<br></blockquote><blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;">
./Libs/Core/ctkCommandLineParser.cpp </blockquote><blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;">
./Libs/Core/Testing/Cpp/ctkBinaryFileDescriptorTestHelper.cpp<br>
./Libs/Core/Testing/Cpp/ctkCommandLineParserTest1.cpp<br>
./Libs/Core/ctkPimpl.h<br>
./Libs/Core/ctkCommandLineParser.h<br></blockquote><div>=> Done<br> </div><blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;">
./Libs/DICOM/Widgets/ctkDICOMQueryWidget.cpp<br>
./Libs/DICOM/Widgets/Testing/Cpp/ctkDICOMImageTest1.cpp<br>
./Libs/DICOM/Core/ctkDICOMPersonName.h<br>
./Libs/DICOM/Core/ctkDICOMDataset.cpp<br>
./Libs/DICOM/Core/Testing/Cpp/ctkDICOMTest1.cpp<br>
./Libs/DICOM/Core/Testing/Cpp/ctkDICOMTesterTest2.cpp<br>
./Libs/DICOM/Core/Testing/Cpp/ctkDICOMTesterTest1.cpp<br>
./Libs/DICOM/Core/ctkDICOMPersonName.cpp </blockquote><div>=> Done</div><div> </div><blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;">
./Applications/Testing/Cpp/ctkDICOMApplicationTest1.cpp<br></blockquote><blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;">
./Applications/ctkSimplePythonShell/ctkSimplePythonShellMain.cpp<br>
./Applications/ctkSimplePythonShell/ctkSimplePythonQtDecorators.h<br>
./Applications/ctkSimplePythonShell/ctkTestWrappedQInvokable.h<br>
./Applications/ctkSimplePythonShell/ctkSimplePythonManager.h<br>
./Applications/ctkSimplePythonShell/ctkTestWrappedQListOfVTKObject.h<br></blockquote><div>=> Done<br> <br></div><blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;">
./Applications/ctkSimplePythonShell/Testing/Python/derivedQWidgetTest.py<br>
./Applications/ctkSimplePythonShell/Testing/Python/wrappedVTKSlotTest.py<br>
./Applications/ctkSimplePythonShell/Testing/Python/wrappedQPropertyTest.py<br>
./Applications/ctkSimplePythonShell/Testing/Python/vtkPythonSmoke.py<br>
./Applications/ctkSimplePythonShell/Testing/Python/wrappedQInvokableTest.py<br>
./Applications/ctkSimplePythonShell/Testing/Python/wrappedSlotTest.py<br>
./Applications/ctkSimplePythonShell/Testing/Python/ctkWidgetsTest.py<br>
./Applications/ctkSimplePythonShell/Testing/Python/wrappedVTKQInvokableTest.py<br></blockquote><div>=> No license added ... not sure it if make sens to add one ... <br> </div><blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;">
./Applications/ctkSimplePythonShell/ctkTestWrappedSlot.h<br>
./Applications/ctkSimplePythonShell/ctkTestWrappedVTKSlot.h<br>
./Applications/ctkSimplePythonShell/ctkTestWrappedQProperty.h<br>
./Applications/ctkSimplePythonShell/Python/ctkSimplePythonShell.py<br>
./Applications/ctkSimplePythonShell/ctkTestWrappedVTKQInvokable.h<br></blockquote><div>=> Done <br></div><blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;">
<div><br>
<br>
On Sat, Jul 9, 2011 at 11:52 AM, Jean-Christophe Fillion-Robin<br>
</div><div><div></div><div><<a href="mailto:jchris.fillionr@kitware.com" target="_blank">jchris.fillionr@kitware.com</a>> wrote:<br>
> Hi Dominique,<br>
><br>
> Please review the following topic:<br>
> <a href="https://github.com/jcfr/CTK/compare/master...fix-license-header" target="_blank">https://github.com/jcfr/CTK/compare/master...fix-license-header</a><br>
><br>
> 788f261 Use URL to refer to ParaView license version 1.2<br>
> d4b55ab Fix indent in "Module" attribute associated with Paraview license<br>
> header<br>
> 681c958 ctkBinaryFileDescriptor - Remove BWH Copyright year and fix indent<br>
> 20cc5c8 Update license header associated with ctkVTKThumbnailViewTest1<br>
> 56041fa Update license header associated with PythonQtDecorators<br>
><br>
> Thanks<br>
> Jc<br>
><br>
><br>
><br>
> On Sat, Jul 9, 2011 at 11:35 AM, Stephen Aylward<br>
> <<a href="mailto:stephen.aylward@kitware.com" target="_blank">stephen.aylward@kitware.com</a>> wrote:<br>
>><br>
>> Hi Dominique,<br>
>><br>
>> Thanks for asking and checking the files.<br>
>><br>
>> All of CTK is suppose to be under the Apache 2.0 license. If you<br>
>> find files with any other licence, please let us know. We will fix<br>
>> them immediately.<br>
>><br>
>> Regarding the holder of the copyright - I believe we decided that<br>
>> there would be no single copyright holder for CTK. The files are held<br>
>> by the individual contributors and/or their institutions. This is<br>
>> not how I would prefer things, because it creates an impression of<br>
>> complex ownership (whereas the Apache license assures the code will<br>
>> always be free for commercial and non-commercial use, and without<br>
>> patent restrictions to the best of our knowledge).<br>
>><br>
>> The CTK members should probably re-address copyright assignments. I<br>
>> suggest we have the assignment go to the Insight Software Consortium<br>
>> (ISC) or some other independent entity. Hans Johnson at U of Iowa is<br>
>> the current president of the ISC, and he could ask the ISC board to<br>
>> accept CTK as an ISC-sponsored toolkit. More info on the ISC is at:<br>
>> <a href="http://insightsoftwareconsortium.org/" target="_blank">http://insightsoftwareconsortium.org/</a><br>
>><br>
>> Stephen<br>
>><br>
>><br>
>><br>
>> On Sat, Jul 9, 2011 at 11:14 AM, Dominique Belhachemi<br>
>> <<a href="mailto:domibel@debian.org" target="_blank">domibel@debian.org</a>> wrote:<br>
>> > Hi,<br>
>> ><br>
>> > I try to figure out whether or not the CTK source code can be<br>
>> > distributed. Now I am having a couple of questions.<br>
>> ><br>
>> > - Some files in the CTK repository are covered by the ParaView license<br>
>> > version 1.2. Is it possible to add the referenced file<br>
>> > 'License_v1.2.txt' to the repository?<br>
>> ><br>
>> > - The Slicer license is missing as well. I found some statements which<br>
>> > points to dead links:<br>
>> > "See Doc/copyright/copyright.txt<br>
>> > or <a href="http://www.slicer.org/copyright/copyright.txt" target="_blank">http://www.slicer.org/copyright/copyright.txt</a> for details."<br>
>> ><br>
>> > - Who is the main copyright holder of CTK?<br>
>> ><br>
>> > Thanks<br>
>> > Dominique<br>
>> > _______________________________________________<br>
>> > Ctk-developers mailing list<br>
>> > <a href="mailto:Ctk-developers@commontk.org" target="_blank">Ctk-developers@commontk.org</a><br>
>> > <a href="http://public.kitware.com/cgi-bin/mailman/listinfo/ctk-developers" target="_blank">http://public.kitware.com/cgi-bin/mailman/listinfo/ctk-developers</a><br>
>> ><br>
>><br>
>><br>
>><br>
>> --<br>
>><br>
>> ==============================<br>
>> Stephen R. Aylward, Ph.D.<br>
>> Director of Medical Imaging Research<br>
>> Kitware, Inc. - North Carolina Office<br>
>> <a href="http://www.kitware.com" target="_blank">http://www.kitware.com</a><br>
>> stephen.aylward (Skype)<br>
>> <a href="tel:%28919%29%20969-6990%20x300" value="+19199696990" target="_blank">(919) 969-6990 x300</a><br>
>> _______________________________________________<br>
>> Ctk-developers mailing list<br>
>> <a href="mailto:Ctk-developers@commontk.org" target="_blank">Ctk-developers@commontk.org</a><br>
>> <a href="http://public.kitware.com/cgi-bin/mailman/listinfo/ctk-developers" target="_blank">http://public.kitware.com/cgi-bin/mailman/listinfo/ctk-developers</a><br>
><br>
><br>
><br>
> --<br>
> <a href="tel:%2B1%20919%20869%208849" value="+19198698849" target="_blank">+1 919 869 8849</a><br>
><br>
><br>
_______________________________________________<br>
Ctk-developers mailing list<br>
<a href="mailto:Ctk-developers@commontk.org" target="_blank">Ctk-developers@commontk.org</a><br>
<a href="http://public.kitware.com/cgi-bin/mailman/listinfo/ctk-developers" target="_blank">http://public.kitware.com/cgi-bin/mailman/listinfo/ctk-developers</a><br>
</div></div></blockquote></div><br><br clear="all"><br>-- <br><a href="tel:%2B1%20919%20869%208849" value="+19198698849" target="_blank">+1 919 869 8849</a><br><br>