Note also that "#include" should also be sorted / organized by category.<br><br>For example:<br><font style="font-family: courier new,monospace;" size="1"><br>// Qt includes<br>#include <QDebug><br>#include <QPushButton><br>
<br>// CTKAwesomeLib includes<br>...<br><br>// VTK includes<br>...</font><br><br>Jc<br><br><div class="gmail_quote">On Mon, Jun 27, 2011 at 11:13 AM, Julien Finet <span dir="ltr"><<a href="mailto:julien.finet@kitware.com" target="_blank">julien.finet@kitware.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;">I can't remember what I did in February, that's scary.... :-( <div><br><div>So my question becomes then a reminder to our CTK developers:</div>
<div>Please sort file names in CMakeLists ! :-P<br><div><br><div>I'll go ahead and fix the DICOM CMakeLists, it's not consistently sorted there.</div>
<div><br></div><div>Thanks,</div><div>Julien. <div><div></div><div><br><br><div class="gmail_quote">On Mon, Jun 27, 2011 at 10:57 AM, Steve Pieper <span dir="ltr"><<a href="mailto:pieper@ibility.net" target="_blank">pieper@ibility.net</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;">Sounds very good to me -- in fact, it looks like you added this to the coding style back in February, Julien :D<br>
<br>
<a href="http://www.commontk.org/index.php?title=Contributing_to_CTK&diff=669&oldid=668" target="_blank">http://www.commontk.org/index.php?title=Contributing_to_CTK&diff=669&oldid=668</a><div><div></div><div>
<br>
<br><div class="gmail_quote">On Sun, Jun 26, 2011 at 4:14 PM, Jean-Christophe Fillion-Robin <span dir="ltr"><<a href="mailto:jchris.fillionr@kitware.com" target="_blank">jchris.fillionr@kitware.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;">
+1<br><br><div class="gmail_quote"><div><div></div><div>On Sun, Jun 26, 2011 at 2:40 PM, Julien Finet <span dir="ltr"><<a href="mailto:julien.finet@kitware.com" target="_blank">julien.finet@kitware.com</a>></span> wrote:<br>
</div></div><blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;"><div><div></div><div>
Hi CTK developers,<div><br></div><div>I'm not sure we ever discussed it before (I think I remember Marco talking about it sometime) but I'd like to make sure we all agree that "files inclusions must be alphabetically ordered in CMakeLists.txt" (except if there is an obvious different category ordering).</div>
<div>This is helpful for 2 reasons:</div><div> - It is less prone to generate conflicts when rebasing. If two commits add a file, they are less unlikely to conflict if they are alphabetically ordered than if they both are added at the bottom of the list.</div>
<div> - (Faster to lookup a file in the cmakelists)</div><div><br></div><div>Of course, the discussion is open, so please share your thoughts !</div><div><br></div><div>Regards,</div><div>Julien.</div>
<br></div></div>_______________________________________________<br>
Ctk-developers mailing list<br>
<a href="mailto:Ctk-developers@commontk.org" target="_blank">Ctk-developers@commontk.org</a><br>
<a href="http://public.kitware.com/cgi-bin/mailman/listinfo/ctk-developers" target="_blank">http://public.kitware.com/cgi-bin/mailman/listinfo/ctk-developers</a><br>
<br></blockquote></div><font color="#888888"><br><br clear="all"><br>-- <br><a href="tel:%2B1%20919%20869%208849" value="+19198698849" target="_blank">+1 919 869 8849</a><br><br>
</font><br>_______________________________________________<br>
Ctk-developers mailing list<br>
<a href="mailto:Ctk-developers@commontk.org" target="_blank">Ctk-developers@commontk.org</a><br>
<a href="http://public.kitware.com/cgi-bin/mailman/listinfo/ctk-developers" target="_blank">http://public.kitware.com/cgi-bin/mailman/listinfo/ctk-developers</a><br>
<br></blockquote></div><br>
</div></div></blockquote></div><br></div></div></div></div></div></div>
</blockquote></div><br><br clear="all"><br>-- <br><a href="tel:%2B1%20919%20869%208849" value="+19198698849" target="_blank">+1 919 869 8849</a><br><br>