<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN">
<html>
<head>
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
</head>
<body text="#000000" bgcolor="#ffffff">
Hi Jc,<br>
<br>
we use a similar structure for external projects in MITK, so +1 from
me. I would only suggest a slight modification:<br>
<br>
Can we use<br>
<br>
<font style="font-family: courier new,monospace;" size="1"><CTK-SUPERBUILD>/VTK-src<br>
<CTK-SUPERBUILD>/VTK-tmp<br>
<br>
</font>instead of<br>
<font style="font-family: courier new,monospace;" size="1"><br>
</font><font style="font-family: courier new,monospace;" size="1"><CTK-SUPERBUILD>/VTK-cmake/src<br>
<CTK-SUPERBUILD>/VTK-cmake/tmp</font><br>
<br>
?<br>
<br>
Thanks for taking care of this,<br>
<br>
Sascha<br>
<br>
On 04/11/2011 06:21 PM, Jean-Christophe Fillion-Robin wrote:
<blockquote
cite="mid:BANLkTinqXrLDkugngTOmgLqerHk+t0dNyA@mail.gmail.com"
type="cite">Hi Folks, <br>
<br>
Using CTK as an external project in more and more project, the
path length could be an issue on windows platform. <br>
Indeed, the path length on windows is limited to 260 characters.
[1]<br>
<br>
<b>What motivates this change:</b><br>
<br>
Such problem could arise, if, for example, your project is build
in folder like:<br>
<br>
"c:/Dashboards/Nightly/YourProject-Superbuild-Qt-PythonQt-With-Tcl-NoCLI-nightly"
<br>
<br>
"YourProject" relying also on Superbuild and using CTK as an
external project .. will fail to build for some obscure reason. <br>
<br>
<br>
<b>Current CTK organization:</b><br>
<br>
Currently the project are organized as described below:<br>
<br>
<font style="font-family: courier new,monospace;" size="1"> <CTK-SUPERBUILD>/CMakeExternals/Build/VTK<br>
<CTK-SUPERBUILD>/CMakeExternals/Build/DCMTK<br>
...<br>
<CTK-SUPERBUILD>/CMakeExternals/Source/VTK<br>
<CTK-SUPERBUILD>/CMakeExternals/Source/DCMTK<br>
...<br>
<CTK-SUPERBUILD>/CMakeExternals/Download/VTK<br>
<CTK-SUPERBUILD>/CMakeExternals/Download/DCMTK<br>
...<br>
<CTK-SUPERBUILD>/CMakeExternals/Stamp/VTK<br>
<CTK-SUPERBUILD>/CMakeExternals/Stamp/DCMTK<br>
...<br>
<CTK-SUPERBUILD>/CTK-build</font><br>
<br>
<br>
<b>Solution proposed:</b><br>
<br>
With some minor changes, the structure would like:<br>
<br>
<font style="font-family: courier new,monospace;" size="1"> <CTK-SUPERBUILD>/CTK-build<br>
<CTK-SUPERBUILD>/VTK<br>
<CTK-SUPERBUILD>/VTK-build<br>
<CTK-SUPERBUILD>/VTK-cmake/src<br>
<CTK-SUPERBUILD>/VTK-cmake/tmp<br>
<CTK-SUPERBUILD>/VTK<br>
<CTK-SUPERBUILD>/DCMTK-build<br>
<CTK-SUPERBUILD>/DCMTK-cmake/src<br>
<CTK-SUPERBUILD>/DCMTK-cmake/tmp</font><br>
<br>
Pros:<br>
- Doing so will decrease the average length of external project
path associated with CTK. <br>
- If needed, make the "cleaning" of external project easier "rm
VTK*" instead of "cd" in each CMakeExternals sub folders .. <br>
<br>
<b>Action plan:</b><br>
<br>
I plan to implement and test this change this coming week. <br>
<br>
That improvment shouldn't cause any issue, but If it happens to be
a problem within your project and you require some time to figure
out a fix or would like to contact me. Please, do it before the
end of the week :) <br>
<br>
Next week, following your comments I will then integrate the
change to CTK master.<br clear="all">
<br>
Thanks<br>
Jc<br>
<br>
[1] <a moz-do-not-send="true"
href="http://msdn.microsoft.com/en-us/library/aa365247%28VS.85%29.aspx#maxpath">http://msdn.microsoft.com/en-us/library/aa365247%28VS.85%29.aspx#maxpath</a><br>
<br>
-- <br>
+1 919 869 8849<br>
<br>
</blockquote>
<br>
</body>
</html>