Okay - I see - the stamp are in the src directory - looks good.<br><br>And thanks for doing the re-org!<br>-Steve<br><br><div class="gmail_quote">On Mon, Apr 11, 2011 at 1:16 PM, Jean-Christophe Fillion-Robin <span dir="ltr"><<a href="mailto:jchris.fillionr@kitware.com">jchris.fillionr@kitware.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;"><br>To answer Steve question, VTK-cmake folder is just placeholder that will contain everything related VTK external project which are neither source or build.<br>
<br>More exactly ... <br><br><CTK-SUPERBUILD>/VTK-cmake/src/VTK-stamp/VTK-build<br>
<CTK-SUPERBUILD>/VTK-cmake/src/VTK-stamp/VTK-configure<br><CTK-SUPERBUILD>/VTK-cmake/src/VTK-stamp/VTK-done<br><CTK-SUPERBUILD>/VTK-cmake/src/VTK-stamp/VTK-download<br><CTK-SUPERBUILD>/VTK-cmake/src/VTK-stamp/VTK-gitinfo.txt<br>
<CTK-SUPERBUILD>/VTK-cmake/src/VTK-stamp/VTK-install<br><CTK-SUPERBUILD>/VTK-cmake/src/VTK-stamp/VTK-mkdir<br><CTK-SUPERBUILD>/VTK-cmake/src/VTK-stamp/VTK-patch<br><br><CTK-SUPERBUILD>/VTK-cmake/tmp/VTK-cfgcmd.txt<br>
<CTK-SUPERBUILD>/VTK-cmake/tmp/<a href="http://VTK-cfgcmd.txt.in" target="_blank">VTK-cfgcmd.txt.in</a><br><CTK-SUPERBUILD>/VTK-cmake/tmp/VTK-gitclone.cmake<br><br>Thanks<br>Jc<div><div></div><div class="h5">
<br> <br><br><div class="gmail_quote">On Mon, Apr 11, 2011 at 1:09 PM, Steve Pieper <span dir="ltr"><<a href="mailto:pieper@ibility.net" target="_blank">pieper@ibility.net</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;">I'd also vote for the case where "VTK" means source directory (instead of using VTK-src).<br>
<br>BTW, what goes in VTK-cmake/src ? All I see now is timestamps and tmp files...<br><font color="#888888"><br>-Steve</font><div><div></div><div><br><br><div class="gmail_quote">
On Mon, Apr 11, 2011 at 12:59 PM, Jean-Christophe Fillion-Robin <span dir="ltr"><<a href="mailto:jchris.fillionr@kitware.com" target="_blank">jchris.fillionr@kitware.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;">
Hi Sasha, <br><div><br>To clarify, when I wrote:<br><br><font style="font-family: courier new,monospace;" size="1"> <CTK-SUPERBUILD>/VTK-build<br>
<CTK-SUPERBUILD>/VTK-cmake/src<br>
<CTK-SUPERBUILD>/VTK-cmake/tmp<br>
<CTK-SUPERBUILD>/VTK</font><br><br></div>It means:<br><br><font style="font-family: courier new,monospace;" size="1"> <CTK-SUPERBUILD>/VTK-build # Build directory<br>
<CTK-SUPERBUILD>/VTK-cmake # Directory where CMake store timestamps, source ... <br>
<CTK-SUPERBUILD>/VTK # Source directory</font><br><br><br><br>Or should we use structure like this one instead:<br><br><font style="font-family: courier new,monospace;" size="1"> <CTK-SUPERBUILD>/VTK-build # Build directory<br>
<CTK-SUPERBUILD>/VTK-cmake # Directory where CMake store timestamps, source ... <br>
<CTK-SUPERBUILD>/VTK</font>-src # Source directory<br><br><br>What do you think ? <br><br>I would prefer option 1) since I am more use to it ... where the source directory match the project name.<br>
<br>Thanks<br>Jc<br><br><div class="gmail_quote"><div><div></div><div>On Mon, Apr 11, 2011 at 12:29 PM, Sascha Zelzer <span dir="ltr"><<a href="mailto:s.zelzer@dkfz-heidelberg.de" target="_blank">s.zelzer@dkfz-heidelberg.de</a>></span> wrote:<br>
</div></div><blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;"><div><div></div><div>
<div text="#000000" bgcolor="#ffffff">
Hi Jc,<br>
<br>
we use a similar structure for external projects in MITK, so +1 from
me. I would only suggest a slight modification:<br>
<br>
Can we use<br>
<br>
<font style="font-family: courier new,monospace;" size="1"><CTK-SUPERBUILD>/VTK-src<br>
<CTK-SUPERBUILD>/VTK-tmp<br>
<br>
</font>instead of<div><br>
<font style="font-family: courier new,monospace;" size="1"><br>
</font><font style="font-family: courier new,monospace;" size="1"><CTK-SUPERBUILD>/VTK-cmake/src<br>
<CTK-SUPERBUILD>/VTK-cmake/tmp</font><br>
<br></div>
?<br>
<br>
Thanks for taking care of this,<br><font color="#888888">
<br>
Sascha</font><div><div></div><div><br>
<br>
On 04/11/2011 06:21 PM, Jean-Christophe Fillion-Robin wrote:
<blockquote type="cite">Hi Folks, <br>
<br>
Using CTK as an external project in more and more project, the
path length could be an issue on windows platform. <br>
Indeed, the path length on windows is limited to 260 characters.
[1]<br>
<br>
<b>What motivates this change:</b><br>
<br>
Such problem could arise, if, for example, your project is build
in folder like:<br>
<br>
"c:/Dashboards/Nightly/YourProject-Superbuild-Qt-PythonQt-With-Tcl-NoCLI-nightly"
<br>
<br>
"YourProject" relying also on Superbuild and using CTK as an
external project .. will fail to build for some obscure reason. <br>
<br>
<br>
<b>Current CTK organization:</b><br>
<br>
Currently the project are organized as described below:<br>
<br>
<font style="font-family: courier new,monospace;" size="1"> <CTK-SUPERBUILD>/CMakeExternals/Build/VTK<br>
<CTK-SUPERBUILD>/CMakeExternals/Build/DCMTK<br>
...<br>
<CTK-SUPERBUILD>/CMakeExternals/Source/VTK<br>
<CTK-SUPERBUILD>/CMakeExternals/Source/DCMTK<br>
...<br>
<CTK-SUPERBUILD>/CMakeExternals/Download/VTK<br>
<CTK-SUPERBUILD>/CMakeExternals/Download/DCMTK<br>
...<br>
<CTK-SUPERBUILD>/CMakeExternals/Stamp/VTK<br>
<CTK-SUPERBUILD>/CMakeExternals/Stamp/DCMTK<br>
...<br>
<CTK-SUPERBUILD>/CTK-build</font><br>
<br>
<br>
<b>Solution proposed:</b><br>
<br>
With some minor changes, the structure would like:<br>
<br>
<font style="font-family: courier new,monospace;" size="1"> <CTK-SUPERBUILD>/CTK-build<br>
<CTK-SUPERBUILD>/VTK<br>
<CTK-SUPERBUILD>/VTK-build<br>
<CTK-SUPERBUILD>/VTK-cmake/src<br>
<CTK-SUPERBUILD>/VTK-cmake/tmp<br>
<CTK-SUPERBUILD>/VTK<br>
<CTK-SUPERBUILD>/DCMTK-build<br>
<CTK-SUPERBUILD>/DCMTK-cmake/src<br>
<CTK-SUPERBUILD>/DCMTK-cmake/tmp</font><br>
<br>
Pros:<br>
- Doing so will decrease the average length of external project
path associated with CTK. <br>
- If needed, make the "cleaning" of external project easier "rm
VTK*" instead of "cd" in each CMakeExternals sub folders .. <br>
<br>
<b>Action plan:</b><br>
<br>
I plan to implement and test this change this coming week. <br>
<br>
That improvment shouldn't cause any issue, but If it happens to be
a problem within your project and you require some time to figure
out a fix or would like to contact me. Please, do it before the
end of the week :) <br>
<br>
Next week, following your comments I will then integrate the
change to CTK master.<br clear="all">
<br>
Thanks<br>
Jc<br>
<br>
[1] <a href="http://msdn.microsoft.com/en-us/library/aa365247%28VS.85%29.aspx#maxpath" target="_blank">http://msdn.microsoft.com/en-us/library/aa365247%28VS.85%29.aspx#maxpath</a><br>
<br>
-- <br>
<a href="tel:%2B1%20919%20869%208849" value="+19198698849" target="_blank">+1 919 869 8849</a><br>
<br>
</blockquote>
<br>
</div></div></div>
<br></div></div>_______________________________________________<br>
Ctk-developers mailing list<br>
<a href="mailto:Ctk-developers@commontk.org" target="_blank">Ctk-developers@commontk.org</a><br>
<a href="http://public.kitware.com/cgi-bin/mailman/listinfo/ctk-developers" target="_blank">http://public.kitware.com/cgi-bin/mailman/listinfo/ctk-developers</a><br>
<br></blockquote></div><font color="#888888"><br><br clear="all"><br>-- <br><a href="tel:%2B1%20919%20869%208849" value="+19198698849" target="_blank">+1 919 869 8849</a><br><br>
</font><br>_______________________________________________<br>
Ctk-developers mailing list<br>
<a href="mailto:Ctk-developers@commontk.org" target="_blank">Ctk-developers@commontk.org</a><br>
<a href="http://public.kitware.com/cgi-bin/mailman/listinfo/ctk-developers" target="_blank">http://public.kitware.com/cgi-bin/mailman/listinfo/ctk-developers</a><br>
<br></blockquote></div><br>
</div></div></blockquote></div><br><br clear="all"><br></div></div><font color="#888888">-- <br>+1 919 869 8849<br><br>
</font></blockquote></div><br>