<div>Hi Dean,</div>
<div> </div>
<div>it seems that you're right. Your suggested change is valid. Do you want to commit a patch? I'll give a look at the other (SEGFAULT) tests.<br></div>
<div>Concerning MinGW, the cross platform support is a very good point, unfortunately it seems that thanks to the Express edition (free) of Visual Studio C++, people (including me) tend to start using Visual Studio more than MinGW... Visual Studio 2008 is pretty well supported with ITK, VTK, DCMTK, CTK... (personally I would wait a bit before using Visual Studio 2010 with these tools). However, we are really happy to have MinGW users with CTK, it is important to us to be cross-platform and cross-compiler (at least for the popular ones).</div>
<div> </div>
<div>Thanks,</div>
<div>Julien.<br></div>
<div class="gmail_quote">On Thu, Sep 16, 2010 at 2:34 PM, Dean Inglis <span dir="ltr"><<a href="mailto:dean.inglis@camris.ca">dean.inglis@camris.ca</a>></span> wrote:<br>
<blockquote style="BORDER-LEFT: #ccc 1px solid; MARGIN: 0px 0px 0px 0.8ex; PADDING-LEFT: 1ex" class="gmail_quote">Hi Jc, Julien<br><br>Im building shared release. See attached output of ctest -VV > log.txt<br>I have already set my path to include the binary bin dir where all vtk libs/dlls<br>
are: not all ctk vtk tests are failing. I have built vtk with DEBUG_LEAKS on<br>and there is one test that pops up a vtk window on termination:<br>ctkVTKChartViewTest1, which I think is due to the way the<br>ctkVTKChartView is instantiated in the test without a final delete:<br>
ctkVTKChartView* view = new ctkVTKChartView(0);<br><br>can there be instead<br>ctkVTKChartView view(0);<br><br>With regard to DCMTK and MinGW support, I chose MinGW since it<br>seems to be one of the more most cross-toolkit build friendly compiler<br>
tools for Windows. Is there a recommended Windows compiler that will compile<br>all of VTK, Qt, DCMTK, CTK ?
<div class="im"><br><br>Dean<br><br><br>----- Original Message ----- From: "Jean-Christophe Fillion-Robin" <<a href="mailto:jchris.fillionr@kitware.com" target="_blank">jchris.fillionr@kitware.com</a>><br>
To: "Julien Finet" <<a href="mailto:julien.finet@kitware.com" target="_blank">julien.finet@kitware.com</a>><br></div>Cc: "Dean Inglis" <<a href="mailto:dean.inglis@camris.ca" target="_blank">dean.inglis@camris.ca</a>>; <<a href="mailto:ctk-developers@commontk.org" target="_blank">ctk-developers@commontk.org</a>><br>
Sent: Thursday, September 16, 2010 5:00 AM
<div>
<div></div>
<div class="h5"><br>Subject: Re: [Ctk-developers] CTKWidgets compile errors<br><br><br>
<blockquote style="BORDER-LEFT: #ccc 1px solid; MARGIN: 0px 0px 0px 0.8ex; PADDING-LEFT: 1ex" class="gmail_quote">Hi Dean,<br><br>Are you building in debug or release?<br><br>Test ctkVTKConnectionTest1 should now be fixed . See<br>
<a href="http://github.com/commontk/CTK/commit/e5c275e115d85b1d308338f1591135622eaf73a3" target="_blank">http://github.com/commontk/CTK/commit/e5c275e115d85b1d308338f1591135622eaf73a3</a><br><br>Regarding ctkCommandLineParserTest1, would it be possible to run CTest with<br>
-V option and send the output.<br><br>Thks<br>Jc<br><br>On Thu, Sep 16, 2010 at 4:27 AM, Julien Finet <<a href="mailto:julien.finet@kitware.com" target="_blank">julien.finet@kitware.com</a>>wrote:<br><br>
<blockquote style="BORDER-LEFT: #ccc 1px solid; MARGIN: 0px 0px 0px 0.8ex; PADDING-LEFT: 1ex" class="gmail_quote">Dean,<br><br>your failing tests come from the fact that ctest can't find the VTK<br>libraries ( you would need to set the bin path of VTK into your PATH env<br>
variable until we have a CTK launcher (to automatically set environment<br>variables before calling the tests)<br><br>Concerning the errors, they come from DCMTK but DCMTK doesn't officially<br>support MinGW. However we have a local copy of DCMTK so I guess we can add<br>
more patches to it.<br><br>Julien.<br>On Thu, Sep 16, 2010 at 1:43 AM, Dean Inglis <<a href="mailto:dean.inglis@camris.ca" target="_blank">dean.inglis@camris.ca</a>>wrote:<br><br>
<blockquote style="BORDER-LEFT: #ccc 1px solid; MARGIN: 0px 0px 0px 0.8ex; PADDING-LEFT: 1ex" class="gmail_quote">Hi Jc,<br><br>compile problems fixed. FYI, I ran ctest in my CTK-build dir and<br>the following tests are failing:<br>
89% tests passed, 6 tests failed out of 53<br>Label Time Summary:<br>CTKCore = 11.09 sec<br>CTKPluginFramework = 0.17 sec<br>CTKVisualizationVTKCore = 8.40 sec<br>CTKVisualizationVTKWidgets = 51.38 sec<br>
CTKWidgets = 51.37 sec<br><br>Total Test time (real) = 123.07 sec<br><br>The following tests FAILED:<br> 1 - ctkCommandLineParserTest1 (Failed)<br> 38 - ctkVTKConnectionTest1 (Failed)<br> 41 - ctkTransferFunctionViewTest1 (SEGFAULT)<br>
42 - ctkTransferFunctionViewTest2 (SEGFAULT)<br> 43 - ctkTransferFunctionViewTest3 (SEGFAULT)<br> 44 - ctkTransferFunctionViewTest4 (SEGFAULT)<br><br>Also, I turned on<br>//Enable DICOM/Core Library.<br>CTK_LIB_DICOM/Core:BOOL=ON<br>
to see if I can build more of ctk but encounter the following errors:<br><br>[ 42%] No build step for 'DCMTK'<br>[ 42%] Performing install step for 'DCMTK'<br>Scanning dependencies of target ofstd<br>[ 0%] Building CXX object<br>
ofstd/libsrc/CMakeFiles/ofstd.dir/ofcmdln.cxx.obj<br>In file included from<br>D:\Developer\Releases\MinGW\SHARED\ctk\CMakeExternals\Sour<br>ce\DCMTK\ofstd\libsrc\ofcmdln.cxx:34:<br><br>D:\Developer\Releases\MinGW\SHARED\ctk\CMakeExternals\Build\DCMTK\include/dcmtk/<br>
config/osconfig.h:793:1: warning: "NO_IOS_BASE_ASSIGN" redefined<br><br>D:\Developer\Releases\MinGW\SHARED\ctk\CMakeExternals\Build\DCMTK\include/dcmtk/<br>config/osconfig.h:42:1: warning: this is the location of the previous<br>
definition<br><br>In file included from<br>D:\Developer\Releases\MinGW\SHARED\ctk\CMakeExternals\Sour<br>ce\DCMTK\ofstd\include/dcmtk/ofstd/oflist.h:99,<br> from<br>D:\Developer\Releases\MinGW\SHARED\ctk\CMakeExternals\Sour<br>
ce\DCMTK\ofstd\include/dcmtk/ofstd/ofcmdln.h:39,<br> from<br>D:\Developer\Releases\MinGW\SHARED\ctk\CMakeExternals\Sour<br>ce\DCMTK\ofstd\libsrc\ofcmdln.cxx:36:<br>c:\qt\mingw\bin\../lib/gcc/mingw32/4.4.0/../../../../include/sys/types.h:75:<br>
err<br>or: multiple types in one declaration<br>c:\qt\mingw\bin\../lib/gcc/mingw32/4.4.0/../../../../include/sys/types.h:75:<br>err<br>or: declaration does not declare anything<br>c:\qt\mingw\bin\../lib/gcc/mingw32/4.4.0/../../../../include/sys/types.h:104:<br>
er<br>ror: declaration does not declare anything<br>mingw32-make[5]: *** [ofstd/libsrc/CMakeFiles/ofstd.dir/ofcmdln.cxx.obj]<br>Error 1<br><br>mingw32-make[4]: *** [ofstd/libsrc/CMakeFiles/ofstd.dir/all] Error 2<br><br>mingw32-make[3]: *** [all] Error 2<br>
mingw32-make[2]: *** [CMakeExternals/Stamp/DCMTK/DCMTK-install] Error 2<br>mingw32-make[1]: *** [CMakeFiles/DCMTK.dir/all] Error 2<br><br>mingw32-make: *** [all] Error 2<br><br><br>Ive read in a few posts that the multiple types in one declaration error<br>
can be caused by a missing<br>semicolon at the end of a class definition or a missing closing brace in a<br>class definition.<br><br>Dean<br><br>----- Original Message ----- From: "Jean-Christophe Fillion-Robin" <<br>
<a href="mailto:jchris.fillionr@kitware.com" target="_blank">jchris.fillionr@kitware.com</a>><br>To: "Julien Finet" <<a href="mailto:julien.finet@kitware.com" target="_blank">julien.finet@kitware.com</a>><br>
Cc: <<a href="mailto:ctk-developers@commontk.org" target="_blank">ctk-developers@commontk.org</a>><br>Sent: Wednesday, September 15, 2010 6:55 PM<br>Subject: Re: [Ctk-developers] CTKWidgets compile errors<br><br><br>
<br>Hi Dean,<br>
<blockquote style="BORDER-LEFT: #ccc 1px solid; MARGIN: 0px 0px 0px 0.8ex; PADDING-LEFT: 1ex" class="gmail_quote"><br>The following commits:<br><br><a href="http://github.com/commontk/CTK/compare/bab18744b88d3166d37b...059542769bb1851fd6ed" target="_blank">http://github.com/commontk/CTK/compare/bab18744b88d3166d37b...059542769bb1851fd6ed</a><br>
.. should fix the problem.<br><br>Let me know if you have any other issues.<br><br>Thks<br>Jc<br><br>On Wed, Sep 15, 2010 at 6:28 PM, Julien Finet <<a href="mailto:julien.finet@kitware.com" target="_blank">julien.finet@kitware.com</a><br>
>wrote:<br><br>Sorry about that... we're still working on these... we'll let you know<br>
<blockquote style="BORDER-LEFT: #ccc 1px solid; MARGIN: 0px 0px 0px 0.8ex; PADDING-LEFT: 1ex" class="gmail_quote">when<br>you can update your CTK dir.<br>Thanks for your patience,<br>Julien.<br>On Wed, Sep 15, 2010 at 11:09 PM, Wagner Sales <<a href="mailto:wsales@gmail.com" target="_blank">wsales@gmail.com</a>><br>
wrote:<br><br>Hi,<br>
<blockquote style="BORDER-LEFT: #ccc 1px solid; MARGIN: 0px 0px 0px 0.8ex; PADDING-LEFT: 1ex" class="gmail_quote"><br>I'm experiencing this errors with Qt 4.7.0 ( release candidate ).<br><br>Wagner Sales<br><br><br>2010/9/15 Dean Inglis <<a href="mailto:dean.inglis@camris.ca" target="_blank">dean.inglis@camris.ca</a>>:<br>
> Hello,<br>><br>> some recent changes to the ctk source result in the following > errors<br>> on<br>> Win32 Vista<br>> MinGW (Qt SDK 4.6.3) which might not show on my experimental<br>dashboard<br>> (hyoid)<br>
> submission since it is failing to compile/configure/test QtMobility > ><br>(as<br>> mentioned in prev<br>> message threads).<br>><br>> hth,<br>> Dean<br>><br>> D:\Developer\Sources\CTK\Libs\Widgets\ctkWorkflowButtonBoxWidget.cpp:<br>
> In<br>> member<br>> function 'void<br>> ctkWorkflowButtonBoxWidgetPrivate::updateBackButton(ctkWorkflowSt<br>> ep*)':<br>><br><br>D:\Developer\Sources\CTK\Libs\Widgets\ctkWorkflowButtonBoxWidget.cpp:114:<br>
> warnin<br>> g: unused variable 'q' [-Wunused-variable]<br>> D:\Developer\Sources\CTK\Libs\Widgets\ctkWorkflowButtonBoxWidget.cpp:<br>> In<br>> member<br>> function 'void<br>> ctkWorkflowButtonBoxWidgetPrivate::updateNextButton(ctkWorkflowSt<br>
> ep*)':<br>><br><br>D:\Developer\Sources\CTK\Libs\Widgets\ctkWorkflowButtonBoxWidget.cpp:156:<br>> warnin<br>> g: unused variable 'q' [-Wunused-variable]<br>> [ 31%] Building CXX object<br>> Libs/Widgets/CMakeFiles/CTKWidgets.dir/ctkWorkflowGro<br>
> upBox.cpp.obj<br>> [ 32%] Building CXX object<br>> Libs/Widgets/CMakeFiles/CTKWidgets.dir/ctkWorkflowSta<br>> ckedWidget.cpp.obj<br>> [ 32%] Building CXX object<br>> Libs/Widgets/CMakeFiles/CTKWidgets.dir/ctkWorkflowTab<br>
> Widget.cpp.obj<br>> [ 32%] Building CXX object<br>> Libs/Widgets/CMakeFiles/CTKWidgets.dir/ctkWorkflowWid<br>> get.cpp.obj<br>> [ 32%] Building CXX object<br>> Libs/Widgets/CMakeFiles/CTKWidgets.dir/ctkWorkflowWid<br>
> getStep.cpp.obj<br>> [ 32%] Building CXX object<br>> Libs/Widgets/CMakeFiles/CTKWidgets.dir/moc_ctkWorkflo<br>> wAbstractWidgetStep_p.cxx.obj<br>> [ 33%] Building CXX object<br>> Libs/Widgets/CMakeFiles/CTKWidgets.dir/moc_ctkActions<br>
> Widget.cxx.obj<br>> In file included from C:\Qt\qt\include/QtCore/qscopedpointer.h:1,<br>> from<br>> C:\Qt\qt\include/QtCore/../../src/corelib/kernel/qobject.h<br>> :54,<br>> from C:\Qt\qt\include/QtCore/qobject.h:1,<br>
> from<br>> C:\Qt\qt\include/QtGui/../../src/gui/itemviews/qabstractit<br>> emdelegate.h:45,<br>> from > C:\Qt\qt\include/QtGui/qabstractitemdelegate.h:1,<br>> from<br>
> C:\Qt\qt\include\QtGui/../../src/gui/itemviews/qstyleditem<br>> delegate.h:45,<br>> from C:\Qt\qt\include\QtGui/qstyleditemdelegate.h:1,<br>> from C:\Qt\qt\include\QtGui/QStyledItemDelegate:1,<br>
> from<br>> D:\Developer\Releases\MinGW\SHARED\ctk\CTK-build\Libs\Widg<br>><br><br>ets\/../../../../../../../Sources/CTK/Libs/Widgets/ctkActionsWidget.h:25,<br>> from<br>> D:\Developer\Releases\MinGW\SHARED\ctk\CTK-build\Libs\Widg<br>
> ets\moc_ctkActionsWidget.cxx:10:<br>> C:\Qt\qt\include/QtCore/../../src/corelib/tools/qscopedpointer.h: > In<br>static<br>> memb<br>> er function 'static void QScopedPointerDeleter<T>::cleanup(T*) > [with<br>
T > =<br>> ctkSort<br>> FilterActionsProxyModelPrivate]':<br>> C:\Qt\qt\include/QtCore/../../src/corelib/tools/qscopedpointer.h:100:<br>> instanti<br>> ated from 'QScopedPointer<T, Cleanup>::~QScopedPointer() [with T =<br>
> ctkSortFilter<br>> ActionsProxyModelPrivate, Cleanup =<br>> QScopedPointerDeleter<ctkSortFilterActionsPr<br>> oxyModelPrivate>]'<br>><br><br>D:\Developer\Releases\MinGW\SHARED\ctk\CTK-build\Libs\Widgets\/../../../../../..<br>
> /../Sources/CTK/Libs/Widgets/ctkActionsWidget.h:106: instantiated > ><br>from<br>> here<br>> C:\Qt\qt\include/QtCore/../../src/corelib/tools/qscopedpointer.h:59:<br>error:<br>> inva<br>> lid application of 'sizeof' to incomplete type<br>
> 'ctkSortFilterActionsProxyModelPr<br>> ivate'<br>> C:\Qt\qt\include/QtCore/../../src/corelib/tools/qscopedpointer.h:59:<br>error:<br>> crea<br>> ting array with negative size ('-0x000000001')<br>
> C:\Qt\qt\include/QtCore/../../src/corelib/tools/qscopedpointer.h:62:<br>> warning: po<br>> ssible problem detected in invocation of delete operator:<br>> C:\Qt\qt\include/QtCore/../../src/corelib/tools/qscopedpointer.h:54:<br>
> warning: 'p<br>> ointer' has incomplete type<br>><br><br>D:\Developer\Releases\MinGW\SHARED\ctk\CTK-build\Libs\Widgets\/../../../../../..<br>> /../Sources/CTK/Libs/Widgets/ctkActionsWidget.h:33: warning: > forward<br>
> declaration<br>> of 'struct ctkSortFilterActionsProxyModelPrivate'<br>> C:\Qt\qt\include/QtCore/../../src/corelib/tools/qscopedpointer.h:62:<br>note:<br>> neith<br>> er the destructor nor the class-specific operator delete will be ><br>
called,<br>> even if<br>> they are declared when the class is defined.<br>> mingw32-make[5]: ***<br>> [Libs/Widgets/CMakeFiles/CTKWidgets.dir/moc_ctkActionsWidge<br>> t.cxx.obj] Error 1<br>> mingw32-make[4]: *** [Libs/Widgets/CMakeFiles/CTKWidgets.dir/all] ><br>
Error<br>2<br>> mingw32-make[3]: *** [all] Error 2<br>> mingw32-make[2]: *** > [CMakeExternals/Stamp/CTK-build/CTK-build-build]<br>Error<br>> 2<br>> mingw32-make[1]: *** [CMakeFiles/CTK-build.dir/all] Error 2<br>
> mingw32-make: *** [all] Error 2<br>> _______________________________________________<br>> Ctk-developers mailing list<br>> <a href="mailto:Ctk-developers@commontk.org" target="_blank">Ctk-developers@commontk.org</a><br>
> <a href="http://public.kitware.com/cgi-bin/mailman/listinfo/ctk-developers" target="_blank">http://public.kitware.com/cgi-bin/mailman/listinfo/ctk-developers</a><br>><br>_______________________________________________<br>
Ctk-developers mailing list<br><a href="mailto:Ctk-developers@commontk.org" target="_blank">Ctk-developers@commontk.org</a><br><a href="http://public.kitware.com/cgi-bin/mailman/listinfo/ctk-developers" target="_blank">http://public.kitware.com/cgi-bin/mailman/listinfo/ctk-developers</a><br>
<br><br></blockquote><br>_______________________________________________<br>Ctk-developers mailing list<br><a href="mailto:Ctk-developers@commontk.org" target="_blank">Ctk-developers@commontk.org</a><br><a href="http://public.kitware.com/cgi-bin/mailman/listinfo/ctk-developers" target="_blank">http://public.kitware.com/cgi-bin/mailman/listinfo/ctk-developers</a><br>
<br><br><br></blockquote><br>--<br>Phone: 1-518-836-2174<br>Ext: 304<br><br><br></blockquote><br>--------------------------------------------------------------------------------<br><br><br><br><br>_______________________________________________<br>
<blockquote style="BORDER-LEFT: #ccc 1px solid; MARGIN: 0px 0px 0px 0.8ex; PADDING-LEFT: 1ex" class="gmail_quote">Ctk-developers mailing list<br><a href="mailto:Ctk-developers@commontk.org" target="_blank">Ctk-developers@commontk.org</a><br>
<a href="http://public.kitware.com/cgi-bin/mailman/listinfo/ctk-developers" target="_blank">http://public.kitware.com/cgi-bin/mailman/listinfo/ctk-developers</a><br><br><br></blockquote><br></blockquote><br></blockquote>
<br>
<br>-- <br>Phone: 1-518-836-2174<br>Ext: 304<br><br></blockquote></div></div></blockquote></div><br>