<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN">
<html>
<head>
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
</head>
<body bgcolor="#ffffff" text="#000000">
Hi,<br>
<br>
I do not fully understand the problem yet, but here are some points to
discuss:<br>
<br>
1.) Log4Qt is already getting compiled with visibility=hidden (see
<a class="moz-txt-link-freetext" href="http://github.com/commontk/Log4Qt/blob/patched/CMakeLists.txt">http://github.com/commontk/Log4Qt/blob/patched/CMakeLists.txt</a>), so the
error has to be something else<br>
<br>
2.) Log4Qt seems to be a static library only. Is this an inherent
"feature" of Log4Qt? I feel that this could potentially lead to quite
some increase in object size, if the number of shared libraries
(plugins) linking to Log4Qt increases a lot in the future.<br>
<br>
3.) A google search revealed that quite a few people get the same
warnings on a mac for different projects. However, there has been no
clear solution, except for modifying compiler flags of external
libraries (for std::min<...> this would obviously not work...).
We could just add a compiler flag to suppress the warning, if we are
sure that it has no side effects.<br>
<br>
- Sascha<br>
<br>
On 07/09/2010 04:47 PM, Jean-Christophe Fillion-Robin wrote:
<blockquote
cite="mid:AANLkTil6jcYwwNG2WwulyIxTSO4bVhEBzfIgACJv7vJv@mail.gmail.com"
type="cite">Hi Folks, <br>
<br>
Is there any dashboard where these error are reported ? <br>
<br>
Does that sound like a reasonable option:<br>
- Add visibility flags to Log4Qt and DCMTK ? <br>
<br>
Thks<br>
Jc<br>
<br>
<div class="gmail_quote">On Fri, Jul 9, 2010 at 10:15 AM, Luis Ibanez
<span dir="ltr"><<a moz-do-not-send="true"
href="mailto:luis.ibanez@kitware.com">luis.ibanez@kitware.com</a>></span>
wrote:<br>
<blockquote class="gmail_quote"
style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;"><br>
We have seen the same warnings on Mac <br>
(and not when building on Ubuntu).<br>
<br>
I looks like it is a Mac issue...,<br>
<br>
but It is annoying enough <br>
that it will be nice to fix it. :-)<br>
<br>
<br>
Luis<br>
<br>
<br>
-----------------------------------------------------
<div>
<div class="h5"><br>
<div class="gmail_quote">On Thu, Jul 8, 2010 at 10:30 PM, Daniel
Blezek <span dir="ltr"><<a moz-do-not-send="true"
href="mailto:daniel.blezek@gmail.com" target="_blank">daniel.blezek@gmail.com</a>></span>
wrote:<br>
<blockquote class="gmail_quote"
style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">Sascha,<br>
<br>
I just built on linux and didn't have this problem with linking.
Perhaps the flag isn't doing exactly what we expect? Or is the Mac
just more picky? Can you easily tell?<br>
<br>
Cheers,<br>
<div>-dan<br>
<br>
<br>
<br>
On Jul 7, 2010, at 12:52 AM, Sascha Zelzer wrote:<br>
<br>
</div>
<div>
<div>> Hi Dan,<br>
><br>
> this is the closed issue for the change:<br>
><br>
> <a moz-do-not-send="true"
href="http://github.com/pieper/CTK/issues/closed#issue/10"
target="_blank">http://github.com/pieper/CTK/issues/closed#issue/10</a><br>
><br>
> I have not seen any linker wanings on my Linux machine yet, did
you introduce new code (and what system are you running)?<br>
><br>
> The flags cannot easily be applied to external libraries, since
symbols must be prefixed with the appropriate import/export specifiers
in the .h files.<br>
><br>
> Best,<br>
> Sascha<br>
><br>
> On 07/07/2010 04:12 AM, Daniel Blezek wrote:<br>
>> Hi all,<br>
>><br>
>> Can someone explain this code from the top level CTK
CMakeLists.txt file?<br>
>><br>
>>
#-----------------------------------------------------------------------------<br>
>> # Set symbol visibility Flags<br>
>> #<br>
>> IF("${CMAKE_CXX_COMPILER_ID}" STREQUAL "GNU")<br>
>> SET(VISIBILITY_CXX_FLAGS "-fvisibility=hidden
-fvisibility-inlines-hidden")<br>
>> ENDIF()<br>
>><br>
>><br>
>> This causes all sorts of linker warnings because Log4Qt
doesn't include the flag and CTK does.<br>
>><br>
>> Is this strictly necessary? If so, can it be applied to the
Externals as well?<br>
>><br>
>> Thanks,<br>
>> -dan<br>
>><br>
>> --<br>
>> Daniel Blezek<br>
>> <a moz-do-not-send="true"
href="mailto:daniel.blezek@gmail.com" target="_blank">daniel.blezek@gmail.com</a><br>
>><br>
>><br>
>><br>
>> _______________________________________________<br>
>> Ctk-developers mailing list<br>
>> <a moz-do-not-send="true"
href="mailto:Ctk-developers@commontk.org" target="_blank">Ctk-developers@commontk.org</a><br>
>> <a moz-do-not-send="true"
href="http://public.kitware.com/cgi-bin/mailman/listinfo/ctk-developers"
target="_blank">http://public.kitware.com/cgi-bin/mailman/listinfo/ctk-developers</a><br>
>><br>
><br>
> _______________________________________________<br>
> Ctk-developers mailing list<br>
> <a moz-do-not-send="true"
href="mailto:Ctk-developers@commontk.org" target="_blank">Ctk-developers@commontk.org</a><br>
> <a moz-do-not-send="true"
href="http://public.kitware.com/cgi-bin/mailman/listinfo/ctk-developers"
target="_blank">http://public.kitware.com/cgi-bin/mailman/listinfo/ctk-developers</a><br>
<br>
--<br>
Daniel Blezek<br>
<a moz-do-not-send="true" href="mailto:daniel.blezek@gmail.com"
target="_blank">daniel.blezek@gmail.com</a><br>
<br>
<br>
<br>
_______________________________________________<br>
Ctk-developers mailing list<br>
<a moz-do-not-send="true"
href="mailto:Ctk-developers@commontk.org" target="_blank">Ctk-developers@commontk.org</a><br>
<a moz-do-not-send="true"
href="http://public.kitware.com/cgi-bin/mailman/listinfo/ctk-developers"
target="_blank">http://public.kitware.com/cgi-bin/mailman/listinfo/ctk-developers</a><br>
</div>
</div>
</blockquote>
</div>
<br>
</div>
</div>
<br>
_______________________________________________<br>
Ctk-developers mailing list<br>
<a moz-do-not-send="true" href="mailto:Ctk-developers@commontk.org">Ctk-developers@commontk.org</a><br>
<a moz-do-not-send="true"
href="http://public.kitware.com/cgi-bin/mailman/listinfo/ctk-developers"
target="_blank">http://public.kitware.com/cgi-bin/mailman/listinfo/ctk-developers</a><br>
<br>
</blockquote>
</div>
<br>
<br clear="all">
<br>
-- <br>
Phone: 1-518-836-2174<br>
Ext: 304<br>
</blockquote>
<br>
</body>
</html>