[Ctk-developers] Fwd: [GitHub] Retrieve (and Database) bugs [commontk/CTK GH-16]

[Jean-Christophe Fillion-Robin]

Good morning folks,

Could somebody consider the remark of Dragan ?

May be multiple issue should be entered in the issue tracker, prioritized
and assigned to the appropriate people.

I let the ctkDICOM guru chime in ... :)

Thanks
Jc

---------- Forwarded message ----------
From: toromand <
reply+i-842542-9e237d982bb977f5158e4336e117d72ea9fe04af at reply.github.com>
Date: Tue, May 3, 2011 at 6:12 AM
Subject: [GitHub] Retrieve (and Database) bugs [commontk/CTK GH-16]
To: jchris.fillionr at kitware.com


- The network connection in ctkDICOMRetrieve is never "dropped". Consequent
calls to the retrieve function ends up with the message that "The network
address is already in use" as the association is never closed.
Should include call to closeAssociation on several places. It would be even
better to use the member SCU (narked as to-do) in the source, to make it
even better. Special care should be taken on exception when called from
"outside".
- Retrieved object are written to the disk two times. The portion of code
"borrowed" from the dcmdjpeg example should not exist in the retrieve code,
because the data (according to the design) should be and is written in the
database.insert().

- Also, in ctkDICOMDatabase, there is a problem with retrieved object
paths/filenames. The present system of using UIDs is not compliant with the
DICOM standard, especially if you would like to create (proper) DICOMDIR and
archive media. Paths and filenames should be generated to have max 8
characters according to the DICOM standard (check with Clunie if you don't
beleive me :) )
- Different behavior of in-memory and file database should not be
implemented (at least not like that) in the Core library code. One should
expect that the call to a function (insert()) should depend on parameters
only.

- You should also correct the calls to database.insert() to reflect the
needed use.
For instance, in ctkDICOMQuery, the call to database.insert() is missing
"false, false" (causing some side-efects, like trying to generate thumbnails
for non-existent images)

Enough for this post :)
Keep the good work,
Dragan Toroman

--
Reply to this email directly or view it on GitHub:
https://github.com/commontk/CTK/issues/16



-- 
+1 919 869 8849
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://public.kitware.com/pipermail/ctk-developers/attachments/20110503/ae87059c/attachment.html>