[Ctk-developers] Adding ArtisticStyle to commontk

Jean-Christophe Fillion-Robin jchris.fillionr at kitware.com
Fri Jul 29 08:48:55 EDT 2011


I just added my note explaining how to create a svn-mirror.
See
http://www.commontk.org/index.php/Documentation/Create_SVN_Project_Mirror

Regarding adding option like CTK_USE_SYSTEM_ASTYLE, i propose we think about
the problem as a whole and not just about an exception for AStyle.

Thanks
Jc

On Fri, Jul 29, 2011 at 7:57 AM, Sascha Zelzer
<s.zelzer at dkfz-heidelberg.de>wrote:

> **
> On 07/29/2011 01:50 PM, Steve Pieper wrote:
>
> Okay - make sense to me - add me to the forming consensus :)
>
> Okay ;-)
>
>
>  When it's all working let's offer back our changes to the astyle team in
> hopes that they can be in future releases.  Dominique has me trained now to
> think about the packaging implications of our changes to upstream libraries.
>
> Yes, good point. We have to take packaging issues seriously. In this case,
> there are no code changes to the library itself. We would need a
> "FindAStyle.cmake" script and maybe a CTK_USE_SYSTEM_ASTYLE variable to find
> an already installed library. If it is missing we can conveniently build it
> from our commontk repo.
>
> Thanks for your suggestions,
>
> Sascha
>
>
>  Best,
> Steve
>
> On Fri, Jul 29, 2011 at 7:35 AM, Sascha Zelzer <
> s.zelzer at dkfz-heidelberg.de> wrote:
>
>>  Hi Steve
>>
>> I thought about that too, but after looking at the build system which
>> comes with the download-able source packages, I was getting scared... There
>> are three different packages for each major OS, each again with different
>> make files or IDE project files. Therefore I think we will have less
>> troubles with our own repo which adds CMake scripts to the library.
>>
>> Thanks,
>>  Sascha
>>
>>
>> On 07/29/2011 01:01 PM, Steve Pieper wrote:
>>
>> Hi Sascha -
>>
>>  This sounds a nice addition.
>>
>>  One question; could this be done as an external project?   I think we
>> would only need a repository if the library requires patches in order to
>> work in CTK.  Ideally these patches will be sent back upstream so we can use
>> a release version of the library.
>>
>>  -Steve
>>
>>
>>
>> On Fri, Jul 29, 2011 at 5:19 AM, Sascha Zelzer <
>> s.zelzer at dkfz-heidelberg.de> wrote:
>>
>>> Hi guys,
>>>
>>> I would like to exercise the "getting consensus" model for changes in
>>> commontk, as suggested by JC. Currently, there is a small program in CTK
>>> which allows to generate source code for CTK plug-ins (the
>>> ctkPluginGenerator). I'd like to add the ArtisticStyle library as a new
>>> project to commontk to use its code formatting capabilities to generate
>>> nicely formatted sources inside the ctkPluginGenerator.
>>>
>>> Any thoughts or objections?
>>>
>>> Thanks,
>>> Sascha
>>> _______________________________________________
>>> Ctk-developers mailing list
>>> Ctk-developers at commontk.org
>>> http://public.kitware.com/cgi-bin/mailman/listinfo/ctk-developers
>>>
>>
>>
>>
>
>
> _______________________________________________
> Ctk-developers mailing list
> Ctk-developers at commontk.org
> http://public.kitware.com/cgi-bin/mailman/listinfo/ctk-developers
>
>


-- 
+1 919 869 8849
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://public.kitware.com/pipermail/ctk-developers/attachments/20110729/a9d44812/attachment.html>


More information about the Ctk-developers mailing list