[Ctk-developers] ShowStatusTextUponGoToStepSuccess workflow feature, please review

[Julien Finet]

Added in CTK:
https://github.com/commontk/CTK/commit/b6314ac0521de183046ce101d630a43777c5c949

Added in Slicer: r17743
http://viewvc.slicer.org/viewvc.cgi/Slicer4?view=revision&revision=17743

Thanks,
Julien.

On Wed, Aug 17, 2011 at 4:51 PM, Daniel Haehn <haehn at bwh.harvard.edu> wrote:

> Please review
>
>
> https://github.com/haehn/CTK/tree/add-ErrorTextEnabledPropertyWorkflowGroupbox-feature
>
> Thanks,
> Daniel
>
> On Wed, Aug 17, 2011 at 3:38 PM, Daniel Haehn <haehn at bwh.harvard.edu>
> wrote:
> > Ok, will do so.
> >
> > Daniel
> >
> > On Wed, Aug 17, 2011 at 3:36 PM, Jean-Christophe Fillion-Robin
> > <jchris.fillionr at kitware.com> wrote:
> >> You could expose the getter returning workflowGroupBox.. then the
> property
> >> ErrorTextDisabled will be accessible.
> >>
> >> Jc
> >>
> >> On Wed, Aug 17, 2011 at 3:32 PM, Daniel Haehn <haehn at bwh.harvard.edu>
> wrote:
> >>>
> >>> I don't think it is possible to access the groupbox if you created a
> >>> ctkWorkflowWidget in Python. So would it make sense to expose this one
> >>> as well?
> >>>
> >>> Daniel
> >>>
> >>> On Wed, Aug 17, 2011 at 3:26 PM, Julien Finet <
> julien.finet at kitware.com>
> >>> wrote:
> >>> > myWorkflowGroupBox.ErrorTextDisabled = True
> >>> > no?
> >>> > j.
> >>> >
> >>> > On Wed, Aug 17, 2011 at 3:15 PM, Daniel Haehn <haehn at bwh.harvard.edu
> >
> >>> > wrote:
> >>> >>
> >>> >> Hi JC,
> >>> >>
> >>> >> thanks for the feedback.
> >>> >>
> >>> >> If we would add the property ErrorTextDisabled to the
> >>> >> ctkWorkflowGroupBox, how can it be set from Python?
> >>> >>
> >>> >> Cheers,
> >>> >> Daniel
> >>> >>
> >>> >> On Tue, Aug 16, 2011 at 3:39 PM, Jean-Christophe Fillion-Robin
> >>> >> <jchris.fillionr at kitware.com> wrote:
> >>> >> > Hi Daniel,
> >>> >> >
> >>> >> > Just looked at it.
> >>> >> >
> >>> >> > Please consider the following remarks:
> >>> >> >  - Regarding the git commit msg. See
> >>> >> >
> >>> >> >
> http://www.commontk.org/index.php/Contributing_to_CTK#Git_Commit_Style
> >>> >> >
> >>> >> >  - Regarding the patch:
> >>> >> >      - May be you could just add a property named
> ErrorTextDisabled
> >>> >> > to
> >>> >> > ctkWorkflowGroupBox ?
> >>> >> >     - See line 110 of ctkWorkflowGroupBox.cpp
> >>> >> >
> >>> >> > Danielle> What do you think ?
> >>> >> >
> >>> >> > Thanks
> >>> >> > Jc
> >>> >> >
> >>> >> > On Tue, Aug 16, 2011 at 12:35 PM, Daniel Haehn
> >>> >> > <haehn at bwh.harvard.edu>
> >>> >> > wrote:
> >>> >> >>
> >>> >> >> Hi,
> >>> >> >>
> >>> >> >> did anybody have a chance to look at it yet?
> >>> >> >>
> >>> >> >> Thanks,
> >>> >> >> Daniel
> >>> >> >>
> >>> >> >> On Thu, Aug 11, 2011 at 1:15 PM, Daniel Haehn
> >>> >> >> <haehn at bwh.harvard.edu>
> >>> >> >> wrote:
> >>> >> >> > Hi Devels,
> >>> >> >> >
> >>> >> >> > could anybody please review the following topic:
> >>> >> >> >
> >>> >> >> >
> >>> >> >> >
> >>> >> >> >
> >>> >> >> >
> https://github.com/haehn/CTK/commits/add-ShowStatusTextUponGoToStepSuccess-workflow-feature
> >>> >> >> >
> >>> >> >> > I added a property to be able to disable the Status Text update
> on
> >>> >> >> > the
> >>> >> >> > origin step when a GoToStep(..)-call of a ctkWorkflow succeeds.
> >>> >> >> >
> >>> >> >> > Looking forward to your feedback..
> >>> >> >> >
> >>> >> >> > Daniel
> >>> >> >> >
> >>> >> >> _______________________________________________
> >>> >> >> Ctk-developers mailing list
> >>> >> >> Ctk-developers at commontk.org
> >>> >> >>
> http://public.kitware.com/cgi-bin/mailman/listinfo/ctk-developers
> >>> >> >
> >>> >> >
> >>> >> >
> >>> >> > --
> >>> >> > +1 919 869 8849
> >>> >> >
> >>> >> >
> >>> >> _______________________________________________
> >>> >> Ctk-developers mailing list
> >>> >> Ctk-developers at commontk.org
> >>> >> http://public.kitware.com/cgi-bin/mailman/listinfo/ctk-developers
> >>> >
> >>> >
> >>
> >>
> >>
> >> --
> >> +1 919 869 8849
> >>
> >>
> >
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://public.kitware.com/pipermail/ctk-developers/attachments/20110817/77d2c659/attachment.html>