[Ctk-developers] Merging branch "dah" into master

[Zelzer Sascha]

Hi Julien,

testing is of course an important topic :)

The dah branch is not related to "classic DICOM features" , could you explain to which DICOM classes you are referring to? Currently (if I am not wrong), the dah code does not have any unit tests. The could should still be seen as a proof of concept.

Sascha

Von: Julien Finet [mailto:julien.finet at kitware.com]
Gesendet: Freitag, 22. Oktober 2010 15:43
An: Zelzer Sascha
Cc: ctk-developers at commontk.org
Betreff: Re: [Ctk-developers] Merging branch "dah" into master

Hi Sascha,

It seems like a good idea to "publish" the dah branch !
I've a little request though (as you asked for it :-) ). Last time I checked, there was not many unit tests (2?) for all the DICOM classes. I think that DAH would greatly benefit from some more testing. I believe it's a good timing to add tests (if you want to merge it means the design is quite stable meaning tests can be written :-) ).

My 2 cents,
Julien.
On Fri, Oct 22, 2010 at 9:27 AM, Zelzer Sascha <s.zelzer at dkfz-heidelberg.de<mailto:s.zelzer at dkfz-heidelberg.de>> wrote:
Hi Folks,

CTK has seen many improvements since the Barcelona hackfest and I would like to merge the dah branch "dicom application hosting" into master to take advantage of the new features. The advantages would be


-          The dah code would benefit from future refactorings taking place in the master branch

-          Make use of proper include path inheritance between plugins and libraries

-          Take advantage of improvements inside ctkPluginFramework

-          Improve the visibility of the dah plugins to the community

After the merge, developers could still hack on new features in their own branches inside their CTK forks.

I would take care of adapting the dah code and cleaning up some memory management issues.

Do you have any concerns / remarks?

Thanks,

Sascha

_______________________________________________
Ctk-developers mailing list
Ctk-developers at commontk.org<mailto:Ctk-developers at commontk.org>
http://public.kitware.com/cgi-bin/mailman/listinfo/ctk-developers

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://public.kitware.com/pipermail/ctk-developers/attachments/20101022/c0a6dfe8/attachment.html>