[Ctk-developers] CTK Dashboard: Cleaning up Warnings: DCMTK

[Luis Ibanez]

On Thu, Apr 8, 2010 at 5:23 PM, Julien Finet <julien.finet at kitware.com> wrote:
> Hi Luis,
> In CTK/Utilities we have a local version of DCMTK that we cmakeified.
> My vote goes to fix the warnings into directly into the CTK repository.
> Julien.
>
----------------------------------------------------------------------------------------

That works too.

I just committed the fixes to:

CTK/Utilities/DCMTK/oflog/include/dcmtk/oflog/spi/logevent.h


We will avoid many problems if we agree on using a similar collection
of Warning flags for the machines that submit to the Dashboard.

For GCC we should at least have:

              -Wall -Wshadow -Wno-uninitialized



     Luis


---------------------------------------------------------------
> On Thu, Apr 8, 2010 at 5:14 PM, Luis Ibanez <luis.ibanez at kitware.com> wrote:
>>
>> In the process of cleaning up warnings in the Dashboard,
>> we ran into issues with DCMTK:
>>
>> CMakeExternals/Install/include/dcmtk/oflog/spi/logevent.h
>>
>>  warning: declaration of ‘message’ shadows a member of 'this'
>>  warning: declaration of ‘ll’ shadows a member of 'this'
>>
>>
>> Given that DCMTK is a third party library, our options for
>> fixing this are:
>>
>>
>> A) Post a patch to the DCMTK developers and wait for
>>     them to push that into a release
>>
>> B) Host a duplicate repository of DCMTK and make the
>>    patches there
>>
>> C) Silence the warning using CTestCustom.cmake
>>     (put the problem under the rug..)
>>
>>
>>
>>  What are your preferences ?
>>
>>
>>      Thanks
>>
>>
>>          Luis
>> _______________________________________________
>> Ctk-developers mailing list
>> Ctk-developers at commontk.org
>> http://public.kitware.com/cgi-bin/mailman/listinfo/ctk-developers
>
>