<div dir="ltr">Thanks for your persistence and the contribution, Christina! <div><br></div><div>The patch has been uploaded here:<div><br></div><div> <a href="http://review.source.kitware.com/#/c/21646/">http://review.source.kitware.com/#/c/21646/</a></div></div></div><div class="gmail_extra"><br><div class="gmail_quote">On Wed, Oct 19, 2016 at 10:35 AM, Chr. Rossmanith <span dir="ltr"><<a href="mailto:cr@neuro.ma.uni-heidelberg.de" target="_blank">cr@neuro.ma.uni-heidelberg.de</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div bgcolor="#FFFFFF" text="#000000">
<p>And now the copy for the ML</p>
<p>Christina<br>
</p>
<div class="m_-899292922231853293moz-forward-container"><br>
<br>
-------- Forwarded Message --------
<table class="m_-899292922231853293moz-email-headers-table" cellpadding="0" cellspacing="0" border="0">
<tbody>
<tr>
<th align="RIGHT" nowrap valign="BASELINE">Subject:
</th>
<td>Re: [ITK-users] Documentation:
itk::<wbr>AttributeSelectionLabelMapFilt<wbr>er</td>
</tr>
<tr>
<th align="RIGHT" nowrap valign="BASELINE">Date: </th>
<td>Wed, 19 Oct 2016 16:33:44 +0200</td>
</tr>
<tr>
<th align="RIGHT" nowrap valign="BASELINE">From: </th>
<td>Chr. Rossmanith <a class="m_-899292922231853293moz-txt-link-rfc2396E" href="mailto:cr@neuro.ma.uni-heidelberg.de" target="_blank"><cr@neuro.ma.uni-heidelberg.<wbr>de></a></td>
</tr>
<tr>
<th align="RIGHT" nowrap valign="BASELINE">To: </th>
<td>Matt McCormick <a class="m_-899292922231853293moz-txt-link-rfc2396E" href="mailto:matt.mccormick@kitware.com" target="_blank"><matt.mccormick@kitware.com></a></td>
</tr>
</tbody>
</table><div><div class="h5">
<br>
<br>
<pre>Hi Matt,
login is working now for <a href="http://reviews.source.kitware.com" target="_blank">reviews.source.kitware.com</a>, but authentication
on the command line fails, maybe because I'm behind a firewall. Now I'm
sending the patch to the mailing list as recommended on
<a class="m_-899292922231853293moz-txt-link-freetext" href="https://itk.org/Wiki/ITK/Git/Account#Gerrit" target="_blank">https://itk.org/Wiki/ITK/Git/<wbr>Account#Gerrit</a>
Christina
On 14.10.2016 18:55, Matt McCormick wrote:
> Hi Christina,
>
> Could you please try logging into to <a href="http://review.source.kitware.com" target="_blank">review.source.kitware.com</a> again?
>
> Thanks,
> Matt
>
> On Fri, Oct 14, 2016 at 9:21 AM, Chr. Rossmanith
> <a class="m_-899292922231853293moz-txt-link-rfc2396E" href="mailto:cr@neuro.ma.uni-heidelberg.de" target="_blank"><cr@neuro.ma.uni-heidelberg.<wbr>de></a> wrote:
>> When visiting <a href="http://review.source.kitware.com" target="_blank">review.source.kitware.com</a> -> sign in -> provide github
>> credentials I find myself on a page telling me "forbidden". But without a
>> gerrit user I'm stuck...Any hints? I've double checked the credentials by
>> signing in into github.
>>
>> Christina
>>
>>
>> On 14.10.2016 15:00, Dženan Zukić wrote:
>>
>> Hi Christina,
>>
>> gerrit is the only way to merge patches. Can you submit it as a patch to
>> gerrit?
>>
>> Thanks,
>> Dženan
>>
>> On Fri, Oct 14, 2016 at 8:52 AM, Chr. Rossmanith
>> <a class="m_-899292922231853293moz-txt-link-rfc2396E" href="mailto:cr@neuro.ma.uni-heidelberg.de" target="_blank"><cr@neuro.ma.uni-heidelberg.<wbr>de></a> wrote:
>>> Hi Matt,
>>>
>>> I've forked on github, extended the documentation and created a pull
>>> request. Or is gerrit the only way to get a patch merged?
>>>
>>> Christina
>>>
>>>
>>>
>>> On 12.10.2016 18:03, Matt McCormick wrote:
>>>> Hello Christina,
>>>>
>>>> Good idea.
>>>>
>>>> To update the documentation, the class Doxygen documentation can be
>>>> editted:
>>>>
>>>>
>>>> <a class="m_-899292922231853293moz-txt-link-freetext" href="https://github.com/InsightSoftwareConsortium/ITK/blob/master/Modules/Filtering/LabelMap/include/itkAttributeSelectionLabelMapFilter.h#L27-L46" target="_blank">https://github.com/<wbr>InsightSoftwareConsortium/ITK/<wbr>blob/master/Modules/Filtering/<wbr>LabelMap/include/<wbr>itkAttributeSelectionLabelMapF<wbr>ilter.h#L27-L46</a>
>>>>
>>>> and after a patch is submitted:
>>>>
>>>> <a class="m_-899292922231853293moz-txt-link-freetext" href="https://itk.org/Wiki/ITK/Git/Develop" target="_blank">https://itk.org/Wiki/ITK/Git/<wbr>Develop</a>
>>>>
>>>> it will show up on the Doxygen web pages.
>>>>
>>>> Please let us know if you have any questions.
>>>>
>>>> Thanks,
>>>> Matt
>>>>
>>>> On Wed, Oct 12, 2016 at 11:57 AM, Chr. Rossmanith
>>>> <a class="m_-899292922231853293moz-txt-link-rfc2396E" href="mailto:cr@neuro.ma.uni-heidelberg.de" target="_blank"><cr@neuro.ma.uni-heidelberg.<wbr>de></a> wrote:
>>>>> Hi,
>>>>>
>>>>> I think it would be helpful if the documentation of the filter would
>>>>> mention
>>>>> that there are two outputs, one with the surviving labels and the second
>>>>> with the removed labels (the input image is the union of these images).
>>>>> What
>>>>> is the workflow to achieve this?
>>>>>
>>>>> Christina
>>>>>
>>>>> ______________________________<wbr>_______
>>>>> Powered by <a class="m_-899292922231853293moz-txt-link-abbreviated" href="http://www.kitware.com" target="_blank">www.kitware.com</a>
>>>>>
>>>>> Visit other Kitware open-source projects at
>>>>> <a class="m_-899292922231853293moz-txt-link-freetext" href="http://www.kitware.com/opensource/opensource.html" target="_blank">http://www.kitware.com/<wbr>opensource/opensource.html</a>
>>>>>
>>>>> Kitware offers ITK Training Courses, for more information visit:
>>>>> <a class="m_-899292922231853293moz-txt-link-freetext" href="http://www.kitware.com/products/protraining.php" target="_blank">http://www.kitware.com/<wbr>products/protraining.php</a>
>>>>>
>>>>> Please keep messages on-topic and check the ITK FAQ at:
>>>>> <a class="m_-899292922231853293moz-txt-link-freetext" href="http://www.itk.org/Wiki/ITK_FAQ" target="_blank">http://www.itk.org/Wiki/ITK_<wbr>FAQ</a>
>>>>>
>>>>> Follow this link to subscribe/unsubscribe:
>>>>> <a class="m_-899292922231853293moz-txt-link-freetext" href="http://public.kitware.com/mailman/listinfo/insight-users" target="_blank">http://public.kitware.com/<wbr>mailman/listinfo/insight-users</a>
>>>
>>>
>>> ______________________________<wbr>_______
>>> Powered by <a class="m_-899292922231853293moz-txt-link-abbreviated" href="http://www.kitware.com" target="_blank">www.kitware.com</a>
>>>
>>> Visit other Kitware open-source projects at
>>> <a class="m_-899292922231853293moz-txt-link-freetext" href="http://www.kitware.com/opensource/opensource.html" target="_blank">http://www.kitware.com/<wbr>opensource/opensource.html</a>
>>>
>>> Kitware offers ITK Training Courses, for more information visit:
>>> <a class="m_-899292922231853293moz-txt-link-freetext" href="http://www.kitware.com/products/protraining.php" target="_blank">http://www.kitware.com/<wbr>products/protraining.php</a>
>>>
>>> Please keep messages on-topic and check the ITK FAQ at:
>>> <a class="m_-899292922231853293moz-txt-link-freetext" href="http://www.itk.org/Wiki/ITK_FAQ" target="_blank">http://www.itk.org/Wiki/ITK_<wbr>FAQ</a>
>>>
>>> Follow this link to subscribe/unsubscribe:
>>> <a class="m_-899292922231853293moz-txt-link-freetext" href="http://public.kitware.com/mailman/listinfo/insight-users" target="_blank">http://public.kitware.com/<wbr>mailman/listinfo/insight-users</a>
>>
>>
>>
>> ______________________________<wbr>_______
>> Powered by <a class="m_-899292922231853293moz-txt-link-abbreviated" href="http://www.kitware.com" target="_blank">www.kitware.com</a>
>>
>> Visit other Kitware open-source projects at
>> <a class="m_-899292922231853293moz-txt-link-freetext" href="http://www.kitware.com/opensource/opensource.html" target="_blank">http://www.kitware.com/<wbr>opensource/opensource.html</a>
>>
>> Kitware offers ITK Training Courses, for more information visit:
>> <a class="m_-899292922231853293moz-txt-link-freetext" href="http://www.kitware.com/products/protraining.php" target="_blank">http://www.kitware.com/<wbr>products/protraining.php</a>
>>
>> Please keep messages on-topic and check the ITK FAQ at:
>> <a class="m_-899292922231853293moz-txt-link-freetext" href="http://www.itk.org/Wiki/ITK_FAQ" target="_blank">http://www.itk.org/Wiki/ITK_<wbr>FAQ</a>
>>
>> Follow this link to subscribe/unsubscribe:
>> <a class="m_-899292922231853293moz-txt-link-freetext" href="http://public.kitware.com/mailman/listinfo/insight-users" target="_blank">http://public.kitware.com/<wbr>mailman/listinfo/insight-users</a>
>>
</pre>
</div></div></div>
</div>
<br>______________________________<wbr>_______<br>
Powered by <a href="http://www.kitware.com" rel="noreferrer" target="_blank">www.kitware.com</a><br>
<br>
Visit other Kitware open-source projects at<br>
<a href="http://www.kitware.com/opensource/opensource.html" rel="noreferrer" target="_blank">http://www.kitware.com/<wbr>opensource/opensource.html</a><br>
<br>
Kitware offers ITK Training Courses, for more information visit:<br>
<a href="http://www.kitware.com/products/protraining.php" rel="noreferrer" target="_blank">http://www.kitware.com/<wbr>products/protraining.php</a><br>
<br>
Please keep messages on-topic and check the ITK FAQ at:<br>
<a href="http://www.itk.org/Wiki/ITK_FAQ" rel="noreferrer" target="_blank">http://www.itk.org/Wiki/ITK_<wbr>FAQ</a><br>
<br>
Follow this link to subscribe/unsubscribe:<br>
<a href="http://public.kitware.com/mailman/listinfo/insight-users" rel="noreferrer" target="_blank">http://public.kitware.com/<wbr>mailman/listinfo/insight-users</a><br>
<br></blockquote></div><br></div>