<div dir="ltr"><div class="gmail_default" style="font-family:verdana,sans-serif;font-size:small">Hi Somesh,</div><div class="gmail_default" style="font-family:verdana,sans-serif;font-size:small"><br></div><div class="gmail_default" style="font-family:verdana,sans-serif;font-size:small">maybe ITK's hook is picking up a different version of uncrustify from what you think it is using. Check how many uncrustify executables there are on your machine, especially in ITK's source tree.</div><div class="gmail_default" style="font-family:verdana,sans-serif;font-size:small"><br></div><div class="gmail_default" style="font-family:verdana,sans-serif;font-size:small">Regards,</div><div class="gmail_default" style="font-family:verdana,sans-serif;font-size:small">Dženan</div></div><div class="gmail_extra"><br><div class="gmail_quote">On Wed, Sep 14, 2016 at 7:05 PM, Somesh <span dir="ltr"><<a href="mailto:someshsandbox@gmail.com" target="_blank">someshsandbox@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">Hi Dženan,<div>You are right. I accidentally sent you the wrong commit info. I use homebrew package manager for mac and I accidentally sent you the commit ID of homebrew commit instead of uncrustify. See <a href="https://github.com/Homebrew/brew/commit/5a264cf59733fa8e0f69f8e6567e069a8cfd8bde" target="_blank">https://github.com/<wbr>Homebrew/brew/commit/<wbr>5a264cf59733fa8e0f69f8e6567e06<wbr>9a8cfd8bde</a> . My apologies :)</div><div>However it seems I have correct version of uncrustify. Looking into the uncrustify remotes that I have installed, this is what I am using:</div><div>
<p><span>origin<span> </span><a href="https://github.com/uncrustify/uncrustify.git" target="_blank">https://github.com/uncrustify/<wbr>uncrustify.git</a> (fetch)<br></span>origin<span> </span><a href="https://github.com/uncrustify/uncrustify.git" target="_blank">https://github.com/uncrustify/<wbr>uncrustify.git</a> (push)</p><p>With the last 5 commits as:</p><p></p><ul><li><span>5d703fa01ff67afc029f31a5ac36bd<wbr>2fbafb6aea</span><span> Merge pull request #756 from Unity-Technologies/fixes/make_<wbr>version_with_cmake</span><br></li><li><span>bc2b0c3e0c5b485cabbbcefcfb1eee<wbr>76dbd62356</span><span> removed cmake dependency on autotools and directly use make_version.py</span><br></li><li><span>ac79e4081241359bdf3eec42baca69<wbr>0776ab565f</span><span> make_version.py will be used only to retrieve the version from the VCS.</span><br></li><li><span>3ef03cd6ac3fe218e77f14336e7c17<wbr>daf75ba551</span><span> fixed instability retrieving the version when under hg-git</span><br></li><li><span>d9b0253f2d89c3556704bd45145d5b<wbr>d4108f1043</span><span> Merge pull request #661 from uncrustify/NewLineProt</span><br></li></ul><p></p><p>
</p><p><span><br></span></p><p><span>I can take a look into why its not working for me in the weekend.<br><br>Thanks,<br></span>Somesh</p><p><span><br></span></p></div></div><div class="HOEnZb"><div class="h5"><div class="gmail_extra"><br><div class="gmail_quote">On Wed, Sep 14, 2016 at 4:04 PM, Dženan Zukić <span dir="ltr"><<a href="mailto:dzenanz@gmail.com" target="_blank">dzenanz@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><div class="gmail_default" style="font-family:verdana,sans-serif;font-size:small">Hi Somesh,</div><div class="gmail_default" style="font-family:verdana,sans-serif;font-size:small"><br></div><div class="gmail_default" style="font-family:verdana,sans-serif;font-size:small">I just pulled master version of uncrustify, the last commit is on 10th (you have a commit on 12th!):</div><div class="gmail_default"><div class="gmail_default"><font face="verdana, sans-serif">Revision: 5d703fa01ff67afc029f31a5ac36bd<wbr>2fbafb6aea</font></div><div class="gmail_default"><font face="verdana, sans-serif">Author: gmaurel <<a href="mailto:guy.j@maurel.de" target="_blank">guy.j@maurel.de</a>></font></div><div class="gmail_default"><font face="verdana, sans-serif">Date: 2016-09-10 15:06:05</font></div><div class="gmail_default"><font face="verdana, sans-serif">Message: </font><span style="font-family:verdana,sans-serif">Merge pull request #756 from Unity-Technologies/fixes/make_<wbr>version_with_cmake</span></div><div class="gmail_default"><br></div></div><div class="gmail_default" style="font-family:verdana,sans-serif;font-size:small">I must conclude that you are using somebody's fork of uncrustify, not HEAD from the official repository. Can you verify this?</div><div class="gmail_default" style="font-family:verdana,sans-serif;font-size:small"><br></div><div class="gmail_default" style="font-family:verdana,sans-serif;font-size:small">Regards,</div><div class="gmail_default" style="font-family:verdana,sans-serif;font-size:small">Dženan</div><div><div><div class="gmail_extra"><br><div class="gmail_quote">On Mon, Sep 12, 2016 at 10:17 PM, Dženan Zukić <span dir="ltr"><<a href="mailto:dzenanz@gmail.com" target="_blank">dzenanz@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><p dir="ltr">It is not required.</p>
<p dir="ltr">Dženan@phone</p><div><div>
<div class="gmail_extra"><br><div class="gmail_quote">On Sep 12, 2016 22:15, "Somesh" <<a href="mailto:someshsandbox@gmail.com" target="_blank">someshsandbox@gmail.com</a>> wrote:<br type="attribution"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">Is running uncrustify hooks a required process in the ITK development workflow or can I disable it if I have to submit a patch ?<div><br></div><div>Thanks,</div><div>Somesh</div></div><div class="gmail_extra"><br><div class="gmail_quote">On Mon, Sep 12, 2016 at 9:30 PM, Somesh <span dir="ltr"><<a href="mailto:someshsandbox@gmail.com" target="_blank">someshsandbox@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">Hi <span style="font-size:12.8px">Dženan,</span><div>I am using the HEAD of master uncrustify. The last commit to this repo was made today.</div><div>
<p><span>commit 5a264cf59733fa8e0f69f8e6567e06<wbr>9a8cfd8bde<br></span>Merge: 553ef05 8ce4ca1<br>Author: Zhiming Wang <<a href="mailto:zmwangx@gmail.com" target="_blank">zmwangx@gmail.com</a>><br>Date: Mon Sep 12 10:22:27 2016 -0400</p><p>I have build from source using brew for mac.<br></p><p>Also my mergetool/difftool are all set. I am using OS X El Captain 10.11.6 and kaleidoscope tool for mac <a href="http://www.kaleidoscopeapp.com/" target="_blank">http://www.kaleidoscopeapp<wbr>.com/</a>.</p><p>Thanks,<br>Somesh</p></div></div><div><div><div class="gmail_extra"><br><div class="gmail_quote">On Mon, Sep 12, 2016 at 9:11 PM, Dzenan Zukic <span dir="ltr"><<a href="mailto:dzenan.zukic@kitware.com" target="_blank">dzenan.zukic@kitware.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><div>Hi Somesh,</div><div><br></div><div>You need a recent master version (2016-08-26 or newer) which you can build yourself from source available on <a href="https://github.com/uncrustify/uncrustify" target="_blank">GitHub</a>.</div><div><br></div>Also, you need to have merge tool set. On Windows kdiff3 works well but TortoiseMerge doesn't.<div><br></div><div>Regards,</div><div>Dženan Zukić, PhD, Senior R&D Engineer,<span style="font-size:12.8px"> </span>Kitware (Carrboro, N.C.)<br></div><div><div><div class="gmail_extra">
<br><div class="gmail_quote">On Mon, Sep 12, 2016 at 9:03 PM, Somesh <span dir="ltr"><<a href="mailto:someshsandbox@gmail.com" target="_blank">someshsandbox@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">Hi Matt,<div>Do KWStyle and <span style="font-size:12.8px">uncrustify play well with both enabled ?</span></div><div><span style="font-size:12.8px">I have </span> <span style="font-size:12.8px">uncrustify version </span>0.63 and the prehooks still fail. I believe 0.63 is the latest uncrustify version: <a href="https://github.com/uncrustify/uncrustify/blob/master/CMakeLists.txt#L124" target="_blank">https://github.com/un<wbr>crustify/uncrustify/blob/maste<wbr>r/CMakeLists.txt#L124</a></div><div><br></div><div>Thanks,</div><div>Somesh</div>
</div><div><div><div class="gmail_extra"><br><div class="gmail_quote">On Mon, Sep 12, 2016 at 5:12 PM, Matt McCormick <span dir="ltr"><<a href="mailto:matt.mccormick@kitware.com" target="_blank">matt.mccormick@kitware.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Hi Somesh,<br>
<br>
Yes, Dzenan recently improved upstream uncrustify and its<br>
configuration in ITK so it works much better. A newer version of<br>
uncrustify is required as described here:<br>
<br>
<a href="https://github.com/InsightSoftwareConsortium/ITK/blob/6ee10575445aa1c878797db4febf7d775a38f1f3/Utilities/DevelopmentSetupScripts/GitTips.sh#L66-L74" rel="noreferrer" target="_blank">https://github.com/InsightSoft<wbr>wareConsortium/ITK/blob/6ee105<wbr>75445aa1c878797db4febf7d775a38<wbr>f1f3/Utilities/DevelopmentSetu<wbr>pScripts/GitTips.sh#L66-L74</a><br>
<br>
Thanks,<br>
Matt<br>
<div><div><br>
On Mon, Sep 12, 2016 at 2:49 PM, Somesh <<a href="mailto:someshsandbox@gmail.com" target="_blank">someshsandbox@gmail.com</a>> wrote:<br>
> Hi,<br>
> I recently set up a ITK dev on my mac. While commiting a patch locally, I am<br>
> getting failure in precommit hooks. Specifically uncrustify is giving the<br>
> following errors. Do I have to install a specific version of<br>
> uncrustify/python ? I installed uncrustify using brew.<br>
><br>
> ./Utilities/Maintenance/uncrus<wbr>tify_itk.cfg:99 Unknown symbol<br>
> 'indent_cs_delegate_brace'<br>
><br>
> ./Utilities/Maintenance/uncrus<wbr>tify_itk.cfg:287 Unknown symbol<br>
> 'indent_token_after_brace'<br>
><br>
> ./Utilities/Maintenance/uncrus<wbr>tify_itk.cfg:290 Unknown symbol<br>
> 'indent_cpp_lambda_body'<br>
><br>
> ./Utilities/Maintenance/uncrus<wbr>tify_itk.cfg:424 Unknown symbol<br>
> 'sp_angle_paren_empty'<br>
><br>
> ./Utilities/Maintenance/uncrus<wbr>tify_itk.cfg:533 Unknown symbol<br>
> 'sp_after_operator_sym_empty'<br>
><br>
> ./Utilities/Maintenance/uncrus<wbr>tify_itk.cfg:570 Unknown symbol<br>
> 'sp_func_proto_paren_empty'<br>
><br>
> ./Utilities/Maintenance/uncrus<wbr>tify_itk.cfg:576 Unknown symbol<br>
> 'sp_func_def_paren_empty'<br>
><br>
> ./Utilities/Maintenance/uncrus<wbr>tify_itk.cfg:614 Unknown symbol<br>
> 'sp_func_class_paren_empty'<br>
><br>
> ./Utilities/Maintenance/uncrus<wbr>tify_itk.cfg:644 Unknown symbol<br>
> 'sp_super_paren'<br>
><br>
> ./Utilities/Maintenance/uncrus<wbr>tify_itk.cfg:647 Unknown symbol<br>
> 'sp_this_paren'<br>
><br>
> ./Utilities/Maintenance/uncrus<wbr>tify_itk.cfg:851 Unknown symbol<br>
> 'sp_skip_vbrace_tokens'<br>
><br>
> ./Utilities/Maintenance/uncrus<wbr>tify_itk.cfg:922 Unknown symbol<br>
> 'align_var_class_span'<br>
><br>
> ./Utilities/Maintenance/uncrus<wbr>tify_itk.cfg:925 Unknown symbol<br>
> 'align_var_class_thresh'<br>
><br>
> ./Utilities/Maintenance/uncrus<wbr>tify_itk.cfg:928 Unknown symbol<br>
> 'align_var_class_gap'<br>
><br>
> ./Utilities/Maintenance/uncrus<wbr>tify_itk.cfg:1068 Unknown symbol<br>
> 'nl_oc_block_brace'<br>
><br>
> ./Utilities/Maintenance/uncrus<wbr>tify_itk.cfg:1245 Unknown symbol<br>
> 'nl_enum_own_lines'<br>
><br>
> ./Utilities/Maintenance/uncrus<wbr>tify_itk.cfg:1256 Unknown symbol<br>
> 'nl_func_class_scope'<br>
><br>
> ./Utilities/Maintenance/uncrus<wbr>tify_itk.cfg:1284 Unknown symbol<br>
> 'nl_func_decl_start_multi_line<wbr>'<br>
><br>
> ./Utilities/Maintenance/uncrus<wbr>tify_itk.cfg:1287 Unknown symbol<br>
> 'nl_func_def_start_multi_line'<br>
><br>
> ./Utilities/Maintenance/uncrus<wbr>tify_itk.cfg:1296 Unknown symbol<br>
> 'nl_func_decl_args_multi_line'<br>
><br>
> ./Utilities/Maintenance/uncrus<wbr>tify_itk.cfg:1299 Unknown symbol<br>
> 'nl_func_def_args_multi_line'<br>
><br>
> ./Utilities/Maintenance/uncrus<wbr>tify_itk.cfg:1314 Unknown symbol<br>
> 'nl_func_decl_end_multi_line'<br>
><br>
> ./Utilities/Maintenance/uncrus<wbr>tify_itk.cfg:1317 Unknown symbol<br>
> 'nl_func_def_end_multi_line'<br>
><br>
> ./Utilities/Maintenance/uncrus<wbr>tify_itk.cfg:1326 Unknown symbol<br>
> 'nl_func_call_start_multi_line<wbr>'<br>
><br>
> ./Utilities/Maintenance/uncrus<wbr>tify_itk.cfg:1329 Unknown symbol<br>
> 'nl_func_call_args_multi_line'<br>
><br>
> ./Utilities/Maintenance/uncrus<wbr>tify_itk.cfg:1332 Unknown symbol<br>
> 'nl_func_call_end_multi_line'<br>
><br>
> ./Utilities/Maintenance/uncrus<wbr>tify_itk.cfg:1388 Unknown symbol<br>
> 'nl_squeeze_ifdef_top_level'<br>
><br>
> ./Utilities/Maintenance/uncrus<wbr>tify_itk.cfg:1461 Unknown symbol<br>
> 'nl_split_if_one_liner'<br>
><br>
> ./Utilities/Maintenance/uncrus<wbr>tify_itk.cfg:1465 Unknown symbol<br>
> 'nl_split_for_one_liner'<br>
><br>
> ./Utilities/Maintenance/uncrus<wbr>tify_itk.cfg:1469 Unknown symbol<br>
> 'nl_split_while_one_liner'<br>
><br>
> ./Utilities/Maintenance/uncrus<wbr>tify_itk.cfg:1541 Unknown symbol<br>
> 'nl_after_func_class_proto'<br>
><br>
> ./Utilities/Maintenance/uncrus<wbr>tify_itk.cfg:1544 Unknown symbol<br>
> 'nl_after_func_class_proto_gro<wbr>up'<br>
><br>
> ./Utilities/Maintenance/uncrus<wbr>tify_itk.cfg:1662 Unknown symbol<br>
> 'mod_full_brace_if_chain_only'<br>
><br>
> ./Utilities/Maintenance/uncrus<wbr>tify_itk.cfg:1781 Unknown symbol<br>
> 'cmt_multi_first_len_minimum'<br>
><br>
> ./Utilities/Maintenance/uncrus<wbr>tify_itk.cfg:1812 Unknown symbol<br>
> 'cmt_insert_before_inlines'<br>
><br>
> ./Utilities/Maintenance/uncrus<wbr>tify_itk.cfg:1817 Unknown symbol<br>
> 'cmt_insert_before_ctor_dtor'<br>
><br>
> ./Utilities/Maintenance/uncrus<wbr>tify_itk.cfg:1878 Unknown symbol<br>
> 'use_options_overriding_for_qt<wbr>_macros'<br>
><br>
> ./Utilities/Maintenance/uncrus<wbr>tify_itk.cfg:1885 Unknown symbol<br>
> 'warn_level_tabs_found_in_verb<wbr>atim_string_literals'<br>
><br>
><br>
> Thanks,<br>
> Somesh<br>
><br>
><br>
</div></div>> ______________________________<wbr>_________________<br>
> Powered by <a href="http://www.kitware.com" rel="noreferrer" target="_blank">www.kitware.com</a><br>
><br>
> Visit other Kitware open-source projects at<br>
> <a href="http://www.kitware.com/opensource/opensource.html" rel="noreferrer" target="_blank">http://www.kitware.com/opensou<wbr>rce/opensource.html</a><br>
><br>
> Kitware offers ITK Training Courses, for more information visit:<br>
> <a href="http://kitware.com/products/protraining.php" rel="noreferrer" target="_blank">http://kitware.com/products/pr<wbr>otraining.php</a><br>
><br>
> Please keep messages on-topic and check the ITK FAQ at:<br>
> <a href="http://www.itk.org/Wiki/ITK_FAQ" rel="noreferrer" target="_blank">http://www.itk.org/Wiki/ITK_FA<wbr>Q</a><br>
><br>
> Follow this link to subscribe/unsubscribe:<br>
> <a href="http://public.kitware.com/mailman/listinfo/insight-developers" rel="noreferrer" target="_blank">http://public.kitware.com/mail<wbr>man/listinfo/insight-developer<wbr>s</a><br>
><br>
</blockquote></div><br></div>
</div></div></blockquote></div><br></div></div></div></div>
</blockquote></div><br></div>
</div></div></blockquote></div><br></div>
<br>______________________________<wbr>_________________<br>
Powered by <a href="http://www.kitware.com" rel="noreferrer" target="_blank">www.kitware.com</a><br>
<br>
Visit other Kitware open-source projects at<br>
<a href="http://www.kitware.com/opensource/opensource.html" rel="noreferrer" target="_blank">http://www.kitware.com/opensou<wbr>rce/opensource.html</a><br>
<br>
Kitware offers ITK Training Courses, for more information visit:<br>
<a href="http://kitware.com/products/protraining.php" rel="noreferrer" target="_blank">http://kitware.com/products/pr<wbr>otraining.php</a><br>
<br>
Please keep messages on-topic and check the ITK FAQ at:<br>
<a href="http://www.itk.org/Wiki/ITK_FAQ" rel="noreferrer" target="_blank">http://www.itk.org/Wiki/ITK_FA<wbr>Q</a><br>
<br>
Follow this link to subscribe/unsubscribe:<br>
<a href="http://public.kitware.com/mailman/listinfo/insight-developers" rel="noreferrer" target="_blank">http://public.kitware.com/mail<wbr>man/listinfo/insight-developer<wbr>s</a><br>
<br></blockquote></div></div>
</div></div></blockquote></div><br></div></div></div></div>
</blockquote></div><br></div>
</div></div></blockquote></div><br></div>