<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=us-ascii">
</head>
<body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class="">
Nice! Thank you for your contribution.
<div class=""><br class="">
</div>
<div class="">There is already a patch out for the HDF5 issue here: <a href="http://review.source.kitware.com/#/c/21231/" class="">http://review.source.kitware.com/#/c/21231/</a></div>
<div class=""><br class="">
</div>
<div class="">You could checkout that patch out, test it and review it, to ensure it addresses your issue.</div>
<div class=""><br class="">
</div>
<div class="">Thanks,</div>
<div class="">Brad</div>
<div class=""><br class="">
</div>
<div class=""><br class="">
<div>
<blockquote type="cite" class="">
<div class="">On Jun 17, 2016, at 5:21 AM, Pierre Barbier de Reuille <<a href="mailto:pierre.barbierdereuille@gmail.com" class="">pierre.barbierdereuille@gmail.com</a>> wrote:</div>
<br class="Apple-interchange-newline">
<div class="">
<div dir="ltr" style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;" class="">
<div class="">
<div class="">
<div class="">
<div class="">Hello,<br class="">
<br class="">
</div>
sorry for the delay, but it took a while to test everything correctly. So I created a topic called fix_fftwf_used_with_fftwd and made the modification.<br class="">
</div>
I tested it with the FFTW compiled by ITK itself and all FFTW-related tests passed without problem. There are some tests failing, but they are unrelated to the modification. For completeness, here is the list of tests that failed:<br class="">
<br class="">
The following tests FAILED:<br class="">
79 - vnl_algo_test_convolve (Failed)<br class="">
824 - itkHDF5ImageIOTest (Failed)<br class="">
825 - itkHDF5ImageIOStreamingReadWriteTest (Failed)<br class="">
1177 - itkCastImageFilterTest (Failed)<br class="">
<br class="">
</div>
Cheers,<br class="">
<br class="">
</div>
Pierre<br class="">
</div>
<br style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;" class="">
<div class="gmail_quote" style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;">
<div dir="ltr" class="">On Wed, 15 Jun 2016 at 20:35 Bradley Lowekamp <<a href="mailto:blowekamp@mail.nih.gov" class="">blowekamp@mail.nih.gov</a>> wrote:<br class="">
</div>
<blockquote class="gmail_quote" style="margin: 0px 0px 0px 0.8ex; border-left-width: 1px; border-left-color: rgb(204, 204, 204); border-left-style: solid; padding-left: 1ex;">
<div style="word-wrap: break-word;" class="">Hello,
<div class=""><br class="">
</div>
<div class="">Looks like you found a bug!</div>
<div class=""><br class="">
</div>
<div class="">Can you please test the change and submit a patch for review?</div>
<div class=""><a href="https://itk.org/Wiki/ITK/Git/Develop" target="_blank" class="">https://itk.org/Wiki/ITK/Git/Develop</a></div>
<div class=""><br class="">
</div>
<div class="">Thanks,</div>
<div class="">Brad</div>
<div class="">
<div class=""><br class="">
<div class="">
<blockquote type="cite" class=""></blockquote>
</div>
</div>
</div>
</div>
<div style="word-wrap: break-word;" class="">
<div class="">
<div class="">
<div class="">
<blockquote type="cite" class="">
<div class="">On Jun 15, 2016, at 9:36 AM, Pierre Barbier de Reuille <<a href="mailto:pierre.barbierdereuille@gmail.com" target="_blank" class="">pierre.barbierdereuille@gmail.com</a>> wrote:</div>
<br class="">
</blockquote>
</div>
</div>
</div>
</div>
<div style="word-wrap: break-word;" class="">
<div class="">
<div class="">
<div class="">
<blockquote type="cite" class="">
<div class="">
<div dir="ltr" class="">
<div class="">
<div dir="ltr" class="">
<div class="">
<div class="">
<div class="">Hey,<br class="">
<br class="">
</div>
I just compiled the latest version of ITK (4.10.0) with MinGW under windows and I had a problem.<br class="">
<br class="">
I compiled it with FFTW compiled with double precision, but in the file Module/Filtering/FFT/src/itkFFTWGlobalConfiguration.cxx the function fftwf_import_wisdom_from_file is used twice when fftw_import_wisdom_from_file should be used: on lines 632 and 709.<br class="">
<br class="">
</div>
<div class="">Otherwise, everything compiled just fine.<br class="">
</div>
<div class=""><br class="">
</div>
Cheers,<br class="">
<br class="">
</div>
Pierre<br class="">
<div class="">
<div class="">
<div class=""><br class="">
</div>
</div>
</div>
</div>
</div>
</div>
<div dir="ltr" class="">--<span class="Apple-converted-space"> </span><br class="">
</div>
<div data-smartmail="gmail_signature" class="">
<div dir="ltr" class="">
<p dir="ltr" class="">Dr. Barbier de Reuille, Pierre<br class="">
Institute of Plant Sciences<br class="">
University of Bern<br class="">
Altenbergrain 21, CH-3013 Bern, Switzerland</p>
</div>
</div>
</div>
</blockquote>
</div>
</div>
</div>
</div>
<div style="word-wrap: break-word;" class="">
<div class="">
<div class="">
<div class="">
<blockquote type="cite" class="">
<div class="">_______________________________________________<br class="">
Powered by<span class="Apple-converted-space"> </span><a href="http://www.kitware.com/" target="_blank" class="">www.kitware.com</a><br class="">
<br class="">
Visit other Kitware open-source projects at<br class="">
<a href="http://www.kitware.com/opensource/opensource.html" target="_blank" class="">http://www.kitware.com/opensource/opensource.html</a><br class="">
<br class="">
Kitware offers ITK Training Courses, for more information visit:<br class="">
<a href="http://kitware.com/products/protraining.php" target="_blank" class="">http://kitware.com/products/protraining.php</a><br class="">
<br class="">
Please keep messages on-topic and check the ITK FAQ at:<br class="">
<a href="http://www.itk.org/Wiki/ITK_FAQ" target="_blank" class="">http://www.itk.org/Wiki/ITK_FAQ</a><br class="">
<br class="">
Follow this link to subscribe/unsubscribe:<br class="">
<a href="http://public.kitware.com/mailman/listinfo/insight-developers" target="_blank" class="">http://public.kitware.com/mailman/listinfo/insight-developers</a><br class="">
</div>
</blockquote>
</div>
<br class="">
</div>
</div>
</div>
</blockquote>
</div>
<div dir="ltr" style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;" class="">
--<span class="Apple-converted-space"> </span><br class="">
</div>
<div data-smartmail="gmail_signature" style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;" class="">
<div dir="ltr" class="">
<p dir="ltr" class="">Dr. Barbier de Reuille, Pierre<br class="">
Institute of Plant Sciences<br class="">
University of Bern<br class="">
Altenbergrain 21, CH-3013 Bern, Switzerland</p>
</div>
</div>
</div>
</blockquote>
</div>
<br class="">
</div>
</body>
</html>