<div dir="ltr">I had already done that, the problem was elsewhere but I have now sorted it.<div><br></div><div>Issue is 20301.</div><div><br></div><div>I added Matt as reviewer but couldn't find Dzenan in the system.</div><div><br></div><div><br></div></div><br><div class="gmail_quote"><div dir="ltr">On Tue, 10 Nov 2015 at 11:59 Matt McCormick <<a href="mailto:matt.mccormick@kitware.com">matt.mccormick@kitware.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Hi Simon,<br>
<br>
Great!<br>
<br>
You should be able to sign up for Gerrit, then add your SSH key to<br>
your account and push. Instructions are here:<br>
<br>
<a href="https://cmake.org/Wiki/ITK/Git/Account#Gerrit" rel="noreferrer" target="_blank">https://cmake.org/Wiki/ITK/Git/Account#Gerrit</a><br>
<br>
Please let us know if you have any issues.<br>
<br>
Thanks,<br>
Matt<br>
<br>
On Tue, Nov 10, 2015 at 11:35 AM, Simon Alexander <<a href="mailto:skalexander@gmail.com" target="_blank">skalexander@gmail.com</a>> wrote:<br>
> Ok, I have a patch ready off the release branch.<br>
><br>
> I don't think I have push access for gerrit though, is there a way to just<br>
> start a review from a patch that I am missing in the linked docs?<br>
><br>
> On Mon, 9 Nov 2015 at 17:08 Matt McCormick <<a href="mailto:matt.mccormick@kitware.com" target="_blank">matt.mccormick@kitware.com</a>><br>
> wrote:<br>
>><br>
>> Great!<br>
>><br>
>> Instructions can be found here:<br>
>><br>
>> <a href="http://www.itk.org/Wiki/ITK/Git" rel="noreferrer" target="_blank">http://www.itk.org/Wiki/ITK/Git</a><br>
>><br>
>> Please branch off of the "release" branch.<br>
>><br>
>> Thanks,<br>
>> Matt<br>
>><br>
>> On Mon, Nov 9, 2015 at 4:40 PM, Simon Alexander <<a href="mailto:skalexander@gmail.com" target="_blank">skalexander@gmail.com</a>><br>
>> wrote:<br>
>> > Ok, I'll dig up my notes on how to do that and submit it shortly. Should<br>
>> > this be done against trunk or a release branch ?<br>
>> ><br>
>> > On Mon, 9 Nov 2015 at 16:19 Matt McCormick <<a href="mailto:matt.mccormick@kitware.com" target="_blank">matt.mccormick@kitware.com</a>><br>
>> > wrote:<br>
>> >><br>
>> >> Thanks for the patch, Simon! Yes, we can wait until this patch is<br>
>> >> merged to make the release. As Dzenan recommends, please submit the<br>
>> >> patch to Gerrit with a verification for<br>
>> >> itk::TriangleCell::EvaluatePosition in itkTriangleCellTest.cxx.<br>
>> >><br>
>> >> Thanks,<br>
>> >> Matt<br>
>> >><br>
>> >> On Mon, Nov 9, 2015 at 3:54 PM, Dženan Zukić <<a href="mailto:dzenanz@gmail.com" target="_blank">dzenanz@gmail.com</a>> wrote:<br>
>> >> > Better submit the usual way. I doubt Matt will include it without the<br>
>> >> > usual<br>
>> >> > testing. Add me and Matt as reviewers.<br>
>> >> ><br>
>> >> > Regards,<br>
>> >> > Dženan<br>
>> >> ><br>
>> >> > On Mon, Nov 9, 2015 at 3:18 PM, Simon Alexander<br>
>> >> > <<a href="mailto:skalexander@gmail.com" target="_blank">skalexander@gmail.com</a>><br>
>> >> > wrote:<br>
>> >> >><br>
>> >> >> We found this today (patch attached). If 4.8.2 is right around the<br>
>> >> >> corner, can you consider it for inclusion. If time isn't so short,<br>
>> >> >> I'll<br>
>> >> >> submit the usual way....<br>
>> >> >><br>
>> >> >> cheers,<br>
>> >> >> Simon<br>
>> >> >><br>
>> >> >><br>
>> >> >><br>
>> >> >> On Mon, 9 Nov 2015 at 09:57 Matt McCormick<br>
>> >> >> <<a href="mailto:matt.mccormick@kitware.com" target="_blank">matt.mccormick@kitware.com</a>><br>
>> >> >> wrote:<br>
>> >> >>><br>
>> >> >>> Thanks! Added.<br>
>> >> >>><br>
>> >> >>> On Mon, Nov 9, 2015 at 9:45 AM, Bradley Lowekamp<br>
>> >> >>> <<a href="mailto:blowekamp@mail.nih.gov" target="_blank">blowekamp@mail.nih.gov</a>><br>
>> >> >>> wrote:<br>
>> >> >>> > We should consider this:<br>
>> >> >>> > <a href="http://review.source.kitware.com/#/c/20369/" rel="noreferrer" target="_blank">http://review.source.kitware.com/#/c/20369/</a><br>
>> >> >>> ><br>
>> >> >>> > This helps with using VS2015 GUI.<br>
>> >> >>> ><br>
>> >> >>> ><br>
>> >> >>> > On Nov 9, 2015, at 9:28 AM, Matt McCormick<br>
>> >> >>> > <<a href="mailto:matt.mccormick@kitware.com" target="_blank">matt.mccormick@kitware.com</a>><br>
>> >> >>> > wrote:<br>
>> >> >>> ><br>
>> >> >>> >> Hi,<br>
>> >> >>> >><br>
>> >> >>> >> It is time to make the 4.8.2 release. The following patches are<br>
>> >> >>> >> new<br>
>> >> >>> >> on<br>
>> >> >>> >> the release branch since 4.8.1. Is there anything missing?<br>
>> >> >>> >><br>
>> >> >>> >> Thanks,<br>
>> >> >>> >> Matt<br>
>> >> >>> >><br>
>> >> >>> >> Bradley Lowekamp (4):<br>
>> >> >>> >> BUG: Avoid potential exception in itk::Object::UnRegister<br>
>> >> >>> >> BUG: Avoid null deference in PrintSelf with default<br>
>> >> >>> >> construction<br>
>> >> >>> >> BUG: Use const pointer in Set method for constant<br>
>> >> >>> >> ReferenceImage<br>
>> >> >>> >> ivar<br>
>> >> >>> >> BUG: Fix segfault when with empty IsolatedWatershed<br>
>> >> >>> >> Threshold<br>
>> >> >>> >> range<br>
>> >> >>> >><br>
>> >> >>> >> Davis Vigneault (3):<br>
>> >> >>> >> COMP: Warnings in itkVTKImageExport when compiling with<br>
>> >> >>> >> c++11<br>
>> >> >>> >> DOC: Expanded Canny Edge Detection Example<br>
>> >> >>> >> COMP: Warnings in FFTW Classes when compiling with c++11<br>
>> >> >>> >><br>
>> >> >>> >> Eugene Prilepin (1):<br>
>> >> >>> >> BUG: Fix a template name formation in python wrappings<br>
>> >> >>> >><br>
>> >> >>> >> Hans Johnson (5):<br>
>> >> >>> >> STYLE: Minor code style issues for MGHIO<br>
>> >> >>> >> COMP: Update to version for WikiExamples<br>
>> >> >>> >> ENH: Update Sphinx for ITK 4.8.0<br>
>> >> >>> >> ENH: Update MGHIO to be shared lib<br>
>> >> >>> >> BUG: Fix MGHIO to fix write failures<br>
>> >> >>> >><br>
>> >> >>> >> Hyun Jae Kang (4):<br>
>> >> >>> >> BUG: Fix HDF5 CMake configuration with VS2015<br>
>> >> >>> >> BUG: Remove std::cout calls from class<br>
>> >> >>> >> BUG: itkVTKImageIO class does not handle blank lines in VTK<br>
>> >> >>> >> file<br>
>> >> >>> >> header.<br>
>> >> >>> >> BUG: Fixed older XCode linking error<br>
>> >> >>> >><br>
>> >> >>> >> Matthew McCormick (8):<br>
>> >> >>> >> COMP: Do not use C++11 alignas in itkAlignedTypedef.<br>
>> >> >>> >> COMP: Remove unused argument in ConditionVariableNoThreads.<br>
>> >> >>> >> DOC: Correct spelling of Continuous.<br>
>> >> >>> >> COMP: Fix KernelTransform SetFixedParameters argument type.<br>
>> >> >>> >> STYLE: Use prefix increment operator in ImageBase.<br>
>> >> >>> >> COMP: Use ITK's pygccxml by correctly setting up the<br>
>> >> >>> >> sys.path<br>
>> >> >>> >> COMP: Set CMP0054 to new.<br>
>> >> >>> >><br>
>> >> >>> >> Michka Popoff (1):<br>
>> >> >>> >> COMP: Disable incompatible modules when using Python 3<br>
>> >> >>> >> wrapping<br>
>> >> >>> >><br>
>> >> >>> >> Mikhail Isakov (1):<br>
>> >> >>> >> BUG: DiffusionTensor3DReconstruction segfault if no<br>
>> >> >>> >> baseline<br>
>> >> >>> >> image<br>
>> >> >>> >> _______________________________________________<br>
>> >> >>> >> Powered by <a href="http://www.kitware.com" rel="noreferrer" target="_blank">www.kitware.com</a><br>
>> >> >>> >><br>
>> >> >>> >> Visit other Kitware open-source projects at<br>
>> >> >>> >> <a href="http://www.kitware.com/opensource/opensource.html" rel="noreferrer" target="_blank">http://www.kitware.com/opensource/opensource.html</a><br>
>> >> >>> >><br>
>> >> >>> >> Kitware offers ITK Training Courses, for more information visit:<br>
>> >> >>> >> <a href="http://kitware.com/products/protraining.php" rel="noreferrer" target="_blank">http://kitware.com/products/protraining.php</a><br>
>> >> >>> >><br>
>> >> >>> >> Please keep messages on-topic and check the ITK FAQ at:<br>
>> >> >>> >> <a href="http://www.itk.org/Wiki/ITK_FAQ" rel="noreferrer" target="_blank">http://www.itk.org/Wiki/ITK_FAQ</a><br>
>> >> >>> >><br>
>> >> >>> >> Follow this link to subscribe/unsubscribe:<br>
>> >> >>> >> <a href="http://public.kitware.com/mailman/listinfo/insight-developers" rel="noreferrer" target="_blank">http://public.kitware.com/mailman/listinfo/insight-developers</a><br>
>> >> >>> ><br>
>> >> >>> _______________________________________________<br>
>> >> >>> Powered by <a href="http://www.kitware.com" rel="noreferrer" target="_blank">www.kitware.com</a><br>
>> >> >>><br>
>> >> >>> Visit other Kitware open-source projects at<br>
>> >> >>> <a href="http://www.kitware.com/opensource/opensource.html" rel="noreferrer" target="_blank">http://www.kitware.com/opensource/opensource.html</a><br>
>> >> >>><br>
>> >> >>> Kitware offers ITK Training Courses, for more information visit:<br>
>> >> >>> <a href="http://kitware.com/products/protraining.php" rel="noreferrer" target="_blank">http://kitware.com/products/protraining.php</a><br>
>> >> >>><br>
>> >> >>> Please keep messages on-topic and check the ITK FAQ at:<br>
>> >> >>> <a href="http://www.itk.org/Wiki/ITK_FAQ" rel="noreferrer" target="_blank">http://www.itk.org/Wiki/ITK_FAQ</a><br>
>> >> >>><br>
>> >> >>> Follow this link to subscribe/unsubscribe:<br>
>> >> >>> <a href="http://public.kitware.com/mailman/listinfo/insight-developers" rel="noreferrer" target="_blank">http://public.kitware.com/mailman/listinfo/insight-developers</a><br>
>> >> >><br>
>> >> >><br>
>> >> >> _______________________________________________<br>
>> >> >> Powered by <a href="http://www.kitware.com" rel="noreferrer" target="_blank">www.kitware.com</a><br>
>> >> >><br>
>> >> >> Visit other Kitware open-source projects at<br>
>> >> >> <a href="http://www.kitware.com/opensource/opensource.html" rel="noreferrer" target="_blank">http://www.kitware.com/opensource/opensource.html</a><br>
>> >> >><br>
>> >> >> Kitware offers ITK Training Courses, for more information visit:<br>
>> >> >> <a href="http://kitware.com/products/protraining.php" rel="noreferrer" target="_blank">http://kitware.com/products/protraining.php</a><br>
>> >> >><br>
>> >> >> Please keep messages on-topic and check the ITK FAQ at:<br>
>> >> >> <a href="http://www.itk.org/Wiki/ITK_FAQ" rel="noreferrer" target="_blank">http://www.itk.org/Wiki/ITK_FAQ</a><br>
>> >> >><br>
>> >> >> Follow this link to subscribe/unsubscribe:<br>
>> >> >> <a href="http://public.kitware.com/mailman/listinfo/insight-developers" rel="noreferrer" target="_blank">http://public.kitware.com/mailman/listinfo/insight-developers</a><br>
>> >> >><br>
>> >> >> _______________________________________________<br>
>> >> >> Community mailing list<br>
>> >> >> <a href="mailto:Community@itk.org" target="_blank">Community@itk.org</a><br>
>> >> >> <a href="http://public.kitware.com/mailman/listinfo/community" rel="noreferrer" target="_blank">http://public.kitware.com/mailman/listinfo/community</a><br>
>> >> >><br>
>> >> ><br>
</blockquote></div>