<html><head><meta http-equiv="Content-Type" content="text/html charset=us-ascii"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;">Hello,<div><br></div><div>I am upgrading SimpleITK's superbuild to the latest ITK. I have encountered an odd regression..</div><div><br></div><div>Here is the failing test output [1] and here is the source [2], where the check at line 679 fails, because the optimization didn't move.</div><div><br></div><div>What is very odd is that after running a git bisect I found that this patch [3] was the root of the change in behavior:</div><div><br></div><div><div style="margin: 0px; font-size: 11px; font-family: Menlo; color: rgb(175, 173, 36);">commit 51c2ff58e04a25166b6aafc7d7590c2ae74f2ec6</div><div style="margin: 0px; font-size: 11px; font-family: Menlo;">Author: Nick Tustison <<a href="mailto:ntustison@gmail.com">ntustison@gmail.com</a>></div><div style="margin: 0px; font-size: 11px; font-family: Menlo;">Date: Tue Jun 30 21:29:07 2015 -0700</div><div style="margin: 0px; font-size: 11px; font-family: Menlo; min-height: 13px;"><br></div><div style="margin: 0px; font-size: 11px; font-family: Menlo;"> BUG: Set a default b-spline epsilon.</div><p style="margin: 0px; font-size: 11px; font-family: Menlo; min-height: 13px;"> <br class="webkit-block-placeholder"></p><div style="margin: 0px; font-size: 11px; font-family: Menlo;"> The B-spline domain is defined on the closed-half interval</div><div style="margin: 0px; font-size: 11px; font-family: Menlo;"> [a,b) which presents difficulty when we define the image</div><div style="margin: 0px; font-size: 11px; font-family: Menlo;"> domain to be co-extensive with the B-spline domain. Earlier</div><div style="margin: 0px; font-size: 11px; font-family: Menlo;"> attempts at calculating the B-spline domain didn't work as</div><div style="margin: 0px; font-size: 11px; font-family: Menlo;"> this error kept popping up. Therefore we're defining a</div><div style="margin: 0px; font-size: 11px; font-family: Menlo;"> default B-spline epsilon which the user can change depending</div><div style="margin: 0px; font-size: 11px; font-family: Menlo;"> on usage.</div><p style="margin: 0px; font-size: 11px; font-family: Menlo; min-height: 13px;"> <br class="webkit-block-placeholder"></p><div style="margin: 0px; font-size: 11px; font-family: Menlo;"> Change-Id: I64605557fc7131e148c725e0d1cce2e5aa84f31f</div></div><div style="margin: 0px; font-size: 11px; font-family: Menlo;"><br></div><div>After grepping around I found that the BSplineScatteredDataPointSetToImageFilter is used by the WindowConvergenceMonitoringFunction. Which could cause this early convergence I was seeing.</div><div><br></div><div>Perhaps this changed epsilon default value does not not make sense for the ConvergenceMonitoringFunctions?</div><div><br></div><div>Thanks for the additional eyes and opinions on this!</div><div><br></div><div>Brad</div><div><br></div><div>[1] <a href="https://open.cdash.org/testDetails.php?test=380566217&build=4051508">https://open.cdash.org/testDetails.php?test=380566217&build=4051508</a></div><div>[2] <a href="https://github.com/SimpleITK/SimpleITK/blob/master/Testing/Unit/sitkImageRegistrationMethodTests.cxx#L627-L683">https://github.com/SimpleITK/SimpleITK/blob/master/Testing/Unit/sitkImageRegistrationMethodTests.cxx#L627-L683</a></div><div>[3] <a href="https://github.com/InsightSoftwareConsortium/ITK/commit/51c2ff58e04a25166b6aafc7d7590c2ae74f2ec6">https://github.com/InsightSoftwareConsortium/ITK/commit/51c2ff58e04a25166b6aafc7d7590c2ae74f2ec6</a></div></body></html>