<html><head><meta http-equiv="Content-Type" content="text/html charset=utf-8"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class="">Oh, sorry about this Brad. I’m currently on my way out and am still at <div class="">MICCAI but I will look at this tomorrow and see what I can figure out.</div><div class="">Thanks for finding this.</div><div class=""><br class=""></div><div class="">Nick<br class=""><div class=""><div class=""><br class=""></div><div class=""><br class=""></div><div class=""><br class=""></div><div class=""><br class=""><div><blockquote type="cite" class=""><div class="">On Oct 7, 2015, at 5:39 PM, Bradley Lowekamp <<a href="mailto:blowekamp@mail.nih.gov" class="">blowekamp@mail.nih.gov</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><meta http-equiv="Content-Type" content="text/html charset=us-ascii" class=""><div style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class="">Hello,<div class=""><br class=""></div><div class="">I am upgrading SimpleITK's superbuild to the latest ITK. I have encountered an odd regression..</div><div class=""><br class=""></div><div class="">Here is the failing test output [1] and here is the source [2], where the check at line 679 fails, because the optimization didn't move.</div><div class=""><br class=""></div><div class="">What is very odd is that after running a git bisect I found that this patch [3] was the root of the change in behavior:</div><div class=""><br class=""></div><div class=""><div style="margin: 0px; font-size: 11px; font-family: Menlo; color: rgb(175, 173, 36);" class="">commit 51c2ff58e04a25166b6aafc7d7590c2ae74f2ec6</div><div style="margin: 0px; font-size: 11px; font-family: Menlo;" class="">Author: Nick Tustison <<a href="mailto:ntustison@gmail.com" class="">ntustison@gmail.com</a>></div><div style="margin: 0px; font-size: 11px; font-family: Menlo;" class="">Date: Tue Jun 30 21:29:07 2015 -0700</div><div style="margin: 0px; font-size: 11px; font-family: Menlo; min-height: 13px;" class=""><br class=""></div><div style="margin: 0px; font-size: 11px; font-family: Menlo;" class=""> BUG: Set a default b-spline epsilon.</div><div style="margin: 0px; font-size: 11px; font-family: Menlo; min-height: 13px;" class=""> <br class="webkit-block-placeholder"></div><div style="margin: 0px; font-size: 11px; font-family: Menlo;" class=""> The B-spline domain is defined on the closed-half interval</div><div style="margin: 0px; font-size: 11px; font-family: Menlo;" class=""> [a,b) which presents difficulty when we define the image</div><div style="margin: 0px; font-size: 11px; font-family: Menlo;" class=""> domain to be co-extensive with the B-spline domain. Earlier</div><div style="margin: 0px; font-size: 11px; font-family: Menlo;" class=""> attempts at calculating the B-spline domain didn't work as</div><div style="margin: 0px; font-size: 11px; font-family: Menlo;" class=""> this error kept popping up. Therefore we're defining a</div><div style="margin: 0px; font-size: 11px; font-family: Menlo;" class=""> default B-spline epsilon which the user can change depending</div><div style="margin: 0px; font-size: 11px; font-family: Menlo;" class=""> on usage.</div><div style="margin: 0px; font-size: 11px; font-family: Menlo; min-height: 13px;" class=""> <br class="webkit-block-placeholder"></div><div style="margin: 0px; font-size: 11px; font-family: Menlo;" class=""> Change-Id: I64605557fc7131e148c725e0d1cce2e5aa84f31f</div></div><div style="margin: 0px; font-size: 11px; font-family: Menlo;" class=""><br class=""></div><div class="">After grepping around I found that the BSplineScatteredDataPointSetToImageFilter is used by the WindowConvergenceMonitoringFunction. Which could cause this early convergence I was seeing.</div><div class=""><br class=""></div><div class="">Perhaps this changed epsilon default value does not not make sense for the ConvergenceMonitoringFunctions?</div><div class=""><br class=""></div><div class="">Thanks for the additional eyes and opinions on this!</div><div class=""><br class=""></div><div class="">Brad</div><div class=""><br class=""></div><div class="">[1] <a href="https://open.cdash.org/testDetails.php?test=380566217&build=4051508" class="">https://open.cdash.org/testDetails.php?test=380566217&build=4051508</a></div><div class="">[2] <a href="https://github.com/SimpleITK/SimpleITK/blob/master/Testing/Unit/sitkImageRegistrationMethodTests.cxx#L627-L683" class="">https://github.com/SimpleITK/SimpleITK/blob/master/Testing/Unit/sitkImageRegistrationMethodTests.cxx#L627-L683</a></div><div class="">[3] <a href="https://github.com/InsightSoftwareConsortium/ITK/commit/51c2ff58e04a25166b6aafc7d7590c2ae74f2ec6" class="">https://github.com/InsightSoftwareConsortium/ITK/commit/51c2ff58e04a25166b6aafc7d7590c2ae74f2ec6</a></div></div></div></blockquote></div><br class=""></div></div></div></body></html>