<html><head><meta http-equiv="Content-Type" content="text/html charset=iso-8859-1"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;">Hello,<div><br></div><div>Thanks for sharing, I didn't see a a commit with the changes you made. But I got you seeding of the NormalVariateGenerate. Did you write any tests? There is where some time is going to need to be spent.</div><div><br></div><div>I have an initial moving of the code into ITK up in gerrit:</div><div><a href="http://review.source.kitware.com/#/c/14646/1">http://review.source.kitware.com/#/c/14646/1</a></div><div><br></div><div>Eyes on the code are well come as I try to get some time to write some tests.</div><div><br></div><div>Brad</div><div><br></div><div><br><div><div>On Mar 7, 2014, at 12:35 PM, Laurent Chauvin <<a href="mailto:lchauvin@bwh.harvard.edu">lchauvin@bwh.harvard.edu</a>> wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite"><meta http-equiv="Content-Type" content="text/html; charset=iso-8859-1"><div dir="ltr">Hello Bradley,<div><br></div><div>Here is the link of the code I updated.</div><div><a href="https://github.com/lchauvin/itkNoiseFilter">https://github.com/lchauvin/itkNoiseFilter</a><br></div><div><br></div>
<div>Thank you.</div><div>-Laurent</div></div><div class="gmail_extra"><br><br><div class="gmail_quote">On Fri, Mar 7, 2014 at 6:41 AM, Bradley Lowekamp <span dir="ltr"><<a href="mailto:blowekamp@mail.nih.gov" target="_blank">blowekamp@mail.nih.gov</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div style="word-wrap:break-word">Laurent,<div><br></div><div>Giving the interest and generality of this filter. It should be integrated in a proper ITK module and not a Remote. We should be able to get plenty of eyes on to bring it up to ITK standards. Additionally, I really want easy access to this in SimpleITK.</div>
<div><br></div><div>Please submit what you have to gerrit/github/e-mail me and I'll make time to polish it up, and experiment with my proposed scan line based reproducibility.</div><div><br></div><div>Thanks,</div><div>
Brad</div><div><br></div><div><br></div><div><br><div><div class=""><div>On Mar 6, 2014, at 10:21 PM, Matt McCormick <<a href="mailto:matt.mccormick@kitware.com" target="_blank">matt.mccormick@kitware.com</a>> wrote:</div>
<br></div><blockquote type="cite"><div class=""><div dir="ltr">Hi Laurent,<br><div class="gmail_extra"><br><div class="gmail_quote">On Thu, Mar 6, 2014 at 8:49 PM, Laurent Chauvin <span dir="ltr"><<a href="mailto:lchauvin@bwh.harvard.edu" target="_blank">lchauvin@bwh.harvard.edu</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"><div dir="ltr">The code presented in the article is a bit out-dated. There is some minor changed to do to make it compatible with ITKv4.</div>
</blockquote><div><br></div><div>It would be great see your fixes integrated so yourself and others can easily benefit from this work!</div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">
<div dir="ltr"><div><br></div><div>I made these changes locally, and it's compiling fine. However I only tested the AdditiveGaussianNoiseFilter for now.</div>
<div>I can quickly check the other ones.</div><div><br></div><div>What are the next steps to include this code in ITK ?</div></div></blockquote><div><br></div><div>Reorganize the code into an ITK Module [1], then submit a small patch [2]. Please let us know if you have any questions or issues.</div>
<div><br></div><div>Thanks,</div><div>Matt</div><div><br></div><div>[1] <a href="http://www.kitware.com/blog/home/post/557" target="_blank">http://www.kitware.com/blog/home/post/557</a></div><div><br></div><div>[2] <a href="http://www.itk.org/Wiki/ITK/Policy_and_Procedures_for_Adding_Remote_Modules#Procedure_for_Adding_a_Remote_Module" target="_blank">http://www.itk.org/Wiki/ITK/Policy_and_Procedures_for_Adding_Remote_Modules#Procedure_for_Adding_a_Remote_Module</a></div>
</div></div></div></div><div class="">
_____________________________________<br>Powered by <a href="http://www.kitware.com/" target="_blank">www.kitware.com</a><br><br>Visit other Kitware open-source projects at<br><a href="http://www.kitware.com/opensource/opensource.html" target="_blank">http://www.kitware.com/opensource/opensource.html</a><br>
<br>Kitware offers ITK Training Courses, for more information visit:<br><a href="http://www.kitware.com/products/protraining.php" target="_blank">http://www.kitware.com/products/protraining.php</a><br><br>Please keep messages on-topic and check the ITK FAQ at:<br>
<a href="http://www.itk.org/Wiki/ITK_FAQ" target="_blank">http://www.itk.org/Wiki/ITK_FAQ</a><br><br>Follow this link to subscribe/unsubscribe:<br><a href="http://www.itk.org/mailman/listinfo/insight-users" target="_blank">http://www.itk.org/mailman/listinfo/insight-users</a><br>
</div></blockquote></div><br></div><div class=""><div><br class="webkit-block-placeholder"></div><p>The information in this e-mail is intended only for the person to whom it is<br>
addressed. If you believe this e-mail was sent to you in error and the e-mail<br>
contains patient information, please contact the Partners Compliance HelpLine at<br>
<a href="http://www.partners.org/complianceline" target="_blank">http://www.partners.org/complianceline</a> . If the e-mail was sent to you in error<br>
but does not contain patient information, please contact the sender and properly<br>
dispose of the e-mail.</p></div></div></blockquote></div><br><br clear="all"><div><br></div>-- <br><div dir="ltr"><div>Laurent Chauvin, MS</div><div>Surgical Navigation and Robotics Laboratory, Radiology Department</div>
<div>Brigham And Women's Hospital, Harvard Medical School<br></div><div><a href="http://wiki.ncigt.org/index.php/User:Lchauvin" target="_blank">http://wiki.ncigt.org/index.php/User:Lchauvin</a></div></div>
</div>
</blockquote></div><br></div></body></html>