<html><head><meta http-equiv="Content-Type" content="text/html charset=us-ascii"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;">Luis,<div><br></div><div>I noticed some of this too,</div><div><br></div><div>I began poking at it here:</div><div><a href="http://review.source.kitware.com/#/c/13646/2/Modules/Filtering/LabelMap/test/CMakeLists.txt">http://review.source.kitware.com/#/c/13646/2/Modules/Filtering/LabelMap/test/CMakeLists.txt</a></div><div><br></div><div>There are also some tests, which are not even being compiled.</div><div><br></div><div>When I tried wrapping some of these filters in SimpleITK I got a bunch of segfaults, then I looked and saw they had no coverage :(</div><div><br></div><div><br></div><div>Regarding coverage, I have just gotten SimpleITK up to 91.45%. </div><div><br></div><div>Brad</div><div><br><div><div>On Feb 13, 2014, at 7:48 PM, Luis Ibanez <<a href="mailto:luis.ibanez@kitware.com">luis.ibanez@kitware.com</a>> wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite"><meta http-equiv="Content-Type" content="text/html; charset=utf-8"><div dir="ltr">It seems that when some of the LabelMap filters were moved <br>out of the Review directory and into the module<div><br></div><div> Filtering/LabelMaps</div><div><br></div><div>Their .cxx test files were properly moved, but they were not </div>
<div>added to the corresponding CMakeLists.txt file.</div><div><div><br></div><div><br></div><div>As a consequence,</div><div><br></div><div>from the 95 files that have the lowest coverage in ITK:</div><div><br></div><div>
<a href="http://open.cdash.org/viewCoverage.php?buildid=3218139">http://open.cdash.org/viewCoverage.php?buildid=3218139</a><br></div><div><br></div><div><br></div><div>27 of them are LabelMap classes:</div><div><br></div>
<div><div>itkShapeUniqueLabelMapFilter.h</div><div>itkBinaryStatisticsOpeningImageFilter.hxx</div><div>itkBinaryStatisticsKeepNObjectsImageFilter.hxx</div><div>itkBinaryShapeKeepNObjectsImageFilter.hxx</div><div>itkLabelStatisticsKeepNObjectsImageFilter.hxx</div>
<div>itkLabelStatisticsOpeningImageFilter.hxx</div><div>itkLabelShapeKeepNObjectsImageFilter.hxx</div><div>itkLabelShapeOpeningImageFilter.hxx</div><div>itkStatisticsRelabelImageFilter.hxx</div><div>itkShapeRelabelImageFilter.hxx</div>
<div>itkBinaryStatisticsKeepNObjectsImageFilter.h</div><div>itkBinaryStatisticsOpeningImageFilter.h</div><div>itkBinaryShapeKeepNObjectsImageFilter.h</div><div>itkLabelStatisticsKeepNObjectsImageFilter.h</div><div>itkShapeUniqueLabelMapFilter.hxx</div>
<div>itkLabelStatisticsOpeningImageFilter.h</div><div>itkLabelShapeKeepNObjectsImageFilter.h</div><div>itkStatisticsRelabelImageFilter.h</div><div>itkLabelShapeOpeningImageFilter.h</div><div>itkStatisticsOpeningLabelMapFilter.hxx</div>
<div>itkStatisticsKeepNObjectsLabelMapFilter.hxx</div><div>itkShapeRelabelImageFilter.h</div><div>itkStatisticsRelabelLabelMapFilter.hxx</div><div>itkStatisticsUniqueLabelMapFilter.hxx</div><div>itkStatisticsLabelObjectAccessors.h</div>
<div>itkObjectByObjectLabelMapFilter.h</div><div>itkStatisticsLabelObject.h</div></div><div><br></div><div><br></div><div><div>Here is an example of a fix for the code coverage of the</div><div>ShapeUniqueLabelMapFilter:</div>
<div><br></div><div><a href="http://review.source.kitware.com/#/c/14427/">http://review.source.kitware.com/#/c/14427/</a></div></div><div><br></div><div><br></div><div><br></div><div><br></div><div>The next batch of classes with the lowest code coverage</div>
<div>in the toolkit are the following 24 files from the FEM framework:</div><div><br></div><div><div>FEM/src/itkFEMElement3DC0LinearTriangular.cxx</div><div>FEM/src/itkFEMLoadPoint.cxx</div><div>FEM/src/itkFEMElement3DC0LinearTriangularLaplaceBeltrami.cxx</div>
<div>FEM/src/itkFEMLoadNoisyLandmark.cxx</div><div>FEM/src/itkFEMElement2DC0LinearLineStress.cxx</div><div>FEM/include/itkFEMElement3DMembrane1DOF.hxx</div><div>FEM/src/itkFEMElement2DC0QuadraticTriangularStrain.cxx</div>
<div>FEM/src/itkFEMElement2DC0QuadraticTriangularStress.cxx</div><div>FEM/src/itkFEMElement3DC0LinearHexahedronStrain.cxx</div><div>FEM/src/itkFEMElement2DC0LinearQuadrilateralStress.cxx</div><div>FEM/src/itkFEMElement2DC0LinearQuadrilateralStrain.cxx</div>
<div>FEM/src/itkFEMElement3DC0LinearTriangularMembrane.cxx</div><div>FEM/src/itkFEMElement3DC0LinearTetrahedronStrain.cxx</div><div>FEM/src/itkFEMElement3DC0LinearTetrahedronMembrane.cxx</div><div>FEM/src/itkFEMElement2DC0LinearTriangularMembrane.cxx</div>
<div>FEM/src/itkFEMElement2DC0LinearTriangularStrain.cxx</div><div>FEM/src/itkFEMElement2DC0LinearTriangularStress.cxx</div><div>FEM/src/itkFEMLinearSystemWrapper.cxx</div><div>FEM/src/itkFEMLoadElementBase.cxx</div><div>
FEM/src/itkFEMElement2DC1Beam.cxx</div><div>FEM/src/itkFEMElement2DC0LinearLine.cxx</div><div>FEM/src/itkFEMElement2DC0LinearTriangular.cxx</div><div>FEM/src/itkFEMElement2DC0QuadraticTriangular.cxx</div><div>FEM/src/itkFEMLoadLandmark.cxx</div>
</div><div><br></div><div><br></div><div><br></div><div>Raising code coverage is an ideal task for new developers</div><div>who want to get familiar with the system.</div><div><br></div><div><br></div><div>I'll be happy to mentor any ITK community member who would</div>
<div>like to help improve the code coverage of the toolkit, and in the</div><div>process become more familiar with the developing practices</div><div>of ITK.</div><div><br></div><div><br></div><div> Any takers ? :-)</div>
<div><br></div><div><br></div><div>In the meantime, </div><div>I'll be taking care of one of these files per day.</div><div><br></div><div><br></div><div> Luis</div><div><br></div><div><br></div></div></div>
_______________________________________________<br>Powered by <a href="http://www.kitware.com">www.kitware.com</a><br><br>Visit other Kitware open-source projects at<br><a href="http://www.kitware.com/opensource/opensource.html">http://www.kitware.com/opensource/opensource.html</a><br><br>Kitware offers ITK Training Courses, for more information visit:<br>http://kitware.com/products/protraining.php<br><br>Please keep messages on-topic and check the ITK FAQ at:<br>http://www.itk.org/Wiki/ITK_FAQ<br><br>Follow this link to subscribe/unsubscribe:<br>http://www.itk.org/mailman/listinfo/insight-developers<br></blockquote></div><br></div></body></html>