<div dir="ltr">Bradley,<div><br></div><div>I suspect a optimizer issue too, as Debug mode doesn't have the same issues.</div><div><br></div><div>The only caveat is that VS12 implements more of the c++2011 standard than VS11 did, so it's plausible that there is something subtle going on there with the changes in defaul ctors ( or move semantics?)</div>
<div><br></div><div>I am not familiar enough with the ITK (or vnl) codebase *or* the new standard to know if this is likely.</div><div><br></div><div>I will look into the issues when I have time, but your plan sounds sensible to me.</div>
</div><div class="gmail_extra"><br><br><div class="gmail_quote">On Fri, Nov 22, 2013 at 3:28 PM, Bradley Lowekamp <span dir="ltr"><<a href="mailto:brad@lowekamp.net" target="_blank">brad@lowekamp.net</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div style="word-wrap:break-word">Simon,<div><br></div><div>Thanks for this detailed info on the failing tests.</div><div>
<br></div><div>I am leaning to only setting a goal for ITK 4.5 for ITK to compile with VS12 and not all the test passing. As this compiler is barely 1 month old, I am not certain those are not bug in the compiler. It'd be suppressed if there is a real issue with that code. So I am hoping that the first patch for the compiler would fix it...is that reasonable?</div>
<div><br></div><div>But please if you find some concrete fixes please push the upstream!</div><div><br></div><div>Thanks,</div><div>Brad</div><div><br><div><div><div class="h5"><div>On Nov 22, 2013, at 2:23 PM, Simon Alexander <<a href="mailto:skalexander@gmail.com" target="_blank">skalexander@gmail.com</a>> wrote:</div>
<br></div></div><blockquote type="cite"><div><div class="h5"><div dir="ltr">At Bradleys' suggestion I'm forwarding this to the list in general, I still haven't had a chance to look more deeply:<div><br></div>
<div>
Not that my local branch is just a few trivial changes to HEAD to allow compilation with VS12, adding missing header includes. The runs should show up in Experimental from SIMON-LAP<br>
<div><br></div><div><div><br></div><div><br></div><div><span style="font-family:arial,sans-serif;font-size:13px">I reran all tests on my local branch last night that you should be able to see on the dashboard.</span></div>
<div><br></div><div><span style="font-family:arial,sans-serif;font-size:13px">Debug has 7 timeout failures (expected for Debug?)</span><br style="font-family:arial,sans-serif;font-size:13px"><br style="font-family:arial,sans-serif;font-size:13px">
<span style="font-family:arial,sans-serif;font-size:13px">Release mode has 110 failures, all segfaults</span></div><div><span style="font-family:arial,sans-serif;font-size:13px"><br></span></div><div><span style="font-family:arial,sans-serif;font-size:13px">These seem to maybe be related to copy ctor on itk::Vector types and the optimizer (VS12, 64 bit)</span><br>
</div><div><div style="font-family:arial,sans-serif;font-size:13px"><br></div><div style="font-family:arial,sans-serif;font-size:13px">e.g.</div><div style="font-family:arial,sans-serif;font-size:13px"><br></div><div style="font-family:arial,sans-serif;font-size:13px">
<br></div><div style="font-family:arial,sans-serif;font-size:13px">code that looks like this:</div><div style="font-family:arial,sans-serif;font-size:13px"><br></div><div style="font-family:arial,sans-serif;font-size:13px">
<div> typedef typename TOutputImage::SpacingType SpacingType;</div><div> const SpacingType spacing = outputImage->GetSpacing();</div></div><div style="font-family:arial,sans-serif;font-size:13px"><br></div><div style="font-family:arial,sans-serif;font-size:13px">
leads to a segfault as soon as spacing is accessed (in Release mode, not Debug)</div><div style="font-family:arial,sans-serif;font-size:13px"><br></div><div style="font-family:arial,sans-serif;font-size:13px"><br></div><div style="font-family:arial,sans-serif;font-size:13px">
but </div><div style="font-family:arial,sans-serif;font-size:13px"><br></div><div style="font-family:arial,sans-serif;font-size:13px"><div> typedef typename TOutputImage::SpacingType SpacingType;</div><div> const SpacingType &spacing = outputImage->GetSpacing();</div>
</div><div style="font-family:arial,sans-serif;font-size:13px"><br></div><div style="font-family:arial,sans-serif;font-size:13px"><br></div><div style="font-family:arial,sans-serif;font-size:13px">is fine (note the reference, as is returned by GetSpacing)</div>
<div style="font-family:arial,sans-serif;font-size:13px"><br></div><div style="font-family:arial,sans-serif;font-size:13px"><br></div><div style="font-family:arial,sans-serif;font-size:13px">I haven't had a chance to chase it down further than that yet.</div>
</div></div></div></div></div></div>
_______________________________________________<br>Powered by <a href="http://www.kitware.com" target="_blank">www.kitware.com</a><br><br>Visit other Kitware open-source projects at<br><a href="http://www.kitware.com/opensource/opensource.html" target="_blank">http://www.kitware.com/opensource/opensource.html</a><br>
<br>Kitware offers ITK Training Courses, for more information visit:<br><a href="http://kitware.com/products/protraining.php" target="_blank">http://kitware.com/products/protraining.php</a><br><br>Please keep messages on-topic and check the ITK FAQ at:<br>
<a href="http://www.itk.org/Wiki/ITK_FAQ" target="_blank">http://www.itk.org/Wiki/ITK_FAQ</a><br><br>Follow this link to subscribe/unsubscribe:<br><a href="http://www.itk.org/mailman/listinfo/insight-developers" target="_blank">http://www.itk.org/mailman/listinfo/insight-developers</a><br>
</blockquote></div><br></div></div></blockquote></div><br></div>