[CMake] Custom RPM build failing for want of RPMBUILD_FLAGS

[Stewart, Robert]

Have a look at the code I quoted from CPackRPM.cmake:

if(CPACK_RPM_GENERATE_USER_BINARY_SPECFILE_TEMPLATE OR NOT CPACK_RPM_USER_BINARY_SPECFILE)
      set(RPMBUILD_FLAGS "-bb")
If CPACK_RPM_USER_BINARY_SPECFILE is defined, then RPMBUILD_FLAGS is not set to -bb.

___
Rob

From: Eric Noulard [mailto:eric.noulard at gmail.com]
Sent: Friday, March 22, 2019 7:57 AM

Le mer. 6 mars 2019 à 21:33, Stewart, Robert <Robert.Stewart at sig.com<mailto:Robert.Stewart at sig.com>> a écrit :
We've recently upgraded CMake from 2.8+ to 3.5+ (different versions on different platforms).  In so doing, our CMake invocation of CPack to create RPMs now fails and I'm hoping someone can help.  I have a spec file and I want to run rpmbuild -bb, but I can't figure out how to do it.


The result is that my attempt to port to the all-variable approach failed, so I'm setting CPACK_RPM_USER_BINARY_SPECFILE to refer to my spec file as before.  Unfortunately, when I do so, CPackRPM.cmake doesn't set RPMBUILD_FLAGS, and that leads to rpmbuild doing nothing useful.  The issue is in the following code:

    # We should generate a USER spec file template:
    #  - either because the user asked for it : CPACK_RPM_GENERATE_USER_BINARY_SPECFILE_TEMPLATE
    #  - or the user did not provide one : NOT CPACK_RPM_USER_BINARY_SPECFILE
    if(CPACK_RPM_GENERATE_USER_BINARY_SPECFILE_TEMPLATE OR NOT CPACK_RPM_USER_BINARY_SPECFILE)
      set(RPMBUILD_FLAGS "-bb")


I missed that. Do you mean that even though you
set(CPACK_RPM_USER_BINARY_SPECFILE /xxxx)

CPackRPM does not process the spec file with rpmbuild -bb ?

AFAIU from the source:

"-bb" flags are always setup when binary RPM is built.
https://gitlab.kitware.com/cmake/cmake/blob/master/Modules/Internal/CPack/CPackRPM.cmake#L1658

I am confused. Could restate the problem.


--
Eric

________________________________

IMPORTANT: The information contained in this email and/or its attachments is confidential. If you are not the intended recipient, please notify the sender immediately by reply and immediately delete this message and all its attachments. Any review, use, reproduction, disclosure or dissemination of this message or any attachment by an unintended recipient is strictly prohibited. Neither this message nor any attachment is intended as or should be construed as an offer, solicitation or recommendation to buy or sell any security or other financial instrument. Neither the sender, his or her employer nor any of their respective affiliates makes any warranties as to the completeness or accuracy of any of the information contained herein or that this message or any of its attachments is free of viruses.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://cmake.org/pipermail/cmake/attachments/20190322/e3866223/attachment-0001.html>