[CMake] Custom RPM build failing for want of RPMBUILD_FLAGS

[Stewart, Robert]

I’m pretty certain that I did use CPACK_RPM_SPEC_MORE_DEFINE and CPACK_RPM_USER_FILELIST.

CPACK_PROJECT_CONFIG_FILE might help. I’ll take a look.

As for proposing a patch, I’m not certain how things are supposed to work yet, so that seems premature.

Thanks for your thoughts.
___
Rob

From: Eric Noulard [mailto:eric.noulard at gmail.com]
Sent: Friday, March 22, 2019 7:44 AM
To: Stewart, Robert <Robert.Stewart at msx.bala.susq.com>
Cc: cmake at cmake.org
Subject: Re: [CMake] Custom RPM build failing for want of RPMBUILD_FLAGS



Le mer. 6 mars 2019 à 21:33, Stewart, Robert <Robert.Stewart at sig.com<mailto:Robert.Stewart at sig.com>> a écrit :
We've recently upgraded CMake from 2.8+ to 3.5+ (different versions on different platforms).  In so doing, our CMake invocation of CPack to create RPMs now fails and I'm hoping someone can help.  I have a spec file and I want to run rpmbuild -bb, but I can't figure out how to do it.

We have been using a custom spec file all along, but I found information indicating that doing so is (now?) considered a hack and that everything should be possible merely by setting CPACK_* variables.  Unfortunately, that's not the case.

Which CPACK_xxx variables did you use?
CPACK_RPM_SPEC_MORE_DEFINE ?
CPACK_RPM_USER_FILELIST ?


With the following %files entries, CPackRPM.cmake chokes:

%defattr(-, %{user}, %{group}, 0755)
%dir %{destination}
%dir %{versioned}
%dir %{foo}
%{foo}/*.sh
%attr(555, %{user}, %{group}) %{foo}/a
%dir %{bar}
%attr(544, %{user}, %{group}) %{bar}/b
%attr(444, %{user}, %{group}) %{bar}/*common
%{bar}/lib

The result is that my attempt to port to the all-variable approach failed, so I'm setting CPACK_RPM_USER_BINARY_SPECFILE to refer to my spec file as before.  Unfortunately, when I do so, CPackRPM.cmake doesn't set RPMBUILD_FLAGS, and that leads to rpmbuild doing nothing useful.  The issue is in the following code:

    # We should generate a USER spec file template:
    #  - either because the user asked for it : CPACK_RPM_GENERATE_USER_BINARY_SPECFILE_TEMPLATE
    #  - or the user did not provide one : NOT CPACK_RPM_USER_BINARY_SPECFILE
    if(CPACK_RPM_GENERATE_USER_BINARY_SPECFILE_TEMPLATE OR NOT CPACK_RPM_USER_BINARY_SPECFILE)
      set(RPMBUILD_FLAGS "-bb")

I tried just setting RPMBUILD_FLAGS to -bb in my CMakeLists.txt, where I include CPack, but that isn't propagated to CPackRPM.cmake.  I tried adding a custom target that invoked "${CMAKE_CPACK_COMMAND} -D RPMBUILD_FLAGS=-bb", but that didn't work either.

You cannot add flags meant to be used at CPack time in your CMakeLists.txt because CMakeLists.txt is read when *cmake* runs not when *cpack* runs.
See: https://github.com/dev-cafe/cmake-cookbook/tree/master/figures/cmake-times for the description of various times

However you can use https://cmake.org/cmake/help/v3.12/module/CPack.html#variable:CPACK_PROJECT_CONFIG_FILE  for that purpose.
If you specify (in your CMakeLists.txt) the name of a file as set(CPACK_PROJECT_CONFIG_FILE ${CMAKE_CURRENT_BINARY}/mycpack_config.cmake)
then the 'mycpack_config.cmake' will be processed by CPack when it runs.
You can find an example usage here: http://git.savannah.nongnu.org/cgit/certi.git/tree/CMakeLists.txt#n621
in this case the CERTICPackOptions.cmake.in<http://CERTICPackOptions.cmake.in>  (in the source tree) is first configure to CERTICPackOptions.cmake (in the build tree)
then
SET(CPACK_PROJECT_CONFIG_FILE "${CERTI_BINARY_DIR}/CERTICPackOptions.cmake")

indicate that CPack should use it at "CPack-time".

The process describing how "CPACK_PROJECT_CONFIG_FILE" is used is described at the beginning of : https://cmake.org/cmake/help/v3.12/module/CPack.html

If the regex processing of the %files content were more robust, I wouldn't trip over the RPMBUILD_FLAGS issue,

Then may be you can file a patch for making those more robust?

but either CPACK_RPM_USER_BINARY_SPECFILE is supported or it isn't, and since it is currently, it should be possible for me to set RPMBUILD_FLAGS.

Ideas?

1) Use   CPACK_RPM_USER_BINARY_SPECFILE and CPACK_PROJECT_CONFIG_FILE.
2) propose a patch for

--
Eric

________________________________

IMPORTANT: The information contained in this email and/or its attachments is confidential. If you are not the intended recipient, please notify the sender immediately by reply and immediately delete this message and all its attachments. Any review, use, reproduction, disclosure or dissemination of this message or any attachment by an unintended recipient is strictly prohibited. Neither this message nor any attachment is intended as or should be construed as an offer, solicitation or recommendation to buy or sell any security or other financial instrument. Neither the sender, his or her employer nor any of their respective affiliates makes any warranties as to the completeness or accuracy of any of the information contained herein or that this message or any of its attachments is free of viruses.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://cmake.org/pipermail/cmake/attachments/20190322/26455c48/attachment.html>