[CMake] 3.4.1 installer overwrites Windows PATH system var

[Vasily Vladimirovich Vylkov]

Thanks all -- that worked.  The key:
  regedit.exe --> HKLM\SYSTEM\ControlSet001\Control\Environment\Path

had a backup of the path var before the CMake install nuked it.


> How long was your PATH before?

Just my luck, it was 1028 chars long (just 4 over the threshold).



> The installer is produced with NSIS.

Is there a bug filed with NSIS to address this?  Also, there should be
a very prominent warning about this on the CMake download/install page
next to the Windows installer.  Extremely unpleasant from a user
perspective.

On Thu, Dec 3, 2015 at 10:02 AM, Tamás Kenéz <tamas.kenez at gmail.com> wrote:
> about recovering the path see
> http://superuser.com/questions/523688/deleted-path-environment-variable-how-to-restore
>
> On Thursday, December 3, 2015, Brad King <brad.king at kitware.com> wrote:
>>
>> On 12/03/2015 11:04 AM, Vasily Vladimirovich Vylkov wrote:
>> > Installing CMake on Windows (7, 64-bit) with the "add cmake to system
>> > PATH for all users" option overwrote the contents of my PATH variable,
>> > instead of appending to it.  This is horrible!  I don't know of any
>> > way to recover my previous PATH value.
>> >
>> > It also looks like this has been an issue in several previous versions:
>> >   * https://cmake.org/Bug/view.php?id=10257
>> >   * https://cmake.org/Bug/view.php?id=12875
>> >
>> > Shouldn't there be a regression / sanity test case for this prior to
>> > publishing a new version of the installer?
>>
>> For every new release binary we run the installer by hand to verify
>> that the interaction works.  This doesn't happen to us.
>>
>> The installer is produced with NSIS.  I wonder if this is a case of:
>>
>>
>> http://stackoverflow.com/questions/21897103/nsis-envvarupdate-overwrites-system-path-when-path-is-too-long-is-there-a-wor
>>
>> How long was your PATH before?
>>
>> -Brad
>>
>> --
>>
>> Powered by www.kitware.com
>>
>> Please keep messages on-topic and check the CMake FAQ at:
>> http://www.cmake.org/Wiki/CMake_FAQ
>>
>> Kitware offers various services to support the CMake community. For more
>> information on each offering, please visit:
>>
>> CMake Support: http://cmake.org/cmake/help/support.html
>> CMake Consulting: http://cmake.org/cmake/help/consulting.html
>> CMake Training Courses: http://cmake.org/cmake/help/training.html
>>
>> Visit other Kitware open-source projects at
>> http://www.kitware.com/opensource/opensource.html
>>
>> Follow this link to subscribe/unsubscribe:
>> http://public.kitware.com/mailman/listinfo/cmake