[CMake] CMake 2.8.8-rc1, Ninja generator, and clean target

[Peter Collingbourne]

On Mon, Apr 02, 2012 at 02:21:10PM +0200, Nicolas Desprès wrote:
> Hi,
> 
> It looks like an issue in the generator. The symlink is created as a
> side effect of a rule and not mentioned in the output files. That's
> why it does not get removed. I have pushed a patch on my CMake's
> github clone that should fix the issue without breaking cmake's test
> suite. Although it seems to works for your case, I'm not sure it is
> the right way to fix this issue. I think you should open a ticket on
> the bug tracker.
> 
> The branch: https://github.com/polrop/CMake/commits/ninja-clean-lib-symlink
> The patch: https://github.com/polrop/CMake/commit/7d9c4bec56e8ec34ac715a4e4bda0f0f55002ef0
> 
> Peter could you review it please?

Apologies for the slow response.

Perhaps I am being over cautious, but should this conditional:

  if (targetOutputReal == soName) {

read:

  if (targetOutput == soName || targetOutputReal == soName) {

Otherwise, LGTM.

Thanks,
-- 
Peter