[CMake] CMake Ninja generator issues: any showstoppers?

[David Cole]

On Tue, Apr 17, 2012 at 6:43 PM, Clifford Yapp <cliffyapp at gmail.com> wrote:

> On Tue, Apr 17, 2012 at 4:59 PM, David Cole <david.cole at kitware.com>
> wrote:
> > Hello CMake Ninja fans,
> >
> > We are going to be creating the CMake 2.8.8 final release tomorrow.
> However,
> > there are issues reported for the ninja generator. Does anybody consider
> > them "showstoppers" ??
>
> David,
>
> Does the latest CMake 2.8.8 source tree have this fix?
>
> http://www.cmake.org/pipermail/cmake/2012-April/049772.html
>
> Even if it's not the ideal fix, I just tested it and it does seem to
> address one of the ninja clean target issues I was seeing.  Not really
> a show-stopper (definitely not worth another RC, if that's what would
> be involved) but would be a nice-to-have.
>

No -- that change is not in CMake's main repo yet. It is not in the
'release' branch, nor is it in master or next.



>
> CY
>
> P.S. - Is it expected that Ninja respect the
> ADDITIONAL_MAKE_CLEAN_FILES property, or is there a separate property
> for each generator?  If the latter, is there some "common" property
> that can be used to have all generators' clean rules remove the files?
>

I would expect this to work. The Ninja generator still needs some work
before it hits 100% parity with the Unix Makefiles generator.


--
>
> Powered by www.kitware.com
>
> Visit other Kitware open-source projects at
> http://www.kitware.com/opensource/opensource.html
>
> Please keep messages on-topic and check the CMake FAQ at:
> http://www.cmake.org/Wiki/CMake_FAQ
>
> Follow this link to subscribe/unsubscribe:
> http://www.cmake.org/mailman/listinfo/cmake
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://www.cmake.org/pipermail/cmake/attachments/20120418/237866b2/attachment.htm>