[CMake] Suspicious CPU speed calculation on Mac

Rolf Eike Beer eike at sf-mail.de
Sun Oct 24 06:33:46 EDT 2010


Am Saturday 23 October 2010 schrieben Sie:
> On Mon, 18 Oct 2010 14:36:01 +0000, Rolf Eike Beer said:
> >While hacking on gathering system information on QNX (currently completely
> >missing) I found this in SystemInformationImplementation::ParseSysCtl() in
> >
> >source/kwsys/SystemInformation.cxx:
> >  this->CPUSpeedInMHz = static_cast< float >( value )/ 1048576;
> >
> >From what I can find on the web the output is in Hz so it should be
> >divided by 1000000, no?
> 
> I agree, looks like a copy-paste bug.  Indeed, the clock is wrong on our
> dashboards, ex:
> <http://www.cdash.org/CDash/viewSite.php?
> siteid=1987&project=1&currenttime=1287795600>
> 
> Will you submit a bug/patch?

Attached. Fixes the same bug for old x86 processors.

Bill, David, will you pick this up for 2.8.3?

Eike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Fix-CPU-speed-calculations.patch
Type: text/x-patch
Size: 1789 bytes
Desc: not available
URL: <http://www.cmake.org/pipermail/cmake/attachments/20101024/bfff03fc/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: This is a digitally signed message part.
URL: <http://www.cmake.org/pipermail/cmake/attachments/20101024/bfff03fc/attachment.pgp>


More information about the CMake mailing list