[CMake] CMakeDetermineVSServicePack.cmake support for vs2010

[aaron.meadows at thomsonreuters.com]

Done: Issue 0011292

 

Cheers!

 

--aaron

 

Aaron C. Meadows 

________________________________

From: cmake-bounces at cmake.org [mailto:cmake-bounces at cmake.org] On Behalf
Of Meadows, Aaron C.
Sent: Tuesday, October 05, 2010 9:24 AM
To: philip at yhbt.com
Cc: cmake at cmake.org
Subject: Re: [CMake] CMakeDetermineVSServicePack.cmake support for
vs2010

 

I can try and take a look at it.  I actually tried it in a hacky sort of
way and it worked great, but I wasn't using CMake's variable for the
compiler, etc...  I used execute_process() and didn't have any issues
with 'cl /?' waiting on input.  It shaved off several seconds with the
hacked-together version I tried.   I'll see what I can do.

 

--aaron

 

Aaron C. Meadows 

________________________________

From: philiplowman at gmail.com [mailto:philiplowman at gmail.com] On Behalf
Of Philip Lowman
Sent: Thursday, September 30, 2010 8:44 PM
To: Meadows, Aaron C.
Cc: cmake at cmake.org
Subject: Re: [CMake] CMakeDetermineVSServicePack.cmake support for
vs2010

 

On Thu, Sep 30, 2010 at 11:04 AM, <aaron.meadows at thomsonreuters.com>
wrote:

	Done.  Issue number 11279.
[http://public.kitware.com/Bug/view.php?id=11279]

	 

	I also noted that the script could be improved by calling the
compiler with the '/?' switch and parsing it's output instead of parsing
the output from try_compile'ing a simple c file it writes.  That would
make it quite a bit faster.

 

Aaron,

 

Thanks for the patch. I've pushed it to git next.

Regarding your idea to use the output of "cl /?" to determine the
version number, I think it is a good one. If you have time to rewrite
the module to do this instead and test it I would merge the changes for
a future version of CMake.

 

Some potential issues.

1. "cl /?" appears to pause waiting for input, this would have to be
mitigated somehow in a safe way or perhaps just "cl" could be executed
as that appears to include the output.

2. "cl" or "cl /?" output would have to be verified on VS8 to ensure it
outputs there as well (it appears to be there in VS9/Express)

3. You couldn't just run "cl", you would have to find out the CMake
variable for the compiler and run that.

 

My time is really limited. If you're interested, please create a new
ticket and submit a patch. It would save probably at least a second off
of an initial configure.

 

-- 
Philip Lowman


This email was sent to you by Thomson Reuters, the global news and
information company.
Any views expressed in this message are those of the individual sender,
except where the sender specifically states them to be the views of
Thomson Reuters. 



This email was sent to you by Thomson Reuters, the global news and information company.
Any views expressed in this message are those of the individual sender, except where the sender specifically states them to be the views of Thomson Reuters.

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://www.cmake.org/pipermail/cmake/attachments/20101006/0088fa9f/attachment-0001.htm>