[CMake] FindSubversion does not handle REQUIRED option

David Cole david.cole at kitware.com
Thu Jan 28 10:49:48 EST 2010


The wiki page that lists module maintainers is found here:
http://www.itk.org/Wiki/CMake:Module_Maintainers

For FindSubversion.cmake, Tristan Carel is listed as the maintainer.

Perhaps patches for FindSubversion.cmake would more appropriately be added
to patch files attached to a bug report / feature request. (And then that
bug would be assigned to the module maintainer for whatever module it
belongs to.)

Patches tend to get lost in the shuffle on this mailing list.....


David


On Thu, Jan 28, 2010 at 4:07 AM, Marcel Loose <loose at astron.nl> wrote:

> There's a bug in the current FindSubversion.cmake, which causes it to
> ignore the REQUIRED option, when option QUIET is not given. The
> following patch solves this. IMHO, it would be even better to use FPHSA
> for this.
>
> Furthermore, I'm not sure whether it's desirable to conditionally define
> macros. This puts the burden on the user to check Subversion_FOUND
> first, before calling, e.g., Subversion_WC_INFO. I'd prefer to do this
> inside the macro Subversion_WC_INFO.
>
> Just my 2 cents.
> Marcel Loose.
>
>
> Index: FindSubversion.cmake
> ===================================================================
> RCS file: /cvsroot/CMake/CMake/Modules/FindSubversion.cmake,v
> retrieving revision 1.5
> diff -u -r1.5 FindSubversion.cmake
> --- FindSubversion.cmake        28 Sep 2009 15:45:46 -0000      1.5
> +++ FindSubversion.cmake        28 Jan 2010 08:54:18 -0000
> @@ -110,13 +110,13 @@
>  ENDIF(Subversion_SVN_EXECUTABLE)
>
>  IF(NOT Subversion_FOUND)
> -  IF(NOT Subversion_FIND_QUIETLY)
> -    MESSAGE(STATUS "Subversion was not found.")
> -  ELSE(NOT Subversion_FIND_QUIETLY)
> -    IF(Subversion_FIND_REQUIRED)
> -      MESSAGE(FATAL_ERROR "Subversion was not found.")
> -    ENDIF(Subversion_FIND_REQUIRED)
> -  ENDIF(NOT Subversion_FIND_QUIETLY)
> +  IF(Subversion_FIND_REQUIRED)
> +    MESSAGE(FATAL_ERROR "Subversion was not found.")
> +  ELSE(Subversion_FIND_REQUIRED)
> +    IF(NOT Subversion_FIND_QUIETLY)
> +      MESSAGE(STATUS "Subversion was not found.")
> +    ENDIF(NOT Subversion_FIND_QUIETLY)
> +  ENDIF(Subversion_FIND_REQUIRED)
>  ENDIF(NOT Subversion_FOUND)
>
>  # FindSubversion.cmake ends here.
>
>
> _______________________________________________
> Powered by www.kitware.com
>
> Visit other Kitware open-source projects at
> http://www.kitware.com/opensource/opensource.html
>
> Please keep messages on-topic and check the CMake FAQ at:
> http://www.cmake.org/Wiki/CMake_FAQ
>
> Follow this link to subscribe/unsubscribe:
> http://www.cmake.org/mailman/listinfo/cmake
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://www.cmake.org/pipermail/cmake/attachments/20100128/1d8d883e/attachment.htm>


More information about the CMake mailing list