[Cmake] suggestion for FindTclsh

[Miller, James V (Research)]

I'd have to look at our code, but I think we use Win32 threads under cygwin
instead of using pthreads.  So all our code that triggers off of WIN32 being set
does the right thing under VC and cygwin.

So rather than unsetting WIN32, I would suggest triggering off an MFC variable
for the MFC specific code.



-----Original Message-----
From: Bill Hoffman [mailto:bill.hoffman at kitware.com]
Sent: Monday, June 10, 2002 11:22 AM
To: Wheeler, Fred (Research); CMake developers (E-mail)
Subject: Re: [Cmake] suggestion for FindTclsh


The Win32 API is available for cygwin.  It is just MFC that is not available.  

-Bill


At 11:14 AM 6/10/2002 -0400, Wheeler, Fred (Research) wrote:
>I think that this section from FindTclsh.cmake (indentation added)
>
>  IF(WIN32)
>    IF(UNIX)
>      FIND_PROGRAM(TCL_TCLSH cygtclsh80)
>    ENDIF(UNIX)
>  ENDIF(WIN32)
>
>should be changed to this
>
>  IF(CYGWIN)
>    FIND_PROGRAM(TCL_TCLSH cygtclsh80)
>  ENDIF(CYGWIN)
>
>I have found it convenient and quite helpful to unset WIN32 to compile VXL in Cygwin.  One
>side-effect is that this prevents cygtclsh80 from being found using the above, since WIN32 is unset.
>I realize that unsetting WIN32 may be unusual.  Still, I think the change suggested makes things
more
>readable and makes more intuitive sense.  (WIN32 seems to imply that the Windows api is available.
>Same for UNIX.  cygtclsh80 is not in the intersection of the windows and Unix apis.)
>
>Just a suggestion.  Take it or leave it.
>
>Thanks,
>Fred Wheeler
>_______________________________________________
>Cmake mailing list
>Cmake at public.kitware.com
>http://public.kitware.com/mailman/listinfo/cmake 

_______________________________________________
Cmake mailing list
Cmake at public.kitware.com
http://public.kitware.com/mailman/listinfo/cmake