<div dir="ltr">Hi,<br><br>I agree that it should be total number of cores. In addition, cmake_host_system_information() might be extended to provide the number of cores per physical core.<br>This aligns with the information in the XML procuded by CTest: The Site element has the attributes NumberOfLogicalCPU, NumberOfPhysicalCPU, and LogicalProcessorsPerPhysical.<br><br>Cheers, Daniel<br></div><div class="gmail_extra"><br><div class="gmail_quote">On Thu, Jan 26, 2017 at 9:56 PM, Nicolás Bértolo <span dir="ltr"><<a href="mailto:nicolasbertolo@gmail.com" target="_blank">nicolasbertolo@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div bgcolor="#FFFFFF" text="#000000">
Hi,<br>
<br>
This question comes from
<a class="m_-4587959480935084783moz-txt-link-freetext" href="https://gitlab.kitware.com/cmake/cmake/issues/16594" target="_blank">https://gitlab.kitware.com/<wbr>cmake/cmake/issues/16594</a><br>
Currently cmake_host_system_information(<wbr>RESULT logical QUERY
NUMBER_OF_LOGICAL_CORES) is buggy, some parts of the code that
implement it assume it refers to the number of cores in the system
and some assume it is the number of cores per physical core. The
documentation implies it is the total number of cores, but in my
system (AMD FX-8320) it is equal to 1 when it should be 8.<br>
<br>
I have offered myself to fix this bug, but first I would like to
know what is the correct return value of this call should be.<br>
Should it return the number of cores per physical core or the total
number of cores in the system?<br>
<br>
I think it should be the latter, but I would like to hear your
opinions.<br>
<br>
Regards,<br>
Nicolás.<br>
<br>
<pre class="m_-4587959480935084783code m_-4587959480935084783highlight m_-4587959480935084783js-syntax-highlight m_-4587959480935084783cmake m_-4587959480935084783white"><code><span class="m_-4587959480935084783p"></span></code></pre>
<br><br>
<hr style="border:none;color:#909090;background-color:#b0b0b0;height:1px;width:99%">
<table style="border-collapse:collapse;border:none">
<tbody><tr>
<td style="border:none;padding:0px 15px 0px 8px">
<a href="https://www.avast.com/sig-email?utm_medium=email&utm_source=link&utm_campaign=sig-email&utm_content=emailclient" target="_blank">
<img border="0" src="http://static.avast.com/emails/avast-mail-stamp.png" alt="Avast logo">
</a>
</td>
<td>
<p style="color:#3d4d5a;font-family:"Calibri","Verdana","Arial","Helvetica";font-size:12pt">
El software de antivirus Avast ha analizado este correo electrónico en busca de virus.
<br><a href="https://www.avast.com/sig-email?utm_medium=email&utm_source=link&utm_campaign=sig-email&utm_content=emailclient" target="_blank">www.avast.com</a>
</p>
</td>
</tr>
</tbody></table>
<br>
</div>
<br>--<br>
<br>
Powered by <a href="http://www.kitware.com" rel="noreferrer" target="_blank">www.kitware.com</a><br>
<br>
Please keep messages on-topic and check the CMake FAQ at: <a href="http://www.cmake.org/Wiki/CMake_FAQ" rel="noreferrer" target="_blank">http://www.cmake.org/Wiki/<wbr>CMake_FAQ</a><br>
<br>
Kitware offers various services to support the CMake community. For more information on each offering, please visit:<br>
<br>
CMake Support: <a href="http://cmake.org/cmake/help/support.html" rel="noreferrer" target="_blank">http://cmake.org/cmake/help/<wbr>support.html</a><br>
CMake Consulting: <a href="http://cmake.org/cmake/help/consulting.html" rel="noreferrer" target="_blank">http://cmake.org/cmake/help/<wbr>consulting.html</a><br>
CMake Training Courses: <a href="http://cmake.org/cmake/help/training.html" rel="noreferrer" target="_blank">http://cmake.org/cmake/help/<wbr>training.html</a><br>
<br>
Visit other Kitware open-source projects at <a href="http://www.kitware.com/opensource/opensource.html" rel="noreferrer" target="_blank">http://www.kitware.com/<wbr>opensource/opensource.html</a><br>
<br>
Follow this link to subscribe/unsubscribe:<br>
<a href="http://public.kitware.com/mailman/listinfo/cmake-developers" rel="noreferrer" target="_blank">http://public.kitware.com/<wbr>mailman/listinfo/cmake-<wbr>developers</a><br></blockquote></div><br></div>