<div dir="ltr">Hi again.<div><br></div><div>I performed all the aforementioned actions, please check everything is OK for you.</div><div><br></div><div>I have a few questions:</div><div>* the test CMake.CheckSourceTree does not work with Fastbuild, but I could not get it to work with Ninja either, maybe I have an environment problem ?</div><div>* the test SimpleInstall requires trhe build tool to be able to run multiple instances in the same hierarchy, which Fastbuild does not support. Should I refactor the test to remove this requirement ? Or simply ignore the test ?</div><div>* It seems SimpleInstall-Stage2 depends upon SimpleInstall, is this right ?</div><div><br></div><div>The branch I recently pushed has only a few tests failing, quite a few seem to be related to a lack of non-source file dependencies as far as I can tell.</div><div><br></div><div>Thanks.</div></div><br><div class="gmail_quote"><div dir="ltr">Le jeu. 6 oct. 2016 à 19:33, Charles Huet <<a href="mailto:charles.huet@gmail.com">charles.huet@gmail.com</a>> a écrit :<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr" class="gmail_msg"><div class="gmail_msg"><span style="color:rgb(33,33,33);font-family:"helvetica neue",helvetica,arial,sans-serif" class="gmail_msg">>* Please use Utilities/Scripts/clang-format</span><span style="color:rgb(33,33,33);font-family:"helvetica neue",helvetica,arial,sans-serif" class="gmail_msg">.bash for</span><br class="gmail_msg" style="color:rgb(33,33,33);font-family:"helvetica neue",helvetica,arial,sans-serif"><span style="color:rgb(33,33,33);font-family:"helvetica neue",helvetica,arial,sans-serif" class="gmail_msg">> code style. This is easy to apply automatically later</span><br class="gmail_msg" style="color:rgb(33,33,33);font-family:"helvetica neue",helvetica,arial,sans-serif"><span style="color:rgb(33,33,33);font-family:"helvetica neue",helvetica,arial,sans-serif" class="gmail_msg">> so don't worry about it too much.</span> <span style="color:rgb(33,33,33);font-family:"helvetica neue",helvetica,arial,sans-serif" class="gmail_msg"><br class="gmail_msg"></span></div></div><div dir="ltr" class="gmail_msg"><span style="color:rgb(33,33,33);font-family:"helvetica neue",helvetica,arial,sans-serif" class="gmail_msg"><div class="gmail_msg"><span style="color:rgb(33,33,33);font-family:"helvetica neue",helvetica,arial,sans-serif" class="gmail_msg">I'll get on this soon, I like to have proper style.</span></div></span></div><div dir="ltr" class="gmail_msg"><span style="color:rgb(33,33,33);font-family:"helvetica neue",helvetica,arial,sans-serif" class="gmail_msg"><div class="gmail_msg"><span style="color:rgb(33,33,33);font-family:"helvetica neue",helvetica,arial,sans-serif" class="gmail_msg"><br class="gmail_msg"></span></div><div class="gmail_msg"><span style="color:rgb(33,33,33);font-family:"helvetica neue",helvetica,arial,sans-serif" class="gmail_msg"><br class="gmail_msg"></span></div>> * For final integration I'd like the commits to be squashed</span></div><div dir="ltr" class="gmail_msg"><br class="gmail_msg" style="color:rgb(33,33,33);font-family:"helvetica neue",helvetica,arial,sans-serif"><span style="color:rgb(33,33,33);font-family:"helvetica neue",helvetica,arial,sans-serif" class="gmail_msg">> and arranged in an organized way. This is hard to do until</span><br class="gmail_msg" style="color:rgb(33,33,33);font-family:"helvetica neue",helvetica,arial,sans-serif"><span style="color:rgb(33,33,33);font-family:"helvetica neue",helvetica,arial,sans-serif" class="gmail_msg">> you have everything working though.</span> <br class="gmail_msg"><div class="gmail_msg"><br class="gmail_msg"></div></div><div dir="ltr" class="gmail_msg"><div class="gmail_msg">Sure. For now there are the first few commits which I can't change much to keep proper attribuation, and a few commits on top which will be squashed together once the dev is complete (or maybe earlier if I feel like it).</div></div><div dir="ltr" class="gmail_msg"><div class="gmail_msg"><br class="gmail_msg"></div><div class="gmail_msg">><span style="color:rgb(33,33,33);font-family:"helvetica neue",helvetica,arial,sans-serif" class="gmail_msg">* Please update the license notices to use the new style that</span></div><span style="color:rgb(33,33,33);font-family:"helvetica neue",helvetica,arial,sans-serif" class="gmail_msg">> we switched to in `master`. Both C++ and .cmake notices</span><br class="gmail_msg" style="color:rgb(33,33,33);font-family:"helvetica neue",helvetica,arial,sans-serif"><span style="color:rgb(33,33,33);font-family:"helvetica neue",helvetica,arial,sans-serif" class="gmail_msg">> changed.</span></div><div dir="ltr" class="gmail_msg"><div class="gmail_msg"><span style="color:rgb(33,33,33);font-family:"helvetica neue",helvetica,arial,sans-serif" class="gmail_msg">Will do.</span></div></div><br class="gmail_msg"><div class="gmail_quote gmail_msg"><div dir="ltr" class="gmail_msg">Le jeu. 6 oct. 2016 à 17:32, Brad King <<a href="mailto:brad.king@kitware.com" class="gmail_msg" target="_blank">brad.king@kitware.com</a>> a écrit :<br class="gmail_msg"></div><blockquote class="gmail_quote gmail_msg" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">On 10/06/2016 08:32 AM, Charles Huet wrote:<br class="gmail_msg">
> Do you think it is time to start the review, or should it wait<br class="gmail_msg">
> until I have 100% of the tests passing ?<br class="gmail_msg">
<br class="gmail_msg">
Thanks for the update. Generally my reviews for new features<br class="gmail_msg">
mostly look at documentation, tests, style, etc. rather than<br class="gmail_msg">
at implementation details (which can easily be fixed/changed<br class="gmail_msg">
later). Therefore final review and integration should not start<br class="gmail_msg">
until everything is working.<br class="gmail_msg">
<br class="gmail_msg">
However, I'm happy to take quick glances at progress once in<br class="gmail_msg">
a while. Here are some comments from the current version:<br class="gmail_msg">
<br class="gmail_msg">
* Please use Utilities/Scripts/clang-format.bash for<br class="gmail_msg">
code style. This is easy to apply automatically later<br class="gmail_msg">
so don't worry about it too much.<br class="gmail_msg">
<br class="gmail_msg">
* For final integration I'd like the commits to be squashed<br class="gmail_msg">
and arranged in an organized way. This is hard to do until<br class="gmail_msg">
you have everything working though.<br class="gmail_msg">
<br class="gmail_msg">
* Please update the license notices to use the new style that<br class="gmail_msg">
we switched to in `master`. Both C++ and .cmake notices<br class="gmail_msg">
changed.<br class="gmail_msg">
<br class="gmail_msg">
Thanks,<br class="gmail_msg">
-Brad<br class="gmail_msg">
<br class="gmail_msg">
</blockquote></div></blockquote></div>