<p dir="ltr">Hi </p>
<div class="gmail_quote">Am 07.06.2016 16:48 schrieb "Brad King" <<a href="mailto:brad.king@kitware.com">brad.king@kitware.com</a>>:<br type="attribution"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">On 06/07/2016 10:42 AM, Tobias Hunger wrote:<br>
> On Mo, 2016-06-06 at 13:24 -0400, Brad King wrote:<br>
>> We should be able to refactor things to share the flags computation.<br>
>> Methods like<br>
>><br>
>>   cmLocalGenerator::GetTargetFlags<br>
><br>
> Does this patch here make sense:<br>
><br>
> <a href="https://github.com/hunger/CMake/commit/124f8295bee0c228b79a5cf38f0b2581be308118" rel="noreferrer" target="_blank">https://github.com/hunger/CMake/commit/124f8295bee0c228b79a5cf38f0b2581be308118</a><br>
><br>
> It passes the configuration to GetTargetFlags instead of forcing it to the build<br>
> type. Since I may end up with different configurations in the project structure,<br>
> I think this is necessary.<br>
<br>
Yes.  Previously that method was only called in single-configuration<br>
generators so it could look up the CMAKE_BUILD_TYPE directly.  In<br>
multi-config generators that variable is meaningless and instead they<br>
iterate over CMAKE_CONFIGURATION_TYPES.<br>
<br>
When you have a few such independent refactoring changes done<br>
we can look at integrating them immediately to avoid holding<br>
them externally in your daemon topic for too long.<br>
<br>
Thanks,<br>
-Brad<br>
<br>
--<br>
<br>
Powered by <a href="http://www.kitware.com" rel="noreferrer" target="_blank">www.kitware.com</a><br>
<br>
Please keep messages on-topic and check the CMake FAQ at: <a href="http://www.cmake.org/Wiki/CMake_FAQ" rel="noreferrer" target="_blank">http://www.cmake.org/Wiki/CMake_FAQ</a><br>
<br>
Kitware offers various services to support the CMake community. For more information on each offering, please visit:<br>
<br>
CMake Support: <a href="http://cmake.org/cmake/help/support.html" rel="noreferrer" target="_blank">http://cmake.org/cmake/help/support.html</a><br>
CMake Consulting: <a href="http://cmake.org/cmake/help/consulting.html" rel="noreferrer" target="_blank">http://cmake.org/cmake/help/consulting.html</a><br>
CMake Training Courses: <a href="http://cmake.org/cmake/help/training.html" rel="noreferrer" target="_blank">http://cmake.org/cmake/help/training.html</a><br>
<br>
Visit other Kitware open-source projects at <a href="http://www.kitware.com/opensource/opensource.html" rel="noreferrer" target="_blank">http://www.kitware.com/opensource/opensource.html</a><br>
<br>
Follow this link to subscribe/unsubscribe:<br>
<a href="http://public.kitware.com/mailman/listinfo/cmake-developers" rel="noreferrer" target="_blank">http://public.kitware.com/mailman/listinfo/cmake-developers</a><br>
</blockquote></div>