<html dir="ltr">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=iso-8859-1">
<style type="text/css" id="owaParaStyle"></style>
</head>
<body fpstyle="1" ocsi="0" class=" hasGoogleVoiceExt">
<div style="direction: ltr;font-family: Tahoma;color: #000000;font-size: 10pt;">Brad,
<div><br>
</div>
<div>Here is a repeat and reformatted version of the email I sent off list (sorry about that). The attached file also addresses comments from Stephen Kelly concerning <span style="font-family: 'Segoe UI', Helvetica, Arial, sans-serif; font-size: 13.3333339691162px;">IMPORTED_CONFIGURATIONS.</span></div>
<div><br>
</div>
<div>
<div>Brad King wrote:</div>
<div><br>
</div>
<div>> > The command "add_library(GSL::gsl UNKOWN IMPORTED)" generates</div>
<div>> > warnings on platforms that do not support shared libraries.</div>
<div>> That is a bug in the warning. Fixed:</div>
<div>> add_library: Fix target type check for non-shared-lib platforms</div>
<div>> http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=bd360ee3</div>
<div>> The check can be dropped from the version of FindGSL that goes in</div>
<div>> CMake.</div>
<div><br>
</div>
<div>I rebased to the git HEAD to test your fix (bd360ee3 works for my systems)</div>
<div>and removed the <span style="font-size: 10pt;">unnecessary code that checked if the system supported </span></div>
<div><span style="font-size: 10pt;">shared </span><span style="font-size: 10pt;">libraries. </span></div>
<div><br>
</div>
<div>> Please try installing sphinx and enabling the SPHINX_HTML build</div>
<div>> option of CMake. Then look at the Utilities/Sphinx/html</div>
<div>> documentation generated for this module. Update the reST</div>
<div>> syntax accordingly.</div>
<div><br>
</div>
<div>
<div>I corrected the documentation formatting after building it with</div>
<div>Sphinx. I will comment that I had a little trouble installing</div>
<div>Sphinx since we do not have root access to our Linux machines. I</div>
<div>can only install software that I can install at $HOME. (Can you</div>
<div>point me to any instructions for installing Sphynx w/o root</div>
<div>access?) However, I was able to get it working on a Windows</div>
<div>machine and was able to clean up the documentation a bit. I also</div>
<div>modified Help/manual/cmake-modules.7.rst and added</div>
<div>Help/module/FindGSL.rst as required.</div>
</div>
<div><br>
</div>
<div>> My comment was not about removing GSL_ROOT_DIR altogether, but</div>
<div>> about not documenting it as a guaranteed result variable that</div>
<div>> applications can use. Instead it should be treated as an</div>
<div>> input/hint variable that may not be set but will be used if it</div>
<div>> is set. It's just a matter of which section documents it.</div>
<div><br>
</div>
<div>Comments about GSL_ROOT_DIR were moved to the HINTS section only.</div>
<div>I also removed this variable from</div>
<div>find_package_handle_standard_args's REQUIRED_VARS section. (I</div>
<div>understand your comment now).</div>
<div><br>
</div>
<div>> You could use the REGEX option to file(STRINGS) to shorten the</div>
<div>> amount of data loaded.</div>
<div><br>
</div>
<div>I simplified the search for GSL_VERSION as you suggested. Thanks</div>
<div>for the pointer, this code was copied from some very old cmake</div>
<div>scripts w/o much thought -- but your way is clearly better.</div>
<div><br>
</div>
<div>> > REQUIRED_VARS</div>
<div>> > GSL_INCLUDE_DIRS</div>
<div>> > GSL_LIBRARIES</div>
<div>> The singular names (find_* command results) should be listed</div>
<div>> here because the error messages generated when they are not set</div>
<div>> are intended to ask the user to set the values in the cache.</div>
<div>> The plural names are not what the user would set.</div>
<div><br>
</div>
<div>I have a better understanding of the REQUIRED_VARS section of</div>
<div>find_package_handle_standard_args now and have made the updates</div>
<div>that you recommended.</div>
<div><br>
</div>
<div>A new versions of FindGSL is attached. The other modified files</div>
<div>are very simple and I will not bother you with those changes.</div>
<div><br>
</div>
<div>-kt</div>
</div>
<div><br>
</div>
</div>
</body>
</html>