<div dir="ltr">Hey Roger, thanks for the contribution! A couple of points on find_module convention, most of which you can find in <a href="http://cmake.org/cmake/help/v3.0/manual/cmake-developer.7.html#modules" target="_blank">http://cmake.org/cmake/help/v3.0/manual/cmake-developer.7.html#modules</a>. Not all find modules currently shipped have been updated for these best practices but new modules should try to stick to them.<br>
<ul><li>Xerces_INCLUDE_DIR should be used to control the cache search but not as a final output variable. Use Xerces_INCLUDE_DIRS. This helps with some consistency since some libs may have only 1 include directory and others have several. This way all find modules produce a Foo_INCLUDE_DIRS variable instead of some producing _DIR and others producing _DIRS</li>
<li>Xerces_LIBRARY_DIR is not actually used and should be removed from documentation.</li><li>Use Xerces_INCLUDE_DIR and Xerces_LIBRARY as the find_path and find_library variables. After successfully passing the FIND_PACKAGE_HANDLE_STANDARD_ARGS, then set the _INCLUDE_DIRS and _LIBRARIES variables accordingly.<br>
</li><li>Try to stick with either all mixed-case or all uppercase variable names. No need to mix Xerces_FOO with XERCES_FOO. In this case, keeping with all mixed case would be appropriate.</li><li>Don't delete the version variable afterwards, it's good have set by the find module as an output variable Xerces_VERSION.<br>
</li></ul><div class="gmail_extra"><br clear="all"><div><div dir="ltr">- Chuck<br></div></div>
<br><br><div class="gmail_quote">On Sat, Aug 16, 2014 at 6:48 AM, Roger Leigh <span dir="ltr"><<a href="mailto:rleigh@codelibre.net" target="_blank">rleigh@codelibre.net</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
Hi,<br>
<br>
Attached is a patch to add support for Apache Xerces-C++.<br>
This project is quite an old one, and doesn't have any<br>
support for cmake at present. This will allow cmake<br>
projects to use current and older Xerces releases.<br>
<br>
<br>
Regards,<br>
Roger<br>
<span><font color="#888888"><br>
--<br>
 .''`. Roger Leigh<br>
 : :' : Debian GNU/Linux  <a href="http://people.debian.org/~rleigh/" target="_blank">http://people.debian.org/~rleigh/</a><br>
 `. `'  schroot and sbuild <a href="http://alioth.debian.org/projects/buildd-tools" target="_blank">http://alioth.debian.org/projects/buildd-tools</a><br>
  `-  GPG Public Key   F33D 281D 470A B443 6756 147C 07B3 C8BC 4083 E800<br>
</font></span><br>--<br>
<br>
Powered by <a href="http://www.kitware.com" target="_blank">www.kitware.com</a><br>
<br>
Please keep messages on-topic and check the CMake FAQ at: <a href="http://www.cmake.org/Wiki/CMake_FAQ" target="_blank">http://www.cmake.org/Wiki/CMake_FAQ</a><br>
<br>
Kitware offers various services to support the CMake community. For more information on each offering, please visit:<br>
<br>
CMake Support: <a href="http://cmake.org/cmake/help/support.html" target="_blank">http://cmake.org/cmake/help/support.html</a><br>
CMake Consulting: <a href="http://cmake.org/cmake/help/consulting.html" target="_blank">http://cmake.org/cmake/help/consulting.html</a><br>
CMake Training Courses: <a href="http://cmake.org/cmake/help/training.html" target="_blank">http://cmake.org/cmake/help/training.html</a><br>
<br>
Visit other Kitware open-source projects at <a href="http://www.kitware.com/opensource/opensource.html" target="_blank">http://www.kitware.com/opensource/opensource.html</a><br>
<br>
Follow this link to subscribe/unsubscribe:<br>
<a href="http://public.kitware.com/mailman/listinfo/cmake-developers" target="_blank">http://public.kitware.com/mailman/listinfo/cmake-developers</a><br></blockquote></div><br></div></div>