Oh, sweet, didn't know there was a bug open for this. +1! Can't wait to get my hands dirty with 2.8.4<div><br><div>-Johan</div><div><br><br><div class="gmail_quote">On Thu, Dec 16, 2010 at 8:46 AM, Michael Wild <span dir="ltr"><<a href="mailto:themiwi@gmail.com">themiwi@gmail.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;">Thanks Brad, that's fantastic! Kind of a premature Christmas gift ;-)<br>
<br>
Michael<br>
<br>
On 12/15/2010 09:43 PM, Mantis Bug Tracker wrote:<br>
><br>
> The following issue has been RESOLVED.<br>
> ======================================================================<br>
> <a href="http://public.kitware.com/Bug/view.php?id=11209" target="_blank">http://public.kitware.com/Bug/view.php?id=11209</a><br>
> ======================================================================<br>
> Reported By: Michael Wild<br>
> Assigned To: Brad King<br>
> ======================================================================<br>
> Project: CMake<br>
> Issue ID: 11209<br>
> Category: CMake<br>
> Reproducibility: N/A<br>
> Severity: feature<br>
> Priority: normal<br>
> Status: resolved<br>
> Resolution: fixed<br>
> Fixed in Version:<br>
> ======================================================================<br>
> Date Submitted: 2010-09-07 02:10 EDT<br>
> Last Modified: 2010-12-15 15:43 EST<br>
> ======================================================================<br>
> Summary: Support generator expression everywhere they make<br>
> sense<br>
> Description:<br>
> It would be very convenient if CMake supported the generator expressions<br>
> available in the ADD_TEST command in all user-definable commands that run at<br>
> build time. ADD_CUSTOM_COMMAND and ADD_CUSTOM_TARGET spring to mind.<br>
> ======================================================================<br>
> Relationships ID Summary<br>
> ----------------------------------------------------------------------<br>
> related to 0009974 CMake should support custom commands th...<br>
> ======================================================================<br>
><br>
> ----------------------------------------------------------------------<br>
> (0024189) Brad King (developer) - 2010-12-15 15:36<br>
> <a href="http://public.kitware.com/Bug/view.php?id=11209#c24189" target="_blank">http://public.kitware.com/Bug/view.php?id=11209#c24189</a><br>
> ----------------------------------------------------------------------<br>
> I've wanted to do this feature for a long time. I finally got my chance this<br>
> month and have been working on it for a couple weeks.<br>
><br>
> The main commit is<br>
><br>
> <a href="http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=f0cdb600" target="_blank">http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=f0cdb600</a><br>
><br>
> but a lot of refactoring and cleanup was needed to get to that point. The full<br>
> commit range produced by this effort was<br>
><br>
> git log --graph afc89064..f0cdb600<br>
><br>
> ----------------------------------------------------------------------<br>
> (0024190) Brad King (developer) - 2010-12-15 15:42<br>
> <a href="http://public.kitware.com/Bug/view.php?id=11209#c24190" target="_blank">http://public.kitware.com/Bug/view.php?id=11209#c24190</a><br>
> ----------------------------------------------------------------------<br>
> Commit f0cdb600 adds support for generator expressions in add_custom_command and<br>
> add_custom target. They already work in add_test.<br>
><br>
> The only other place I can think that non-C++ (pure CMake) code can define<br>
> commands is the Makefile generator rule variables like<br>
> CMAKE_<lang>_COMPILE_OBJECT. These are very specific to one generator though.<br>
> Actually the placeholder syntax they use, such as "<TARGET>", was one of the<br>
> reasons we chose $<> syntax for generator expressions in the first place. We<br>
> anticipated adding them elsewhere beyond add_test. However, since rule<br>
> variables are already expanded with per-configuration substitution I don't<br>
> currently see a use case for generator expressions there. Although it may help<br>
> cleanup our builtin rule variables we would always have to support the old-style<br>
> placeholders so I don't want to add extra code until we have a good reason.<br>
><br>
> Issue History<br>
> Date Modified Username Field Change<br>
> ======================================================================<br>
> 2010-09-07 02:10 Michael Wild New Issue<br>
> 2010-12-15 12:02 David Cole Assigned To => Brad King<br>
> 2010-12-15 12:02 David Cole Status new => assigned<br>
> 2010-12-15 14:28 Brad King Relationship added related to 0009974<br>
> 2010-12-15 15:36 Brad King Note Added: 0024189<br>
> 2010-12-15 15:42 Brad King Note Added: 0024190<br>
> 2010-12-15 15:43 Brad King Status assigned => resolved<br>
> 2010-12-15 15:43 Brad King Resolution open => fixed<br>
> ======================================================================<br>
><br>
<br>
_______________________________________________<br>
cmake-developers mailing list<br>
<a href="mailto:cmake-developers@cmake.org">cmake-developers@cmake.org</a><br>
<a href="http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers" target="_blank">http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers</a><br>
</blockquote></div><br></div></div>