[cmake-developers] [Patch] ExternalProject: fix retry logic if error occurs

Ruslan Baratov ruslan_baratov at yahoo.com
Thu May 19 09:49:40 EDT 2016


It's a little bit tricky to split refactor/new functionality exact but 
I've created several patches with step-by-step changes. Hope this helps 
in review.

Ruslo

On 18-May-16 22:50, Brad King wrote:
> On 05/18/2016 03:30 PM, Ruslan Baratov via cmake-developers wrote:
>> I've attached patch with applying retry logic in cases when status code
>> is not zero.
> Thanks.  Please split the patch to perform the refactoring into
> the ExternalProject-$step.cmake.in files first and then make the
> logic changes as a second patch.  Also please add an explanation
> of the logic change to the second commit message similar to what
> you wrote in the original email.
>
> -Brad
>

-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-ExternalProject-refactoring-uppercase-variables.patch
Type: text/x-patch
Size: 4764 bytes
Desc: not available
URL: <http://public.kitware.com/pipermail/cmake-developers/attachments/20160519/998eee4b/attachment-0006.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-ExternalProject-refactoring-remove-retries.patch
Type: text/x-patch
Size: 2250 bytes
Desc: not available
URL: <http://public.kitware.com/pipermail/cmake-developers/attachments/20160519/998eee4b/attachment-0007.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0003-ExternalProject-remove-unused-logic.patch
Type: text/x-patch
Size: 2441 bytes
Desc: not available
URL: <http://public.kitware.com/pipermail/cmake-developers/attachments/20160519/998eee4b/attachment-0008.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0004-ExternalProject-refactoring-avoid-double-verificatio.patch
Type: text/x-patch
Size: 1479 bytes
Desc: not available
URL: <http://public.kitware.com/pipermail/cmake-developers/attachments/20160519/998eee4b/attachment-0009.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0005-ExternalProject-use-separate-verify-script-ExternalP.patch
Type: text/x-patch
Size: 4504 bytes
Desc: not available
URL: <http://public.kitware.com/pipermail/cmake-developers/attachments/20160519/998eee4b/attachment-0010.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0006-ExternalProject-use-separate-download-script-Externa.patch
Type: text/x-patch
Size: 7452 bytes
Desc: not available
URL: <http://public.kitware.com/pipermail/cmake-developers/attachments/20160519/998eee4b/attachment-0011.bin>


More information about the cmake-developers mailing list