[cmake-developers] Using CMake generated ninja file as a subninja file

[Brad King]

On 05/13/2016 03:25 PM, Brad King wrote:
> so for now please make your logic recognize this case and work around it.

Please split this into two commits to move hunks like this:

> +  this->TargetAll = this->NinjaOutputPath("all");
> +  this->CMakeCacheFile = this->NinjaOutputPath("CMakeCache.txt");

into a preceding commit that performs refactoring with no functional change.

Also, in hunks like this:

> -  std::string convPath = ng->Convert(path, cmOutputConverter::HOME_OUTPUT);
> +  std::string convPath = ng->Convert(path, cmOutputConverter::FULL, format);

please revise the logic so that *nothing changes* from the old logic
when no subninja prefix is set.  If this is going to break anything I'd
like it to be isolated to when this feature is used.  Consolidation of
the two code paths can be done later when we've seen the new feature in
use for a while and gained confidence in it.

Thanks,
-Brad