[cmake-developers] [Patch] FindPkgConfig: optionally create imported target for the found libraries
Brad King
brad.king at kitware.com
Fri May 13 13:38:52 EDT 2016
On 05/13/2016 12:21 PM, Rolf Eike Beer wrote:
>> Can you just use
>>
>> set_property(TARGET PkgConfig::${_prefix} PROPERTY ...)
>>
>> in each `if()` block?
>
> I had this before, but I thought I avoid multiple target lookups. You should
> only ever see that message if none of the branches is taken I think. And that
> should never happen, or the if before is wrong. Can you add a message() and
> show what is actually in _props there?
The problem is that _libs has more than one value, so set_target_properties
ends up with
PROPERTIES PROP1 v1 PROP2 v2a v2b PROP3 v3
^^^^^^^
Please use set_property(TARGET). It is much more robust, and this is not
exactly a performance-critical loop.
Thanks,
-Brad
More information about the cmake-developers
mailing list